mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear
Date: Mon, 16 Nov 2026 08:06:27 -0800	[thread overview]
Message-ID: <9cb88cc0-f1f2-4c43-8a63-2698164da76b@linux.intel.com> (raw)
In-Reply-To: <avrouGIdiXIxE_5Y@wunner.de>

Hi,

On 11/16/26 03:27, Lukas Wunner wrote:
> On Tue, Nov 03, 2026 at 11:31:36AM -0800, Kuppuswamy Sathyanarayanan wrote:
>> Intel Catlow Lake PCH Root Ports do not set PME Status in the Root
>> Status register when they generate a PME for their own hotplug event.
>> The PME interrupt itself is delivered.  PMEs from devices below the Root
>> Port are reported correctly.
> 
> Reading the commit message, I'm wondering whether PME_Status in the
> Root Port's Power Management Control/Status Register is set?

No.  PME Status is set in neither Root Status nor PMCSR. 

> 
> If it is, an alternative approach to quirking a set of Device IDs
> would be to auto-detect affected Root Ports, basically by using
> the logic OR of PCI_EXP_RTSTA_PME and PCI_PM_CTRL_PME_STATUS.
> 
> Sorry for not thinking about this earlier!
> 
> Otherwise I like this patch and I like how you managed to keep it
> unintrusive.

Thanks.  Can I add your Reviewed-by?


> 
> Thanks,
> 
> Lukas

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer


      reply	other threads:[~2026-11-16 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 19:31 Kuppuswamy Sathyanarayanan
2026-11-04 14:24 ` Rafael J. Wysocki (Intel)
2026-11-16 11:27 ` Lukas Wunner
2026-11-16 16:06   ` Kuppuswamy Sathyanarayanan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cb88cc0-f1f2-4c43-8a63-2698164da76b@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=helgaas@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®