From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567AbeAQQoI (ORCPT ); Wed, 17 Jan 2018 11:44:08 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36521 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbeAQQoE (ORCPT ); Wed, 17 Jan 2018 11:44:04 -0500 X-Google-Smtp-Source: ACJfBoujnHOCV1kMN/NKdy3Y9a2ca2HbgdLR6y0Hea1UEBtPw0mgNHXkarPCoABR6uv6z9qWgBQXkw== Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state To: Daniel Vetter , DRI Development Cc: LKML , Lee Jones , Jingoo Han , Daniel Vetter References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> <20180117140159.27611-2-daniel.vetter@ffwll.ch> From: Daniel Thompson Message-ID: <9cbcb5d4-1e7c-5df6-a73c-f93b1d2fdbee@linaro.org> Date: Wed, 17 Jan 2018 16:44:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180117140159.27611-2-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/18 14:01, Daniel Vetter wrote: > Nothing in the entire tree ever sets this, which means this is dead > code. Remove it. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Signed-off-by: Daniel Vetter Not sure whether to ack this one or not. There is nothing wrong with the change but having taken a closer look the driver seems like it exists mostly to allow mach-XXX code to plug in function pointers and we don't do that sort of thing any more. I think the entire driver is dead code! Daniel. > --- > drivers/video/backlight/generic_bl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 67dfb939a514..4dea91acea13 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -21,9 +21,6 @@ static int genericbl_intensity; > static struct backlight_device *generic_backlight_device; > static struct generic_bl_info *bl_machinfo; > > -/* Flag to signal when the battery is low */ > -#define GENERICBL_BATTLOW BL_CORE_DRIVER1 > - > static int genericbl_send_intensity(struct backlight_device *bd) > { > int intensity = bd->props.brightness; > @@ -34,8 +31,6 @@ static int genericbl_send_intensity(struct backlight_device *bd) > intensity = 0; > if (bd->props.state & BL_CORE_SUSPENDED) > intensity = 0; > - if (bd->props.state & GENERICBL_BATTLOW) > - intensity &= bl_machinfo->limit_mask; > > bl_machinfo->set_bl_intensity(intensity); > >