From: Devin Bayer <dev@doubly.so>
To: "Rong Zhang" <i@rong.moe>,
"Denis Benato" <denis.benato@linux.dev>,
skyedryv <skyedryv@gmail.com>,
git@turtledev.nz, "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Cc: "José Guilherme de Castro Rodrigues"
<jose.guilherme.cr.bh@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14
Date: Wed, 18 Nov 2026 10:02:32 +0100 [thread overview]
Message-ID: <9cbdb61b-9c49-4b31-a28d-022500b271a5@doubly.so> (raw)
In-Reply-To: <4c7d100f18820cba7c4fe6f6fe50c6e3324504cc.camel@rong.moe>
On 17/11/2026 14.52, Rong Zhang wrote:
>
>>>> When a device has both ASUS_WMI_DEVID_CAMERA_LED and
>>>> ASUS_WMI_DEVID_CAMERA_LED_NEG implemented, camera_neg_led_available is
>>>> false and the LED device can't benefit from brightness_hw_changed.
>>
>> Does such device even exists? Can it exists?
>
> (+CC Devin)
>
> Both macros were added together, i.e., in commit 4bf1ea3fc914
> ("platform/x86: asus-wmi: support the disable camera LED on F10 of
> Zenbook 2023") for Zenbook UX3404VC, so I assume it has both implemented.
>
> Plus, the name "_NEG" sounds like it was concluded through trial-and-
> error.
>
> I suspect that the two devids were defined for different purposes, i.e.,
> 0x00060078 for notification and 0x00060079 for query.
Hello Rong,
I can tell you what I know. I discovered the arguments from the ACPI
metadata, and found that writing to both the CAMERA and CAMERA_NEG does
the same thing, as far as I know, but NEG 1 = other 0.
They control the LED and the camera.
I don't know about query and notifications.
The hardware key doesn't do anything if it's remapped, at least in my setup.
>>>> It'd be better to decouple the brightness_hw_changed path from
>>>> !ASUS_WMI_DEVID_CAMERA_LED, since devices with both IDs should be able to
>>>> emit the WMI event.
>>>>
>>>> With that, how about adding a wrapper function that dispatches call to
>>>> either asus_wmi_get_devstate(ASUS_WMI_DEVID_CAMERA_LED) or
>>>> asus_wmi_get_devstate(ASUS_WMI_DEVID_CAMERA_LED_NEG) according to the
>>>> IDs' presence? Then you can share the same brightness_hw_changed path by
>>>> calling the wrapper function and eliminate the need of adding a dedicated
>>>> brightness_get() callback in the same manner.
>>
>> I'm not understanding this: first the discussion moves toward "what if one
>> device has both" and then you ask about reusing the code for the non-neg
>> dev id.... What am I missing here?
>
> Because I assume such devices exist. Perhaps Devin can give us some
> clues...
So it has both, I don't know which is more correct. I just documented it
for posterity.
Cheers,
Devin
next prev parent reply other threads:[~2026-11-18 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 6:35 Zane Hunt via B4 Relay
2026-10-19 8:38 ` Ilpo Järvinen
2026-10-21 1:09 ` José Guilherme de Castro Rodrigues
2026-10-21 12:34 ` Rong Zhang
2026-11-16 12:48 ` Rong Zhang
2026-11-17 1:09 ` Denis Benato
2026-11-17 13:52 ` Rong Zhang
2026-11-18 9:02 ` Devin Bayer [this message]
2026-11-15 11:55 skyedryv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cbdb61b-9c49-4b31-a28d-022500b271a5@doubly.so \
--to=dev@doubly.so \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=git@turtledev.nz \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jose.guilherme.cr.bh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skyedryv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®