From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D41EE2931CF for ; Fri, 24 Jul 2026 13:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899636; cv=none; b=cyGtDEMlCAif5YOMuQR7oXIrP+4PMag7YhYYHnxRXhmjbBDtVqUTGiUCJUaIN1EQeuHdbZldLO3oTuHaVnPjVpwRVll6bQxYAdFsY6QE/0wAWRTqWcGJn1Dfq5VSeqT1SMcFCjY6mhNuV+LqtXr33oV6QP9V7lvb9XUQ60FsKTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899636; c=relaxed/simple; bh=9i+fqpJJVodPr3EYl+cYo+mG7fXc4EP+oPdrqWlbX8E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pDUsFikrpzy8/+hcMvcyANfwWDQwqOmvggNB8+g1N8Q6naWKtr+9uThALGF0/c2f+ZYqUpZgCCHt2ofTwq/nQhuq/Qm1ejkaG4ULCLwnQWGcWTQSRRqDXgAeMKXGdvCh8XIWDYffnbKKBOUvbhUkGq6pQotSgs+7xNmVx8Ss6GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sQTcPyJZ; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sQTcPyJZ" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5b2960ea2fbso58002e87.3 for ; Fri, 24 Jul 2026 06:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784899628; x=1785504428; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=TvKKWFw0cmhK0wjKFGEdx7eH0kIrLjjTxehxj0zrAa8=; b=sQTcPyJZwPD2KC18ixabThZaiaLHQ3q4fWxzieMd7o1CVkDykj3txAb85EfelQC8mn aP8OKQONnCTtiELJCB6+RK+CjJpRxV4w/4igMWcj4eU9ZVM0oD3WDeEu4vM7DhRRD+ho tfx2l+BLNrUae7u2Tp1bcieoKO7IvS37dIs9MhaiLAX+KVnKGF74DeamtRYBDbPq05BJ 0ABUjPlN2ahk1Sfzuk5SUS5Th2dZ8uoIISZZgi2wKO/b0C0RrlH3/aWLRzaCbdnGlfg9 Hv6c2rsHdQZIJlgPaPr3NyMHmd8wsTDUtei4Z+Rwqp/sPH+Mvqxq2sfxUuOrjHoDY+va J9pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784899628; x=1785504428; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TvKKWFw0cmhK0wjKFGEdx7eH0kIrLjjTxehxj0zrAa8=; b=rr0XAxIVij47FM7MzO0o0inTXLj/J0LP1TRSJWN38ag6GtKcMUUPGomb5Y/8WrdHaG N+fPyyv5NUCd6zCJk/BnhtuBlc0AFOH+Z86w+6Uxsh+FkK2XHAtBPAuutEHh44TEhZBU zcMg9ZVorB/b1XQeaydb7EIRIaP7E0uaO5xyyrsCmry8mFyPcxflrQW3+c+CHXJiAeDu 1wU0jGHmnDWWHlGF2i7mUKrbpOI2Ww1xA64dBiyRjvcVBy0h5n7lCrfxIwN3Krh3CoaL WVO/Fsid46ZoBMoRFH0yWK1jCspTwp8w6BnBAxzKGcIUZekBxdo3KNnT5l4qQMueTwL2 yqUA== X-Forwarded-Encrypted: i=1; AHgh+RrGGx/esIqckJJSPHIDjTSlK8RVWy6n8K5foH1JpmmC3p1dXBJpjfFZhINkdLD2hvgNAvGCjquS+EkLWnI=@vger.kernel.org X-Gm-Message-State: AOJu0YzXm7K9zqBg56UXYSPpnokPUFn/ttdJZcGuHzJZDcsVYQ1HA2W1 Kw3a7IY4o+5HJ5LC0jDJ/usfZy6OGYBxCW93DSPrbZZjNoyLMioi4rgf0YCRRPyVDFUxgCDtLJH 1EifxRC8= X-Gm-Gg: AR+sD13tTFhtvCbmvnwVBBBxRfjn3BACCL9n+8AHVA/vNuzfdxvMNhIITCr8LgRnSWr KwVyi/aoZNK2/A+CsunOJ2zw0gKENlU0RU8IrBXTFfLZH8QBl+RNmQtoR+tWumBXYQ1ABZQlIbA nZVu1I4IPOapwp809ECyyWUYz0mDKWuibgCdnqtAuNUHqDPgZzPFqVGKYLq2EXL31Xju1HGMubV dVWMMQl1M1hqBXWFbqRsnFBMiAMdyT79HCueSGCddWQmy0R02r0oKNWyxX5L9X57pThRL4/0P5o HwQo2QlBtR4SI1amPbWwDGsdh2N26cdvTx+Lr45/qZXVcD2Tw3LTV1IGug+7cxplLvzuknYm6MZ 0lL9hnvJx1li/p/f4w4gE7BPRtu58D3BymMM+dFlMy/5mrwLKVXG/vLEhk4KojlB1RFgg+mPyrA AyMTsOL1QD0Q7aV0mRdmPw5zJmc7kxVu8323okAedAvk3lI3bdY+NzwrrN8oqYOg962v4= X-Received: by 2002:a05:6512:1256:b0:5b0:6aea:cdb5 with SMTP id 2adb3069b0e04-5b2b7ad323amr492116e87.1.1784899628054; Fri, 24 Jul 2026 06:27:08 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9b8c6f6sm1562311e87.4.2026.07.24.06.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 06:27:07 -0700 (PDT) Message-ID: <9cc2e087-ccc5-4121-83b6-c744cf944aa1@linaro.org> Date: Fri, 24 Jul 2026 16:27:07 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/17] media: i2c: os05b10: Add H/V flip support To: Tarang Raval , sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com Cc: Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718200912.16001-1-tarang.raval@siliconsignals.io> <20260718200912.16001-7-tarang.raval@siliconsignals.io> From: Vladimir Zapolskiy In-Reply-To: <20260718200912.16001-7-tarang.raval@siliconsignals.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 23:08, Tarang Raval wrote: > Add HFLIP and VFLIP controls, lock them while streaming, > and update the reported Bayer format based on the flip state. > > Signed-off-by: Tarang Raval > --- > drivers/media/i2c/os05b10.c | 56 ++++++++++++++++++++++++++++++++++--- > 1 file changed, 52 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c > index abf3d2970900..61c51844a91e 100644 > --- a/drivers/media/i2c/os05b10.c > +++ b/drivers/media/i2c/os05b10.c > @@ -96,6 +96,10 @@ > #define OS05B10_MIRROR BIT(3) > #define OS05B10_FLIP GENMASK(5, 4) > > +#define OS05B10_REG_ANALOG_FLIP CCI_REG8(0x3716) > +#define OS05B10_FLIP_ENABLE 0x04 > +#define OS05B10_FLIP_DISABLE 0x24 > + > #define OS05B10_REG_FORMAT2 CCI_REG8(0x3821) > > #define OS05B10_LINK_FREQ_600MHZ (600 * HZ_PER_MHZ) > @@ -231,7 +235,6 @@ static const struct cci_reg_sequence os05b10_common_regs[] = { > { CCI_REG8(0x370f), 0x1c }, > { CCI_REG8(0x3710), 0x00 }, > { CCI_REG8(0x3713), 0x00 }, > - { CCI_REG8(0x3716), 0x24 }, > { CCI_REG8(0x371a), 0x1e }, > { CCI_REG8(0x3724), 0x09 }, > { CCI_REG8(0x3725), 0xb2 }, > @@ -465,6 +468,8 @@ struct os05b10 { > struct v4l2_ctrl *vblank; > struct v4l2_ctrl *gain; > struct v4l2_ctrl *exposure; > + struct v4l2_ctrl *vflip; > + struct v4l2_ctrl *hflip; > > u32 link_freq_index; > u32 data_lanes; > @@ -513,6 +518,16 @@ static inline struct os05b10 *to_os05b10(struct v4l2_subdev *sd) > return container_of_const(sd, struct os05b10, sd); > }; > > +static u32 os05b10_get_format_code(struct os05b10 *os05b10) > +{ > + static const u32 codes[2][2] = { > + { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10, }, > + { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10, }, > + }; > + > + return codes[os05b10->vflip->val][os05b10->hflip->val]; > +} > + > static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) > { > struct os05b10 *os05b10 = container_of_const(ctrl->handler, > @@ -556,6 +571,20 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) > ret = cci_write(os05b10->cci, OS05B10_REG_EXPOSURE, > ctrl->val, NULL); > break; > + case V4L2_CID_HFLIP: > + case V4L2_CID_VFLIP: > + ret = cci_update_bits(os05b10->cci, OS05B10_REG_FORMAT1, > + OS05B10_MIRROR | OS05B10_FLIP, > + (!os05b10->hflip->val ? > + OS05B10_MIRROR : 0) | > + (os05b10->vflip->val ? > + OS05B10_FLIP : 0), NULL); > + > + ret |= cci_write(os05b10->cci, OS05B10_REG_ANALOG_FLIP, > + (os05b10->vflip->val == 1) ? > + OS05B10_FLIP_ENABLE : OS05B10_FLIP_DISABLE, > + NULL); Above please follow the review comment given by Mehdi. It's expected to see cci_update_bits(<...>, &ret); cci_write(<...>, &ret); > + break; > default: > ret = -EINVAL; > break; > @@ -570,10 +599,12 @@ static int os05b10_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > { > + struct os05b10 *os05b10 = to_os05b10(sd); > + > if (code->index >= ARRAY_SIZE(os05b10_mbus_codes)) > return -EINVAL; > > - code->code = os05b10_mbus_codes[code->index]; > + code->code = os05b10_get_format_code(os05b10); > > return 0; > } > @@ -712,6 +743,9 @@ static int os05b10_enable_streams(struct v4l2_subdev *sd, > if (ret) > goto err_rpm_put; > > + __v4l2_ctrl_grab(os05b10->vflip, true); > + __v4l2_ctrl_grab(os05b10->hflip, true); > + > return 0; > > err_rpm_put: > @@ -732,6 +766,9 @@ static int os05b10_disable_streams(struct v4l2_subdev *sd, > if (ret) > dev_err(os05b10->dev, "failed to set stream off\n"); > > + __v4l2_ctrl_grab(os05b10->vflip, false); > + __v4l2_ctrl_grab(os05b10->hflip, false); > + > pm_runtime_put(os05b10->dev); > > return 0; > @@ -740,6 +777,7 @@ static int os05b10_disable_streams(struct v4l2_subdev *sd, > static int os05b10_init_state(struct v4l2_subdev *sd, > struct v4l2_subdev_state *state) > { > + struct os05b10 *os05b10 = to_os05b10(sd); > struct v4l2_mbus_framefmt *format; > const struct os05b10_mode *mode; > > @@ -747,7 +785,7 @@ static int os05b10_init_state(struct v4l2_subdev *sd, > format = v4l2_subdev_state_get_format(state, 0); > > mode = &supported_modes_10bit[0]; > - format->code = MEDIA_BUS_FMT_SBGGR10_1X10; > + format->code = os05b10_get_format_code(os05b10); > > /* Update image pad formate */ > format->width = mode->width; > @@ -928,7 +966,7 @@ static int os05b10_init_controls(struct os05b10 *os05b10) > int ret; > > ctrl_hdlr = &os05b10->handler; > - v4l2_ctrl_handler_init(ctrl_hdlr, 9); > + v4l2_ctrl_handler_init(ctrl_hdlr, 11); > > pixel_rate = os05b10_pixel_rate(os05b10, mode); > v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, > @@ -974,6 +1012,16 @@ static int os05b10_init_controls(struct os05b10 *os05b10) > OS05B10_DIGITAL_GAIN_MIN, OS05B10_DIGITAL_GAIN_MAX, > OS05B10_DIGITAL_GAIN_STEP, OS05B10_DIGITAL_GAIN_DEFAULT); > > + os05b10->hflip = v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, > + V4L2_CID_HFLIP, 0, 1, 1, 0); > + if (os05b10->hflip) > + os05b10->hflip->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT; > + > + os05b10->vflip = v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, > + V4L2_CID_VFLIP, 0, 1, 1, 0); > + if (os05b10->vflip) > + os05b10->vflip->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT; > + As a micro optimization againt the error path, setting of these flags can be done at the end of the function, for instance check how it's done in ov2680.c > if (ctrl_hdlr->error) { > ret = ctrl_hdlr->error; > dev_err(os05b10->dev, "control init failed (%d)\n", ret); -- Best wishes, Vladimir