From: Andrew Lunn <andrew@lunn.ch>
To: Rengarajan.S@microchip.com
Cc: Bryan.Whitehead@microchip.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, richardcochran@gmail.com, edumazet@google.com,
UNGLinuxDriver@microchip.com, kuba@kernel.org
Subject: Re: [PATCH net-next v1] net: microchip: lan743x: Reduce PTP timeout on HW failure
Date: Wed, 8 May 2024 13:57:12 +0200 [thread overview]
Message-ID: <9cc733b9-005d-4587-bc08-971f39334663@lunn.ch> (raw)
In-Reply-To: <5ee0e9beb684dcf0b19b5c0698deea033cfff588.camel@microchip.com>
> Hi Andrew, based on the customer experience they felt that there might
> be cases where the 20-sec delay can cause the issue(reporting the HW to
> be dead). For boards with defects/failure on few occasions it was found
> that resetting the chip can lead to successful resolution; however,
> since we need to wait for 20 sec for chip reset, we found that reducing
> the timeout to 1 sec would be optimal.
O.K. This should of been part of the commit message, since with this
comment the change becomes meaningful. Please try to ensure the commit
message explains "Why?"
Andrew
prev parent reply other threads:[~2024-05-08 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 5:03 Rengarajan S
2024-05-04 8:52 ` Simon Horman
2024-05-06 10:00 ` patchwork-bot+netdevbpf
2024-05-07 1:33 ` Andrew Lunn
2024-05-08 8:52 ` Rengarajan.S
2024-05-08 11:57 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc733b9-005d-4587-bc08-971f39334663@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=Rengarajan.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®