From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFD5C433F5 for ; Tue, 14 Sep 2021 05:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9498860F21 for ; Tue, 14 Sep 2021 05:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239425AbhINFRa (ORCPT ); Tue, 14 Sep 2021 01:17:30 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:44741 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239328AbhINFR3 (ORCPT ); Tue, 14 Sep 2021 01:17:29 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id D640258056A; Tue, 14 Sep 2021 01:16:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 14 Sep 2021 01:16:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=i Fscvg2UAmpuVVdpXjvJG379QTvu2lO6GFxJggs3RVE=; b=I05XragjQlJMB7LRR 5CizImRNGMqqoIFF8kK/pmXDYPh3Nu+iXAat2zToipMPQQLNmFGc/JNjQuGMbALw H/8/f+sPhhxtgqwjaMkpHRNnlfWFKT6C7P88PAfCIWE3Xh9LiX8I/y0WIJMkiGfK /K1Ek5IWGPhvKDhTqeqaz/A9OcLk6iODRRytF1x0sLNdGxgQU+TOH2Q8hXSGD6Rj rri81ebspvSmStei2FjqNIOMA3+NWMisL0eG3UqihmFcLtJwsBNnK8vjlTF+csuB Q0XcIiLvSkuLJq4ESznaeK/3LWVG3aAcY4dsZkTJcibkWSKOWSVaT/Juq7cSK7SB NEz7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=iFscvg2UAmpuVVdpXjvJG379QTvu2lO6GFxJggs3R VE=; b=W6gik0BPSPSkR6ki9N4KEg7nH4fCeP5Cna/Ow1NeHjRTCULEzNBiUIIpI poYDa2jLaTExav3o+BmUqt0L48ulTLkaqJ0gScgxp5zIyldce4KEyNW0uzdyKoJP CbukXRVFbY2zJyIj/8Y3xBFBDDtBR2lNizglfzubpoQS8vGJEsxwVuCSN+ER082x wKhLiGh6TEoU6EACkYAXuFgkLHQcEbvwZCNEZnckQg5GerCEnd5RJGgcrkf+Qbsx l4c/i5ClieyGZy4P8kh/+R2XfzUN745tRpUVInQ+6oizDlgqYxFF7FIy6T0QVEBd lZVnaZrHtAKOKWAfdSdhRn9gT3hcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegkedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefheenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepieegffeuieeuleevvdelhefgudefffdufeetiedvffefgeehfeek teelffduffeunecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Sep 2021 01:16:07 -0400 (EDT) To: Heinrich Schuchardt , guoren@kernel.org, Liu Shaohua , wefu@redhat.com Cc: anup.patel@wdc.com, atish.patra@wdc.com, palmerdabbelt@google.com, christoph.muellner@vrull.eu, philipp.tomsich@vrull.eu, hch@lst.de, lazyparser@gmail.com, drew@beagleboard.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, taiten.peng@canonical.com, aniket.ponkshe@canonical.com, gordan.markus@canonical.com, Guo Ren , Chen-Yu Tsai , Maxime Ripard References: <20210911092139.79607-1-guoren@kernel.org> <20210911092139.79607-7-guoren@kernel.org> <20210913084520.kkbsupogkzv226x3@gilmour> From: Samuel Holland Subject: Re: [RFC PATCH V4 6/6] riscv: soc: Add Allwinner SoC kconfig option Message-ID: <9cd8db15-7431-dfec-6e48-dcf6b30d4f6c@sholland.org> Date: Tue, 14 Sep 2021 00:16:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/21 10:49 PM, Heinrich Schuchardt wrote: > Calling a Kconfig menu item "Allwinner SoCs" which includes all > future Allwinner SoCs irritates me. How about CONFIG_SOC_SUNXI_D1 > instead? Would you want to have a separate option for each new SoC? That seems like the only way to split things up, if you want to be more specific than than "sunxi" (or equivalently "sun20i", which is the codename for the RISC-V series). Except at the very beginning (sun4i-sun7i), there have not been clear generational boundaries between the various sunxi SoCs, so most of the 32-bit ones already get lumped into a single symbol (MACH_SUN8I). And there is a single Kconfig symbol, ARCH_SUNXI, for all 64-bit Allwinner SoCs. There is enough overlap in peripherals that you need a common symbol for the peripheral drivers anyway. How about... ARCH_SUNXI? There are 90+ uses of this symbol throughout drivers/ and sound/, and I have found that more than half of them apply to the D1 (see e.g. this commit[1] and some of its ancestors). RISC-V has so far adopted a CONFIG_SOC_xxx naming scheme, which is different from arm/arm64's CONFIG_ARCH_xxx pattern. But now we have a case where a SoC family is split between the two architectures. I'm all for consistency with the names of other RISC-V platform symbols, but it seems that reusing the existing ARCH_SUNXI symbol would be better than cluttering up the driver Kconfig files with a duplicate. Regards, Samuel [1]: https://github.com/smaeul/linux/commit/7841e5c32366