From: Yunsheng Lin <linyunsheng@huawei.com>
To: Eric Dumazet <edumazet@google.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ipvlan: minor optimization for ipvlan outbound process
Date: Wed, 2 Nov 2022 11:47:42 +0800 [thread overview]
Message-ID: <9cdb2fff-9eee-564d-f8df-38ff7125dad2@huawei.com> (raw)
In-Reply-To: <CANn89iJWyLQDHHJXNHb78zpX=At1oyqPaUmeQ5-GuzX2YOxGDQ@mail.gmail.com>
On 2022/11/2 11:23, Eric Dumazet wrote:
> On Tue, Nov 1, 2022 at 7:15 PM Yunsheng Lin <linyunsheng@huawei.com> wrote:
>>
>> Avoid some local variable initialization and remove some
>> redundant assignment in ipvlan outbound process.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>
> Really I do not see the point of such a patch, making future backports
> more difficult.
As the ipvlan outbound process is in the fast path, avoiding the
unnecessary steps might be worth the backport cost.
Anyway, it is more of judgment call, not a rule, right?
>
> Changing old code like that should only be done if this is really necessary,
> for instance before adding a new functionality.
> .
>
next prev parent reply other threads:[~2022-11-02 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 2:15 Yunsheng Lin
2022-11-02 3:23 ` Eric Dumazet
2022-11-02 3:47 ` Yunsheng Lin [this message]
2022-11-02 4:06 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdb2fff-9eee-564d-f8df-38ff7125dad2@huawei.com \
--to=linyunsheng@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®