From: Ding Tianhong <dingtianhong@huawei.com>
To: <akpm@linux-foundation.org>, <aryabinin@virtuozzo.co>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LinuxArm <linuxarm@huawei.com>
Subject: [PATCH] ubsan: don't handle misaligned address when support unaligned access
Date: Fri, 1 Dec 2017 19:32:08 +0800 [thread overview]
Message-ID: <9cdc75c4-326f-5adb-b32c-c95e1f3211ce@huawei.com> (raw)
The ubsan always report Warning just like:
UBSAN: Undefined behaviour in ../include/linux/etherdevice.h:386:9
load of misaligned address ffffffc069ba0482 for type 'long unsigned int'
which requires 8 byte alignment
CPU: 0 PID: 901 Comm: sshd Not tainted 4.xx+ #1
Hardware name: linux,dummy-virt (DT)
Call trace:
[<ffffffc000093600>] dump_backtrace+0x0/0x348
[<ffffffc000093968>] show_stack+0x20/0x30
[<ffffffc001651664>] dump_stack+0x144/0x1b4
[<ffffffc0016519b0>] ubsan_epilogue+0x18/0x74
[<ffffffc001651bac>] __ubsan_handle_type_mismatch+0x1a0/0x25c
[<ffffffc00125d8a0>] dev_gro_receive+0x17d8/0x1830
[<ffffffc00125d928>] napi_gro_receive+0x30/0x158
[<ffffffc000f4f93c>] virtnet_receive+0xad4/0x1fa8
The reason is that when enable the CONFIG_UBSAN_ALIGNMENT, the ubsan
will report the unaligned access even if the system support it
(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y), it will produce a lot
of noise in the log and cause confusion.
This patch will close the detection of unaligned access when
the system support unaligned access.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
lib/ubsan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/ubsan.c b/lib/ubsan.c
index fb0409d..278b4c3 100644
--- a/lib/ubsan.c
+++ b/lib/ubsan.c
@@ -321,7 +321,8 @@ void __ubsan_handle_type_mismatch(struct type_mismatch_data *data,
if (!ptr)
handle_null_ptr_deref(data);
- else if (data->alignment && !IS_ALIGNED(ptr, data->alignment))
+ else if (data->alignment && !IS_ALIGNED(ptr, data->alignment) &&
+ !IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
handle_missaligned_access(data, ptr);
else
handle_object_size_mismatch(data, ptr);
--
1.8.3.1
next reply other threads:[~2017-12-01 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 11:32 Ding Tianhong [this message]
2017-12-01 11:47 ` David Laight
2017-12-01 12:37 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdc75c4-326f-5adb-b32c-c95e1f3211ce@huawei.com \
--to=dingtianhong@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.co \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®