From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Oded Gabbay <ogabbay@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Arnd Bergmann <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Jiho Chu <jiho.chu@samsung.com>,
Daniel Stone <daniel@fooishbar.org>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Hilman <khilman@baylibre.com>,
Jagan Teki <jagan@amarulasolutions.com>,
John Hubbard <jhubbard@nvidia.com>,
Alex Deucher <alexander.deucher@amd.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
Christopher Friedt <chrisfriedt@gmail.com>
Subject: Re: [PATCH v4 2/4] accel: add dedicated minor for accelerator devices
Date: Sun, 20 Nov 2022 14:47:14 -0700 [thread overview]
Message-ID: <9ce1bf9f-a481-92e3-c7cc-a1b41270468d@quicinc.com> (raw)
In-Reply-To: <20221119204435.97113-3-ogabbay@kernel.org>
On 11/19/2022 1:44 PM, Oded Gabbay wrote:
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index fac6ad6ac28e..703d40c4ff45 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -8,14 +8,25 @@
>
> #include <linux/debugfs.h>
> #include <linux/device.h>
> +#include <linux/xarray.h>
Including xarray, but using idr
This should be linux/idr.h
This seems so minor, I don't think I advise spinning a v5 for it. If a
v5 is warranted elsewhere, obviously fix this. If not, hopefully this
can be fixed up by whoever applies it, or someone submits a follow up patch.
Hopefully this is the only nit. I would like to see this merged.
-Jeff
next prev parent reply other threads:[~2022-11-20 21:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 20:44 [PATCH v4 0/4] new subsystem for compute " Oded Gabbay
2022-11-19 20:44 ` [PATCH v4 1/4] drivers/accel: define kconfig and register a new major Oded Gabbay
2022-11-19 20:44 ` [PATCH v4 2/4] accel: add dedicated minor for accelerator devices Oded Gabbay
2022-11-20 21:47 ` Jeffrey Hugo [this message]
2022-11-21 15:11 ` Oded Gabbay
2022-11-19 20:44 ` [PATCH v4 3/4] drm: initialize accel framework Oded Gabbay
2022-11-22 10:55 ` Melissa Wen
2022-11-22 10:59 ` Oded Gabbay
2022-11-22 11:02 ` Oded Gabbay
2022-11-22 11:11 ` Melissa Wen
2022-11-19 20:44 ` [PATCH v4 4/4] doc: add documentation for accel subsystem Oded Gabbay
2022-11-20 22:01 ` Jeffrey Hugo
2022-11-21 15:18 ` Oded Gabbay
2022-11-21 15:26 ` Jeffrey Hugo
2022-11-20 15:26 ` [PATCH v4 0/4] new subsystem for compute accelerator devices Greg Kroah-Hartman
2022-11-20 22:04 ` Jeffrey Hugo
2022-11-22 15:57 ` Jeffrey Hugo
2022-11-21 6:25 ` Dave Airlie
2022-11-21 15:11 ` Oded Gabbay
2022-11-21 15:08 ` Thomas Zimmermann
2022-11-21 15:57 ` Alex Deucher
2022-11-21 15:58 ` Alex Deucher
2022-11-21 23:06 ` Sonal Santan
2022-11-22 5:46 ` Dave Airlie
2022-11-22 14:54 ` Daniel Vetter
2022-11-23 14:02 ` Sonal Santan
2022-11-22 10:17 ` Jacek Lawrynowicz
2022-11-23 12:27 ` Maxime Ripard
2022-11-24 18:34 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce1bf9f-a481-92e3-c7cc-a1b41270468d@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=chrisfriedt@gmail.com \
--cc=daniel@ffwll.ch \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jagan@amarulasolutions.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jiho.chu@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®