From: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: bod@kernel.org, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 3/4] media: qcom: iris: increase H265D_MAX_SLICE to fix H.265 decoding on SC7280
Date: Tue, 26 May 2026 18:12:53 +0530 [thread overview]
Message-ID: <9ce2ceda-580c-4c58-b3e0-8d497876b7e5@oss.qualcomm.com> (raw)
In-Reply-To: <177979911665.6300.11726562589723045774.b4-reply@b4>
On 5/26/2026 6:08 PM, bod@kernel.org wrote:
> On 2026-03-27 22:19 +0200, Dmitry Baryshkov wrote:
>> Follow the commit bfe1326573ff ("venus: Fix for H265 decoding failure.")
>> and increase H265D_MAX_SLICE following firmware requirements on that
>> platform. Otherwise decoding of the H.265 streams fails withthe
>> "insufficient scratch_1 buffer size" from the firmware.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>> drivers/media/platform/qcom/iris/iris_vpu_buffer.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.h b/drivers/media/platform/qcom/iris/iris_vpu_buffer.h
>> index 12640eb5ed8c..8c0d6b7b5de8 100644
>> --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.h
>> +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.h
>> @@ -67,7 +67,7 @@ struct iris_inst;
>> #define SIZE_DOLBY_RPU_METADATA (41 * 1024)
>> #define H264_CABAC_HDR_RATIO_HD_TOT 1
>> #define H264_CABAC_RES_RATIO_HD_TOT 3
>> -#define H265D_MAX_SLICE 1200
>> +#define H265D_MAX_SLICE 3600
>> #define SIZE_H265D_HW_PIC_T SIZE_H264D_HW_PIC_T
>> #define H265_CABAC_HDR_RATIO_HD_TOT 2
>> #define H265_CABAC_RES_RATIO_HD_TOT 2
>>
>> --
>> 2.47.3
>>
>>
>
> This seems fine to me. Vikash, Dikshita, happy enough ?
This is good from my side.
Sorry, if i forgot to add on this one, adding now,
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> ---
> bod
>
next prev parent reply other threads:[~2026-05-26 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <sYZHD3u8jIct2FxvEcwr_2zJAwlRZlgApp_nZRHcBHzhnTYkersBivmgF9agXwr_MAMQq9aXHnEfhYlOs_B6qw==@protonmail.internalid>
2026-03-27 20:19 ` [PATCH v5 0/4] media: qcom: flip the switch between Venus and Iris drivers Dmitry Baryshkov
2026-03-27 20:19 ` [PATCH v5 1/4] media: dt-bindings: qcom,sc7280-venus: drop non-PAS support Dmitry Baryshkov
2026-03-27 20:19 ` [PATCH v5 2/4] media: dt-bindings: qcom-sc7180-venus: move video-firmware here Dmitry Baryshkov
2026-03-27 20:19 ` [PATCH v5 3/4] media: qcom: iris: increase H265D_MAX_SLICE to fix H.265 decoding on SC7280 Dmitry Baryshkov
2026-05-26 12:38 ` bod
2026-05-26 12:42 ` Vikash Garodia [this message]
2026-03-27 20:19 ` [PATCH v5 4/4] media: qcom: venus: flip the venus/iris switch Dmitry Baryshkov
2026-05-26 12:49 ` [PATCH v5 0/4] media: qcom: flip the switch between Venus and Iris drivers Bryan O'Donoghue
2026-05-26 13:43 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce2ceda-580c-4c58-b3e0-8d497876b7e5@oss.qualcomm.com \
--to=vikash.garodia@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®