From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0C3F275864 for ; Mon, 17 Nov 2025 17:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400512; cv=none; b=YtvRO9AC5yFlmYYbLL8d2Xo9wTPeCCrbtszC5b9aH5GW9otlL9W12enIlwI6V+6H9pn34R/jjfhD/P6WQI36dFhcFETDbDKkqLeIF83sfedyw1AM9Tk8SGGO0ms8baWz3iPjo88GRE7KwbZOC8RGLu0+quiat7fASpd08eTvUMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400512; c=relaxed/simple; bh=yTtk2iSEXD2ucllMMaxke8XcWJDG7kCgtIWljaWRpgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=edF9c6DovOzx2/c7ALvs5BXxn84+ysbEQSgz7AOy16A80JSlh2isG6VN/sTB2bhM5jXbua+2CIkXgGM89UgqNmSZ/9j2mNTuslLFt754gjp5a4lWgEQnJjSyeu0waZKvPBuvYF27uj4dTw+jF48ymlUOYfXSxG+BZFAdfz0PeF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KoSL3wvr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KoSL3wvr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D15CC116B1; Mon, 17 Nov 2025 17:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763400511; bh=yTtk2iSEXD2ucllMMaxke8XcWJDG7kCgtIWljaWRpgE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KoSL3wvrCdkTnmL1+F0GOj+NIx7/jIgyXZK/PV+sB4FXEfLhWmR49GRyNJLj3O/NZ +Rlaqr1DHz0VWxQG0xiYY3+WYX8JaeSLJb7bsrQf7lUrPUfH5FVNDs1D/rKyR+JMGK vAm92O5TEuYF3ctNGmfu5THdi9lYWlsFJtLcTydu+wmfXwUFNZnVN7YY0EKCB8CZ9X EG99vaxYXaVQROD1FluZbKMALV6wJvuKQUNdQ7o6xvqjfRsv6tHNVQdE/a+SRZGejQ lVDdP1jenru0kHwv/8fTE08B3mvRlUVwRcaPjpGk8zQLXUEpkvWuktViLqEJsCLSWE d3uyEQmkjiBLQ== Message-ID: <9ce40155-2731-4dec-8c18-e27f13bf1872@kernel.org> Date: Mon, 17 Nov 2025 18:28:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves() To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <1456ba4c025e9ea01abcadb8c3714c7ef84e0198.1762464515.git.luizcap@redhat.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <1456ba4c025e9ea01abcadb8c3714c7ef84e0198.1762464515.git.luizcap@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.11.25 22:28, Luiz Capitulino wrote: > dav_align_valid() uses has_transparent_hugepage() to check if PMD-sized > pages are supported, use pgtable_has_pmd_leaves() instead. > > Signed-off-by: Luiz Capitulino > --- > drivers/dax/dax-private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h > index 0867115aeef2..10aeaec9e789 100644 > --- a/drivers/dax/dax-private.h > +++ b/drivers/dax/dax-private.h > @@ -117,7 +117,7 @@ static inline bool dax_align_valid(unsigned long align) > { > if (align == PUD_SIZE && IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD)) As discussed offlist, it would be great to later also have this be if (align == PUD_SIZE && pgtable_has_pud_leaves() Acked-by: David Hildenbrand (Red Hat) -- Cheers David