mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Junwen Wu <wudaemon@163.com>,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com
Cc: mgorman@suse.de, vschneid@redhat.com,
	linux-kernel@vger.kernel.org, laoar.shao@gmail.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com
Subject: Re: [PATCH v5] sched/stats: Fix rt/dl task's sched latency statistics error in sched_stat_wait tracepoint
Date: Fri, 12 Jan 2024 08:39:19 +0100	[thread overview]
Message-ID: <9ce7c466-ce9d-4673-b89a-d3244226dbde@redhat.com> (raw)
In-Reply-To: <20240111150147.182937-1-wudaemon@163.com>

On 1/11/24 16:01, Junwen Wu wrote:
> The sched_stat_wait tracepoint is showing unreasonably long
> latencies for real-time tasks. For example:
> 
> sched_stat_wait: comm=rcu_preempt pid=14 delay=4936139545261 [ns]
> 
> This error happens when the rt task balances off the source CPU because
> the dequeue operation is not updating the sched_statistics. So, follow
> update_stats_wait_end_fair() and update the stats. Do the same for
> SCHED_DEADLINE.
> 
> Fixes: 57a5c2dafca8 ("sched/rt: Support schedstats for RT sched class")
> Fixes: b5eb4a5f6521 ("sched/dl: Support schedstats for deadline sched class")

Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>

Thanks
-- Daniel


  reply	other threads:[~2024-01-12  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 15:01 Junwen Wu
2024-01-12  7:39 ` Daniel Bristot de Oliveira [this message]
2024-02-25  2:10   ` Junwen Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ce7c466-ce9d-4673-b89a-d3244226dbde@redhat.com \
    --to=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wudaemon@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®