From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2FF2C0323 for ; Tue, 6 Jan 2026 14:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710639; cv=none; b=ZtYrCIr/ANvq26v2OILgEmYw2tYJKKJ4nGuIcFR4Ejz/GXjxnBBz6RKk+3betd9DS5/HCR8VADL5Q87+Epa7S7/QUbev3i/sgum2LECxqTV6UaG6K8+gq08uP6ZzIISyT58E1+6vqWBcu/iEyw4BwUz60VA30poea4BDuQSid5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710639; c=relaxed/simple; bh=lgMKRFdh5v9iRb/pm3a055Mp9ATD38LF+MvykHbBixc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AxVit4HweMYIuyG+89B4lETyzltQcVSvhgnkcjKY0vzbIYwQy4yfgYruwsdagPcXXpGspkVrS1CUkSYyF6Nbxtf58JXPRVXd8TrJlPBnt0pizb70qZkcoeXZ4RDGu47PQYFgTull2aKDOD0qEYCpJAsDrAret6zgXvux6B+JGSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=IPrevUTE; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="IPrevUTE" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8b2d32b9777so129696585a.2 for ; Tue, 06 Jan 2026 06:43:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1767710635; x=1768315435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yjnd3cJi73pItwYWnZ/AGVro8SITV6ewWmgFqzGpdOc=; b=IPrevUTEPRsOZW6vSN66tVtbTQWZf8soBWefuU+HTkefSYRcJoSmjiz5ZgIdmf/H9e hh+p63r0/MuJagfsELcEoYBMmSFB6DrX7qs1piS/KeqNBrbmkTmfmwBRt6A+B/K/qDub 36cbQfzpGkWBwm+jRqCL1ZOl8euf9fT3qMNAnAyXzrbvrBFcih4wN+bvOUBMrrjp09Sz U+nJ/LdAewnGYhYnhDFJE0ZZVIqfjezlMpQu89/85g741BbBkezReWvehtWHXpeZDbMS 05uq67WtQaL2f4Q83so4tIZHXtAGh6FZ63ggh8SGVFA5fFeGzQRdkuRAUAwULZSw0sW5 WS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767710635; x=1768315435; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yjnd3cJi73pItwYWnZ/AGVro8SITV6ewWmgFqzGpdOc=; b=rdfmUi4F/JDV8Yq4zqTCgkfcdu09P0r2YoXbAphQbhpkofI7O9NPt1XO/Ijw+M3IyH jBSDLUGkJGonnCZm+6Ll0V1lq+FKiqrZFyCMd6lcEIKl5JEYIWJaGIFYTlGpCn2wX1bm 9L5xZhspe8plF5xmzoIa808Y0WZird16LkHWXrbCVwqT98fXMTFxwtsmLAqL8z4ahCJF 24tFIU81RxVMzlFywD2oZkJ2VDw6g/dFYZOrdXebGUdfZOn5Ab+4R4q79d6FyBFke0WF g+zxXBp79Cd43IX/lOJZAMphJSHoUSSqRcvZPRNK7k0A7Ov8aO8fqizAsFr6SBBba9dj KiTA== X-Forwarded-Encrypted: i=1; AJvYcCX+mWImWNZ1dFPDmMPMa9d4E3RzOH4RHXs9sVcwLWy9XGzARxVGVzNbxz4ETdu9NZozQ8BvnbIeVDxByxs=@vger.kernel.org X-Gm-Message-State: AOJu0YzZXypl1DqUqkqpS1VD4+uIpcONxaAW847uNvViMP34nSQH/ahr rrb8IcnfcyFjdXp6vj2Rinf669p4MfuCaydpBJv7sMsoqcHH8B07Mohq+BQsqlWSe0o= X-Gm-Gg: AY/fxX7LsfELTsXvj2mpPykMF1y2+nD1LdX59WMw+GPJirIStupH+RIfS5tVvUH5GG4 7ZMTMBPWwwKvk/qE9zq7bSPY7vNyLnMqrkcxWVzgKJXmw9oN4UHGkdS86xHcDewpJm1JddN7LPP oUDtyhI433HFydWwJmT9oFeI2AwXsrVxyiEL3lvMNXp8zplOogGN9qoj+6fr9mOxkP/sgoqyts0 FQSVOY47uJyA6DyrG+F4lZiG2Bkj0Ks1Bri6jyA+vy641ywRFF9wGvDq22L7weVFwus7rY89Kh1 C8PpoFDYO8sbRsNsju1/K54kRmXJ2sclyBIzgoLUY/eEgArs3lrIq/kKgxt5d524aeCAYellpJr En+O5qNXKYUhiZQeNtL78Mn4l49rSCLEHDLn7p+HUTVQKbKZKcEAgSa1uFxj/r8rbTyp2M1PR+t k50fa4mFkHE/LEPi45g9iCHBwyhxq9SMYjYhJ9JqOS8Ds//DyGLqM= X-Google-Smtp-Source: AGHT+IEt3VwJP5rxykKJZ4q+39Q3RxlylF53FJBHrqUXpOK98r/RkrMmPUkkduDxAmcDVa9qHWO1bA== X-Received: by 2002:a05:620a:254a:b0:8b2:1f8d:f115 with SMTP id af79cd13be357-8c37ebcb5b5mr442348785a.65.1767710634577; Tue, 06 Jan 2026 06:43:54 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f51b732sm173883085a.25.2026.01.06.06.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 06:43:54 -0800 (PST) Message-ID: <9ceca23a-8709-43b4-b266-38cc0d924aac@riscstar.com> Date: Tue, 6 Jan 2026 08:43:52 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] clk: spacemit: prepare common ccu header To: Yixun Lan , Stephen Boyd , Michael Turquette , Philipp Zabel Cc: Guodong Xu , Inochi Amaoto , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20260103-06-k1-clk-common-v3-0-6061d9f69eef@gentoo.org> <20260103-06-k1-clk-common-v3-1-6061d9f69eef@gentoo.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20260103-06-k1-clk-common-v3-1-6061d9f69eef@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/3/26 1:26 AM, Yixun Lan wrote: > In order to prepare adding clock driver for new K3 SoC, extract generic > code to a separate common ccu header file, so they are not defined > in K1 SoC-specific file, and then can be shared by all clock drivers. > > Signed-off-by: Yixun Lan Looks good. Reviewed-by: Alex Elder > --- > include/soc/spacemit/ccu.h | 21 +++++++++++++++++++++ > include/soc/spacemit/k1-syscon.h | 12 +----------- > 2 files changed, 22 insertions(+), 11 deletions(-) > > diff --git a/include/soc/spacemit/ccu.h b/include/soc/spacemit/ccu.h > new file mode 100644 > index 000000000000..84dcdecccc05 > --- /dev/null > +++ b/include/soc/spacemit/ccu.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifndef __SOC_SPACEMIT_CCU_H__ > +#define __SOC_SPACEMIT_CCU_H__ > + > +#include > +#include > + > +/* Auxiliary device used to represent a CCU reset controller */ > +struct spacemit_ccu_adev { > + struct auxiliary_device adev; > + struct regmap *regmap; > +}; > + > +static inline struct spacemit_ccu_adev * > +to_spacemit_ccu_adev(struct auxiliary_device *adev) > +{ > + return container_of(adev, struct spacemit_ccu_adev, adev); > +} > + > +#endif /* __SOC_SPACEMIT_CCU_H__ */ > diff --git a/include/soc/spacemit/k1-syscon.h b/include/soc/spacemit/k1-syscon.h > index 354751562c55..0be7a2e8d445 100644 > --- a/include/soc/spacemit/k1-syscon.h > +++ b/include/soc/spacemit/k1-syscon.h > @@ -5,17 +5,7 @@ > #ifndef __SOC_K1_SYSCON_H__ > #define __SOC_K1_SYSCON_H__ > > -/* Auxiliary device used to represent a CCU reset controller */ > -struct spacemit_ccu_adev { > - struct auxiliary_device adev; > - struct regmap *regmap; > -}; > - > -static inline struct spacemit_ccu_adev * > -to_spacemit_ccu_adev(struct auxiliary_device *adev) > -{ > - return container_of(adev, struct spacemit_ccu_adev, adev); > -} > +#include "ccu.h" > > /* APBS register offset */ > #define APBS_PLL1_SWCR1 0x100 >