From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-1909.mail.infomaniak.ch (smtp-1909.mail.infomaniak.ch [185.125.25.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A419247CA75 for ; Wed, 29 Jul 2026 12:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.25.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785327156; cv=none; b=O+OgD1k2mNA0sh4F+Ge1c5ekEjrKBI7giAG7S4IIWrQVlVgcxhHbLFjc/krnxMOZIvRlttnIKXxTpnBamaIqPxyPaQnFrsztWFUW+/OV6sJLD1ZrHzP5COyBth0GWD6RZIwoNDDs0HP8B9KPrZ2Wyx/k6CzDwBI4SkhvqBtuH0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785327156; c=relaxed/simple; bh=76in1GjWNLlOlP0uaHCT03/EpP1Uo4LBVjEQfT2jkCo=; h=Subject:Message-ID:Date:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=PQU/PvH5XpkULB6iS8Gnt6evP61F4wIBTnQ4rY+g2iQ2leQC0joEJp1EC5d7tYui9I92fAIVTPpqqPwUiuuKnkm36GCySmLCbvhYO5m5eeqBXuJXLMEo52nUzkfc+ZUIqN62FtrzWP6Rn048RKdcE2f1mVOeTrrZ2nxahFLjUEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ik.me; spf=pass smtp.mailfrom=ik.me; dkim=pass (1024-bit key) header.d=ik.me header.i=@ik.me header.b=rcUc2SLJ; arc=none smtp.client-ip=185.125.25.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ik.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ik.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ik.me header.i=@ik.me header.b="rcUc2SLJ" Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4h9B6L0Vr8z2Wv; Wed, 29 Jul 2026 14:12:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ik.me; s=20200325; t=1785327145; bh=/Mf6oc8o3rgfoSd5qIUTbDR7145wWJf1XLsdkjAYlNw=; h=Subject:Date:From:To:Cc:Reply-To:References:In-Reply-To:From; b=rcUc2SLJbe1wzDhxkVtnNpyfZuacNYzGkoWzztqh41/Q9OMgk5a1JTmH9v/vlMYLn 6IU7fZUwGKjqot+2Qsy3EA/CfVct3kB0DTt4baZ+z8izxFAfL8cY4mMilelunAAiTR c/HmWP8hggNo+QgRqxxaBCn3XHlN1pU5unx6SNvM= Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4h9B6J68gszHKs; Wed, 29 Jul 2026 14:12:24 +0200 (CEST) Subject: Re: [PATCH v2] drm/tyr: add Job IRQ handling Message-ID: <9cf1107a-3dfd-43a6-9f25-d8e01595c9e3@mail.infomaniak.com> Date: Wed, 29 Jul 2026 14:12:24 +0200 From: Ewan Chorynski To: Laura Nao Cc: Daniel Almeida , Alice Ryhl , Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?utf-8?Q?=C3=96zkan?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, kernel@collabora.com, Deborah Brouwer Reply-To: Ewan Chorynski X-WS-Location: eJxzKUpMKykGAAfpAmU- References: <20260729-tyr-irq-v2-v2-1-c2750fc11d59@collabora.com> In-Reply-To: <20260729-tyr-irq-v2-v2-1-c2750fc11d59@collabora.com> X-Mailer: Infomaniak Workspace (1.3.1317) X-WS-User-Origin: eyJpdiI6InY2WER6UW9XQ0puUVJCN2l1NTVuUnc9PSIsInZhbHVlIjoiZWc1OFV4dktJWFJkWVlIbkdCL3h0dz09IiwibWFjIjoiNzVlMDczZjBkNThiZDVhYTlhOGI1OTgyYjU3ZGE5OWY1ZjFhMTkyODc0MmVmYzU2NzFmNWY1NjE0Y2IwY2U2ZSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6ImpKb3dxUHpkZWZvSWpyaW4zaVo0TlE9PSIsInZhbHVlIjoiWGVwbGprK1RQMkJqUVRsS1owNU12QT09IiwibWFjIjoiOGE0OTAxZWJjNDU0YzdlZmE3ZmYxMTI5MjhiMmQyYzBiMDBjZTA1NGU2YzdmZDE2MGE0YWQ3NjFhNDI1Y2RjYyIsInRhZyI6IiJ9 X-WS-LOCALE: fr_FR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Feedback-ID: :b8ff05a3410f642:ham:e74197f626dda86 X-Infomaniak-Routing: alpha On Wed, Jul 29, 2026 at 11:58:29AM +0200, Laura Nao wrote: > [...] > + > +impl TyrIrq { > + pub(crate) fn request<'a>( > + pdev: &'a platform::Device, > + name: &'static CStr, > + irq: T, > + ) -> Result, Error> + 'a= > > + where > + T: 'a, > + { > + let handler =3D try_pin_init!(Self { > + irq, > + _pin: PhantomPinned, > + }); > + > + // SAFETY: The resulting `PinInit` is not leaked, it is consumed= by the caller to > + // initialize a pinned `ThreadedRegistration`. > + Ok(unsafe { pdev.request_threaded_irq_by_name(Flags::SHARED, nam= e, name, handler) }) I think your `request` function should be unsafe with the same requirements as `request_threaded_irq_by_name`, otherwise how do you guarantee that this safety justification holds ? > + } > +} > [...]