From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] checkpatch: Warn on #include <uapi/...
Date: Tue, 18 Dec 2012 09:53:11 -0800 [thread overview]
Message-ID: <9cfc0861cd3ae0a7d4e72056c00b8bebef1490eb.1355853060.git.joe@perches.com> (raw)
In-Reply-To: <6433.1355840610@warthog.procyon.org.uk>
Avoid specifying include paths with uapi/...
as userspace should not use that path.
Neaten message line wrapping above.
Signed-off-by: Joe Perches <joe@perches.com>
cc: David Howells <dhowells@redhat.com>
---
scripts/checkpatch.pl | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 054a293..d0c11ee 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2238,8 +2238,11 @@ sub process {
my $path = $1;
if ($path =~ m{//}) {
ERROR("MALFORMED_INCLUDE",
- "malformed #include filename\n" .
- $herecurr);
+ "malformed #include filename\n" . $herecurr);
+ }
+ if ($path =~ "^uapi/") {
+ ERROR("UAPI_INCLUDE",
+ "#include should not start with uapi/\n" . $herecurr);
}
}
--
1.7.8.112.g3fd21
next prev parent reply other threads:[~2012-12-18 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 14:23 checkpatch.pl should check UAPI headers don't #include <uapi/...> David Howells
2012-12-18 17:53 ` Joe Perches [this message]
2012-12-18 19:17 ` [PATCH] checkpatch: Warn on #include <uapi/ David Howells
2012-12-18 19:52 ` Joe Perches
2012-12-18 20:35 ` David Howells
2012-12-18 22:14 ` Joe Perches
2012-12-18 22:35 ` David Howells
2012-12-19 1:30 ` [PATCH V2] checkpatch: Warn on uapi #includes that " Joe Perches
2012-12-19 13:31 ` Andy Whitcroft
2012-12-19 13:18 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cfc0861cd3ae0a7d4e72056c00b8bebef1490eb.1355853060.git.joe@perches.com \
--to=joe@perches.com \
--cc=agraf@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®