From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbeAASUI (ORCPT + 1 other); Mon, 1 Jan 2018 13:20:08 -0500 Received: from mout.web.de ([212.227.15.4]:60384 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbeAASUG (ORCPT ); Mon, 1 Jan 2018 13:20:06 -0500 To: netdev@vger.kernel.org, "David S. Miller" , lipeng , Matthias Brugger , Salil Mehta , Timmy Li , Yisen Zhuang Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] net: hns: Delete an error message for a failed memory allocation in hns_rcb_common_get_cfg() Message-ID: <9cfe5e9d-e46b-82b8-987a-19c69c60cdb4@users.sourceforge.net> Date: Mon, 1 Jan 2018 19:19:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YFCauir+UQFp2Tl5zHTAQ2enckp0S3Ioj7OcK3RY+IFTQqZVJDi a1NL9UyYPiaPf27JKRwGhqyYi5fM1DOGBgUsRjYcaTsBYih71tyzriLJopZbnIFnS5lpCzl 6/Hbyp9TP6DvVrZuPQBN5I4o1g3AeaHT9WUKnJBg827nvRpcitG2m7OsBKxfCTZH5zArhdo rg5qAkp/bN8qqrw5PYDUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:lTfP0nHvkGM=:wVHhfW+roSRW3gZQ89/ZhZ NcnxaZT2bHBKv/D5slaJFQHRYIyDs5GbHTiOaxII8PAl8y8iu2MJP/UszbMxIprMRZ1/+avlc YpUhwYnfJ56dr7sgVcv7c9dYRX2+EWcVfpv/OVqkdvNNpy6GZ3WdZASmTMxNNhVpVuELtjGN6 fhkji4ktjLdZmeM2rlGwrH1jazjrgznvRrWFTO1sQyEAAml8DWX+yHitnaH5+DevzgIx24dL5 yZfbg/xGkXoP1e3JkNEwEnfS1UzP0jncg+QBTT4ZOIh7SEfdbMJArdcZUzpzfDp5gQJQLs6fG fuyOUmLc8IYGvd/Y4CSbcjvbv/Skqu1IEGt7BQWvX7c32WzFVylrCjSH9v7ilDiUX0QPZoPgZ NiBQJD3wFECKeyWEGtHArdRZaxoy2Ob64fuoLAr5GRXtGAXYniv85gy5B4XsXVh1oQQmRp6FR 2dqieIk/p6rj1RZOA6TCzdYlYSpP+tqJ9aO7ql384qm6rJvgYOQsRoDUb6kRgyLO/oe5mbivV CzEl4FwZapM5kOODy/56+ZhEOnA43xCQ3wTE51gd+zQ9UQco0pfWKWs4doM2a+opjUWrfyaou iT3OAbDN9kwSgfQGxrRdTMNxW4/DOf4JOinjj2olgSavI1KepSdPzuG8V2sz2xQ+Qw1wHeMbz a0wStZvND9jgvOdyWVBH/ZdPFGxEkPZNd5rpJ5J9XksmIhww+TIld/r+qj/XWNuWY9hGI4Gwx +20Hp3lZ6z6b3aH2kQgApXip6rhjauM83aby9mndkYwoS5OXPBKT5mt1E4dmTII+Dq4Vr1D3C Kwz7zB0Yfc+x1XRRs0xAkhcd+hbC3poWumoJQj+UNIM6WBXjDU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Mon, 1 Jan 2018 19:11:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c index 6f3570cfb501..cd74f0598dde 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c @@ -767,10 +767,9 @@ int hns_rcb_common_get_cfg(struct dsaf_device *dsaf_dev, rcb_common = devm_kzalloc(dsaf_dev->dev, sizeof(*rcb_common) + ring_num * sizeof(struct ring_pair_cb), GFP_KERNEL); - if (!rcb_common) { - dev_err(dsaf_dev->dev, "rcb common devm_kzalloc fail!\n"); + if (!rcb_common) return -ENOMEM; - } + rcb_common->comm_index = comm_index; rcb_common->ring_num = ring_num; rcb_common->dsaf_dev = dsaf_dev; -- 2.15.1