From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Borislav Petkov <bp@alien8.de>, Ashish Kalra <Ashish.Kalra@amd.com>
Cc: <tglx@kernel.org>, <mingo@redhat.com>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<seanjc@google.com>, <peterz@infradead.org>,
<thomas.lendacky@amd.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <ardb@kernel.org>, <pbonzini@redhat.com>,
<aik@amd.com>, <Michael.Roth@amd.com>, <Tycho.Andersen@amd.com>,
<Nathan.Fontenot@amd.com>, <ackerleytng@google.com>,
<jackyli@google.com>, <pgonda@google.com>, <rientjes@google.com>,
<jacobhxu@google.com>, <xin@zytor.com>,
<pawan.kumar.gupta@linux.intel.com>, <babu.moger@amd.com>,
<dyoung@redhat.com>, <nikunj@amd.com>, <john.allen@amd.com>,
<darwi@linutronix.de>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>,
<linux-coco@lists.linux.dev>
Subject: Re: [PATCH v10 2/6] x86/sev: Initialize RMPOPT configuration MSRs
Date: Thu, 23 Jul 2026 10:23:56 +0530 [thread overview]
Message-ID: <9cfe76f4-8e16-4b21-a414-126a06859489@amd.com> (raw)
In-Reply-To: <20260723011031.GGamFqB1i4zt4Zlsx6@fat_crate.local>
Hello Boris,
On 7/23/2026 6:40 AM, Borislav Petkov wrote:
>> + /*
>> + * The RMPOPT_BASE MSR is per-core, so only one thread per core needs
>> + * to set up the RMPOPT_BASE MSR.
>> + *
>> + * Note: only online primary threads are included. If a core's
>> + * primary thread is offline, that core is not covered. CPU hotplug
>
> So what happens if not all cores are online?
>
> This should check that and fail if that is the case instead of blindly
> continuing here.
The offline cores will remain offline since hotplug is disabled. RMPOPT
is simply a performance optimization for RMP checks and leaving the
offline cores (that will never exit idle) unoptimized should be
acceptable.
When hotplug is enabled again, the platform would have already executed
SNP_SHUTDOWN and SnpEn would go back to 0 and RMP checks are disabled
entirely by then.
>
>> + * is not currently supported with SNP enabled.
>> + */
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-07-23 4:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 18:08 [PATCH v10 0/6] Add RMPOPT support Ashish Kalra
2026-06-30 18:09 ` [PATCH v10 1/6] x86/cpufeatures: Add X86_FEATURE_RMPOPT feature flag Ashish Kalra
2026-07-20 21:12 ` Borislav Petkov
2026-06-30 18:10 ` [PATCH v10 2/6] x86/sev: Initialize RMPOPT configuration MSRs Ashish Kalra
2026-07-20 22:17 ` Borislav Petkov
2026-07-20 22:38 ` Kalra, Ashish
2026-07-21 1:48 ` Borislav Petkov
2026-07-21 14:26 ` Kalra, Ashish
2026-07-21 14:57 ` K Prateek Nayak
2026-07-21 20:46 ` Kalra, Ashish
2026-07-22 2:46 ` K Prateek Nayak
2026-07-22 19:17 ` Kalra, Ashish
2026-07-21 15:32 ` Borislav Petkov
2026-07-23 1:10 ` Borislav Petkov
2026-07-23 4:53 ` K Prateek Nayak [this message]
2026-07-23 5:14 ` Borislav Petkov
2026-07-23 5:58 ` K Prateek Nayak
2026-07-23 7:03 ` Kalra, Ashish
2026-07-23 7:16 ` K Prateek Nayak
2026-07-23 8:00 ` Kalra, Ashish
2026-07-23 6:50 ` Kalra, Ashish
2026-07-23 13:24 ` Kalra, Ashish
2026-07-23 14:29 ` K Prateek Nayak
2026-07-23 18:32 ` Borislav Petkov
2026-06-30 18:11 ` [PATCH v10 3/6] x86/sev: Disable CPU hotplug while SNP is active Ashish Kalra
2026-07-01 9:40 ` Jethro Beekman
2026-07-01 16:39 ` K Prateek Nayak
2026-07-01 21:08 ` Kalra, Ashish
2026-07-01 21:25 ` Kalra, Ashish
2026-07-06 12:02 ` Jethro Beekman
2026-07-23 18:53 ` Borislav Petkov
2026-07-23 19:44 ` Kalra, Ashish
2026-07-23 20:00 ` Borislav Petkov
2026-07-23 20:39 ` Kalra, Ashish
2026-07-23 22:19 ` Kalra, Ashish
2026-06-30 18:11 ` [PATCH v10 4/6] x86/sev: Add support to perform RMP optimizations asynchronously Ashish Kalra
2026-07-21 15:06 ` K Prateek Nayak
2026-07-22 19:43 ` Kalra, Ashish
2026-06-30 18:11 ` [PATCH v10 5/6] x86/sev: Add interface to re-enable RMP optimizations Ashish Kalra
2026-06-30 18:12 ` [PATCH v10 6/6] KVM: SEV: Perform RMP optimizations on SNP guest shutdown Ashish Kalra
2026-07-20 20:17 ` [PATCH v10 0/6] Add RMPOPT support Kalra, Ashish
2026-07-20 20:28 ` Borislav Petkov
2026-07-20 20:39 ` Kalra, Ashish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cfe76f4-8e16-4b21-a414-126a06859489@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Ashish.Kalra@amd.com \
--cc=Michael.Roth@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Tycho.Andersen@amd.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jackyli@google.com \
--cc=jacobhxu@google.com \
--cc=john.allen@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®