From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Richard Fontana <rfontana@redhat.com>,
Mark Brown <broonie@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH] ASoC: Intel: sst: ipc command timeout
Date: Wed, 29 Apr 2020 17:19:03 +0200 [thread overview]
Message-ID: <9d003948-a651-9920-86b6-307e912dd8ed@linux.intel.com> (raw)
In-Reply-To: <BN6PR1101MB2132D23B042284DDA667642A97AC0@BN6PR1101MB2132.namprd11.prod.outlook.com>
On 4/28/2020 7:29 PM, Lu, Brent wrote:
>>
>> I've looked at the code and byt_is_dsp_busy seems suspicious to me.
>> Can you check if following change fixes problem for you:(...)
>>
>> We seem to treat SST_IPCX as 32 bit register instead of 64 one, which may
>> explain wrong behaviour. (Specification says it is 64 bit register).
>>
>> Thanks,
>> Amadeusz
>
> Hi Amadeusz,
>
> The patch does not work but I managed to create a workaround just for
> reference. Still don't know why first read in sst_byt_irq_thread returns
> incorrect value.
>
Hi,
yes that seems bit weird. It is bit better as it does not modify common
code, but still... Maybe going back to your original idea of replacing
memcpy, try replacing it with readq? It should generate one instruction
read (although it is only for x64_64, for 32 bit kernel we would still
need to do something else).
Thanks,
Amadeusz
next prev parent reply other threads:[~2020-04-29 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 8:18 Brent Lu
2020-04-14 8:59 ` Amadeusz Sławiński
2020-04-14 14:50 ` Pierre-Louis Bossart
2020-04-14 16:20 ` Lu, Brent
2020-04-14 19:53 ` Cezary Rojewski
2020-04-21 16:16 ` Lu, Brent
2020-04-22 21:24 ` Nick Desaulniers
2020-04-23 8:33 ` Amadeusz Sławiński
2020-04-28 17:29 ` Lu, Brent
2020-04-29 15:19 ` Amadeusz Sławiński [this message]
2020-04-30 15:38 ` Lu, Brent
2020-05-04 9:23 ` Amadeusz Sławiński
2020-05-06 1:38 ` Lu, Brent
2020-05-06 2:35 ` Keyon Jie
2020-05-07 2:19 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d003948-a651-9920-86b6-307e912dd8ed@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®