From: Michal Simek <michal.simek@xilinx.com>
To: Luis Araneda <luaraneda@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michal Simek <michal.simek@xilinx.com>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 4/5] arm: dts: zynq: rename board zed to zedboard
Date: Thu, 28 Jun 2018 08:40:18 +0200 [thread overview]
Message-ID: <9d00dae5-835f-43b4-0a78-2aa43bbcff54@xilinx.com> (raw)
In-Reply-To: <20180628054205.17737-5-luaraneda@gmail.com>
On 28.6.2018 07:42, Luis Araneda wrote:
> The real name of the board is ZedBoard, from Avnet
>
> Signed-off-by: Luis Araneda <luaraneda@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/xilinx.txt | 2 +-
> arch/arm/boot/dts/Makefile | 2 +-
> arch/arm/boot/dts/{zynq-zed.dts => zynq-zedboard.dts} | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> rename arch/arm/boot/dts/{zynq-zed.dts => zynq-zedboard.dts} (93%)
>
> diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
> index f1e911058..d10adc4d0 100644
> --- a/Documentation/devicetree/bindings/arm/xilinx.txt
> +++ b/Documentation/devicetree/bindings/arm/xilinx.txt
> @@ -30,7 +30,7 @@ Additional compatible strings:
> "xlnx,zynq-zc770-xm013"
>
> - Avnet ZedBoard board
> - "avnet,zynq-zed"
> + "avnet,zynq-zedboard"
>
> - Digilent Zybo board
> "digilent,zynq-zybo"
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 37a3de760..e4c39e26f 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1108,7 +1108,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
> zynq-zc770-xm011.dtb \
> zynq-zc770-xm012.dtb \
> zynq-zc770-xm013.dtb \
> - zynq-zed.dtb \
> + zynq-zedboard.dtb \
> zynq-zybo.dtb \
> zynq-zybo-z7.dtb
> dtb-$(CONFIG_MACH_ARMADA_370) += \
> diff --git a/arch/arm/boot/dts/zynq-zed.dts b/arch/arm/boot/dts/zynq-zedboard.dts
> similarity index 93%
> rename from arch/arm/boot/dts/zynq-zed.dts
> rename to arch/arm/boot/dts/zynq-zedboard.dts
> index bf3e26dbf..540581c56 100644
> --- a/arch/arm/boot/dts/zynq-zed.dts
> +++ b/arch/arm/boot/dts/zynq-zedboard.dts
> @@ -8,7 +8,7 @@
>
> / {
> model = "Avnet ZedBoard board";
> - compatible = "avnet,zynq-zed", "xlnx,zynq-7000";
> + compatible = "avnet,zynq-zedboard", "xlnx,zynq-7000";
>
> aliases {
> ethernet0 = &gem0;
>
It will just cause confusion and I can't see any benefit to rename this
file. If you want to state different compatible string with full board
name I am fine with that but that's it.
Thanks,
Michal
next prev parent reply other threads:[~2018-06-28 6:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 5:42 [RFC PATCH 0/5] arm: dts: zynq: improvements and cleanup Luis Araneda
2018-06-28 5:42 ` [RFC PATCH 1/5] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards Luis Araneda
2018-06-28 6:36 ` Michal Simek
2018-07-03 6:51 ` Luis Araneda
2018-06-28 5:42 ` [RFC PATCH 2/5] dt-bindings: xilinx: Add missing zynq boards Luis Araneda
2018-06-28 6:44 ` Michal Simek
2018-07-03 6:53 ` Luis Araneda
2018-07-03 23:04 ` Rob Herring
2018-07-05 21:10 ` Luis Araneda
2018-06-28 5:42 ` [RFC PATCH 3/5] arm: dts: zynq: correct and improve the model property of dt files Luis Araneda
2018-06-28 6:39 ` Michal Simek
2018-06-28 5:42 ` [RFC PATCH 4/5] arm: dts: zynq: rename board zed to zedboard Luis Araneda
2018-06-28 6:40 ` Michal Simek [this message]
2018-07-03 6:56 ` Luis Araneda
2018-06-28 5:42 ` [RFC PATCH 5/5] arm: dts: zynq: remove "zynq" prefix from compatible property Luis Araneda
2018-06-28 6:41 ` Michal Simek
2018-07-03 7:18 ` Luis Araneda
2018-07-03 23:07 ` Rob Herring
2018-07-05 21:12 ` Luis Araneda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d00dae5-835f-43b4-0a78-2aa43bbcff54@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luaraneda@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®