From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F04A29; Tue, 26 Dec 2023 01:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="bSa6KlQb" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BQ19ZpF026744; Tue, 26 Dec 2023 01:50:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=4jV4XqenFpnoF+jeihd+UEga3oCdhiA51ZiI1NhfUx4=; b=bS a6KlQbtgrH8Du5VseanWtVZx+dqVkQCZn24+sYYmP4ZSaQiaJhlntbz0mpX6VmJU CBkmfR186/aGwNoWGqIaKoC7OC3qHzXePtGP+H0dqv81Y5suQM+BtxFu2X9QsivC nWqdu2225VrhZcBTn4J3moNuMi9Xb+bt4T6PRJKCtXzFmtU0cKZyzkZmOSEuQdYt LtTO2rg2k7T8P8nvQHT3MEB6L0c+lyzyeDUgJtlY4TkXwB5/2sRqTStTAh2/kKo3 PWbqAwz54zI1xw8KTA/ns/CfTG0WNLXjibORGyi1rRKUWERA4RRVvIKcUMOzbeTP afsVh25eZJhn6TAOBnFQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v5n8p4r5f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Dec 2023 01:50:27 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BQ1oQpp026894 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Dec 2023 01:50:26 GMT Received: from [10.239.133.49] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 25 Dec 2023 17:50:22 -0800 Message-ID: <9d13e1ce-38b1-4cdd-83ba-eca0c3091ce1@quicinc.com> Date: Tue, 26 Dec 2023 09:50:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: arm: coresight: Update the pattern of ete node name Content-Language: en-US To: Krzysztof Kozlowski , Mathieu Poirier , Suzuki K Poulose , "Mike Leach" , James Clark , Leo Yan , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , , Tingwei Zhang , Yuanfang Zhang , Tao Zhang , References: <20231220140538.13136-1-quic_jinlmao@quicinc.com> <20231220140538.13136-2-quic_jinlmao@quicinc.com> <79f88d35-17cc-43b0-bb22-3c854f89d961@linaro.org> <8e5e9603-456b-4956-be03-b866feeeafb4@quicinc.com> <16932826-fcc2-49d3-95ab-201eff729360@quicinc.com> From: Jinlong Mao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: lilvSBMxAeyXiXmjnDh5R2-JWqi-TM3x X-Proofpoint-ORIG-GUID: lilvSBMxAeyXiXmjnDh5R2-JWqi-TM3x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312260012 On 12/21/2023 4:44 PM, Krzysztof Kozlowski wrote: > On 21/12/2023 09:36, Jinlong Mao wrote: >> >> >> On 12/21/2023 4:17 PM, Krzysztof Kozlowski wrote: >>> On 21/12/2023 09:15, Jinlong Mao wrote: >>>> >>>> >>>> On 12/21/2023 4:12 PM, Krzysztof Kozlowski wrote: >>>>> On 21/12/2023 04:28, Jinlong Mao wrote: >>>>>>>> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml >>>>>>>> index f725e6940993..cbf583d34029 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml >>>>>>>> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml >>>>>>>> @@ -23,7 +23,7 @@ description: | >>>>>>>> >>>>>>>> properties: >>>>>>>> $nodename: >>>>>>>> - pattern: "^ete([0-9a-f]+)$" >>>>>>>> + pattern: "^ete-([0-9a-f]+)$" >>>>>>> >>>>>>> My concerns are not resolved. Why is it here in the first place? >>>>>> >>>>>> Hi Krzysztof, >>>>>> >>>>>> ETE is acronym of embedded trace extension. The number of the name is >>>>>> the same as the number of the CPU it belongs to. >>>>> >>>>> This is obvious and was not my question. >>>> >>>> Do you mean why the pattern match of the node name is added here ? >>> >>> Yes, especially that it is requiring a non-generic name. >>> >>>> >>>> This node should not have the node name match, right ? >>> >>> Usually. For sure shouldn't be for non-generic names. >>> >> Hi Suzuki, >> >> Can we remove the pattern match of the node name and use a generic name >> "ete" for the ete DT nodes ? > > "ete" is not a generic name. What is generic here? It's an acronym of > some specific device name. > The device full name is embedded trace extension. So use ETE as the name here. Thanks Jinlong Mao >