From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Rob Herring <robh@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Linu Cherian <lcherian@marvell.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 06/11] dts: bindings: Document device tree bindings for ETE
Date: Mon, 4 Jan 2021 14:42:08 +0000 [thread overview]
Message-ID: <9d19b169-b037-20b1-7c00-b2ba2194addd@arm.com> (raw)
In-Reply-To: <20210103170216.GA4048658@robh.at.kernel.org>
Hi Rob,
On 1/3/21 5:02 PM, Rob Herring wrote:
> On Wed, Dec 23, 2020 at 03:33:38PM +0530, Anshuman Khandual wrote:
>> From: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>> Document the device tree bindings for Embedded Trace Extensions.
>> ETE can be connected to legacy coresight components and thus
>> could optionally contain a connection graph as described by
>> the CoreSight bindings.
>>
>> Cc: devicetree@vger.kernel.org
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Cc: Mike Leach <mike.leach@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> Documentation/devicetree/bindings/arm/ete.txt | 41 +++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/ete.txt
>
> Bindings are in schema format now, please convert this.
>
Sure, will do that.
>>
>> diff --git a/Documentation/devicetree/bindings/arm/ete.txt b/Documentation/devicetree/bindings/arm/ete.txt
>> new file mode 100644
>> index 0000000..b52b507
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/ete.txt
>> @@ -0,0 +1,41 @@
>> +Arm Embedded Trace Extensions
>> +
>> +Arm Embedded Trace Extensions (ETE) is a per CPU trace component that
>> +allows tracing the CPU execution. It overlaps with the CoreSight ETMv4
>> +architecture and has extended support for future architecture changes.
>> +The trace generated by the ETE could be stored via legacy CoreSight
>> +components (e.g, TMC-ETR) or other means (e.g, using a per CPU buffer
>> +Arm Trace Buffer Extension (TRBE)). Since the ETE can be connected to
>> +legacy CoreSight components, a node must be listed per instance, along
>> +with any optional connection graph as per the coresight bindings.
>> +See bindings/arm/coresight.txt.
>> +
>> +** ETE Required properties:
>> +
>> +- compatible : should be one of:
>> + "arm,embedded-trace-extensions"
>> +
>> +- cpu : the CPU phandle this ETE belongs to.
>
> If this is 1:1 with CPUs, then perhaps it should be a child node of the
> CPU nodes.
Yes, it is 1:1 with the CPUs. I have tried to keep this aligned with that of
"coresight-etm4x". The same driver handles both. The only reason why this
was separated from the "coresight.txt" is to describe the new configurations
possible (read, TRBE).
That said, I am happy to move this under the CPU, if Mathieu is happy with
the diversion.
Thanks for the review.
Suzuki
next prev parent reply other threads:[~2021-01-04 14:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 10:03 [PATCH 00/11] arm64: coresight: Enable ETE and TRBE Anshuman Khandual
2020-12-23 10:03 ` [PATCH 01/11] coresight: etm-perf: Allow an event to use different sinks Anshuman Khandual
2020-12-23 10:03 ` [PATCH 02/11] coresight: Do not scan for graph if none is present Anshuman Khandual
2020-12-23 10:03 ` [PATCH 03/11] coresight: etm4x: Add support for PE OS lock Anshuman Khandual
2020-12-23 10:03 ` [PATCH 04/11] coresight: ete: Add support for ETE sysreg access Anshuman Khandual
2020-12-23 10:03 ` [PATCH 05/11] coresight: ete: Add support for ETE tracing Anshuman Khandual
2020-12-23 10:03 ` [PATCH 06/11] dts: bindings: Document device tree bindings for ETE Anshuman Khandual
2021-01-03 17:02 ` Rob Herring
2021-01-04 14:42 ` Suzuki K Poulose [this message]
2021-01-04 18:15 ` Mathieu Poirier
2021-01-04 20:31 ` Rob Herring
2020-12-23 10:03 ` [PATCH 07/11] arm64: Add TRBE definitions Anshuman Khandual
2020-12-23 10:03 ` [PATCH 08/11] coresight: core: Add support for dedicated percpu sinks Anshuman Khandual
2020-12-23 10:03 ` [PATCH 09/11] coresight: etm-perf: Truncate the perf record if handle has no space Anshuman Khandual
2020-12-23 10:03 ` [PATCH 10/11] coresight: sink: Add TRBE driver Anshuman Khandual
2021-01-04 16:28 ` Suzuki K Poulose
2021-01-05 9:29 ` Anshuman Khandual
2021-01-05 11:37 ` Suzuki K Poulose
2021-01-06 11:50 ` Anshuman Khandual
2021-01-07 14:01 ` Suzuki K Poulose
2020-12-23 10:03 ` [PATCH 11/11] dts: bindings: Document device tree binding for Arm TRBE Anshuman Khandual
2021-01-03 17:05 ` Rob Herring
2021-01-04 3:44 ` Anshuman Khandual
2021-01-07 14:05 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d19b169-b037-20b1-7c00-b2ba2194addd@arm.com \
--to=suzuki.poulose@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®