mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: "Pali Rohár" <pali.rohar@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	"Jean Delvare" <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
Subject: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes
Date: Mon, 18 Jan 2016 12:59:40 -0800	[thread overview]
Message-ID: <9d1eb8634669ef09334c7e792eb21f20b320a07b.1453150613.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1453150613.git.luto@kernel.org>
In-Reply-To: <cover.1453150613.git.luto@kernel.org>

Currently they return -1 on error, which will confuse callers if
they try to interpret it as a normal negative error code.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 drivers/firmware/dmi_scan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 0e08e665f715..451ac04ed18d 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -144,7 +144,7 @@ static int __init dmi_walk_early(void (*decode)(const struct dmi_header *,
 
 	buf = dmi_early_remap(dmi_base, orig_dmi_len);
 	if (buf == NULL)
-		return -1;
+		return -ENOMEM;
 
 	dmi_decode_table(buf, decode, NULL);
 
@@ -978,11 +978,11 @@ int dmi_walk(void (*decode)(const struct dmi_header *, void *),
 	u8 *buf;
 
 	if (!dmi_available)
-		return -1;
+		return -ENOENT;
 
 	buf = dmi_remap(dmi_base, dmi_len);
 	if (buf == NULL)
-		return -1;
+		return -ENOMEM;
 
 	dmi_decode_table(buf, decode, private_data);
 
-- 
2.5.0

  parent reply	other threads:[~2016-01-18 21:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 20:59 [PATCH v2 0/3] dell-wmi: DMI misuse fixes Andy Lutomirski
2016-01-18 20:59 ` [PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski
2016-01-19  8:41   ` Jean Delvare
2016-01-19 11:04   ` Jean Delvare
2016-01-19 18:28     ` Andy Lutomirski
2016-01-18 20:59 ` [PATCH v2 2/3] dell-wmi: Fix hotkey table size check Andy Lutomirski
2016-01-19  8:31   ` Jean Delvare
2016-01-19 18:42     ` Andy Lutomirski
2016-01-18 20:59 ` Andy Lutomirski [this message]
2016-01-19  7:54   ` [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Jean Delvare
2016-01-19  8:36     ` Pali Rohár
2016-01-19  9:03       ` Jean Delvare
2016-01-19  9:07         ` Pali Rohár
2016-01-19  9:40           ` Jean Delvare
2016-01-19 23:51             ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d1eb8634669ef09334c7e792eb21f20b320a07b.1453150613.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®