From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] compiler-intel: Remove duplicate RELOC_HIDE()
Date: Tue, 31 Jan 2023 11:41:08 +0100 [thread overview]
Message-ID: <9d2450ce-6ba2-49eb-9f00-bcb1b8590eeb@app.fastmail.com> (raw)
In-Reply-To: <35c0fc4ba93b11c4b8a55c2907f736a840cd12a3.1675161286.git.geert+renesas@glider.be>
On Tue, Jan 31, 2023, at 11:37, Geert Uytterhoeven wrote:
> The RELOC_HIDE() implementation for the Intel compiler is identical to
> the generic version in <linux/compiler.h>, so the former can just be
> removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not even compile-tested.
> ---
> include/linux/compiler-intel.h | 5 -----
> 1 file changed, 5 deletions(-)
I thought the entire file was gone already. I don't see anyone
objecting to the earlier patch
https://lore.kernel.org/all/20221016182349.49308-1-masahiroy@kernel.org/
but it never made it in. Maybe we can revive that instead?
Otherwise, your patch looks obviously correct as well.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-01-31 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 10:37 Geert Uytterhoeven
2023-01-31 10:41 ` Arnd Bergmann [this message]
2023-01-31 10:58 ` Rasmus Villemoes
2023-01-31 11:29 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2450ce-6ba2-49eb-9f00-bcb1b8590eeb@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=geert+renesas@glider.be \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®