From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbdBJG66 (ORCPT ); Fri, 10 Feb 2017 01:58:58 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:56644 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdBJG6x (ORCPT ); Fri, 10 Feb 2017 01:58:53 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-8b-589d64a7a7b6 Subject: Re: [PATCH v2 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces To: Thibault Saunier , linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Andi Shyti , Shuah Khan , Inki Dae , Nicolas Dufresne , Javier Martinez Canillas , Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-media@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Ulf Hansson From: Andrzej Hajda Message-id: <9d2b9454-7ed0-b596-05eb-e0588311fc94@samsung.com> Date: Fri, 10 Feb 2017 07:58:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170209200420.3046-2-thibault.saunier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTURzHObuPXUeT61x5tIcxCDLLFIyOFFL04AYlgYVihQ29vpqPNhX1 jxQj3+lQw2lqgmYhajKnLi21KWmzUplohjofKZGPzJkZ+cjtWvjf55zf93u+53s4FCbqIxyo 0IhoVh4hlUlIAd749vfHY88CS3xdXybjqKlzhkC5RiWO5uareShnahZDvb11fKSeGiSQobmY RFl1DQRS9bbyUE3nKB9Vqtd4yFhxFzUvj5GoYy6VQI+WF3Fkas/FUFeNzxkbRjtaARh1VTrJ jAy+Ipn6ikRGkzPKZ9RLowSTrakCjEl94CrlJzgdyMpCY1n5cc/bgpCVkV48qtEmrvRrLj8J 6KwzgBUFaXdYrunEON4D+8ZekBlAQInoSgAH3q0T3MIE4PITzdaEsjiGVB7/ReObAzyzW0TP AFi7jpvZlg6Cmo0Gy76Y9oErQw9wswGjF3D4UPvDEkfSTnC9fpg0s5D2hC0jpXwz4/Qh2K83 WjS7aV+o/ZS1rbGBq3ljlgAr+gL8Yhy3MEa7QlV+B49jR1hfPY+ZwyCdTsEPG08Bd+v9UN2+ XfM87Fip4XFsC791afgc74OGvEyc82YCuJTTzecW+QBuLKq23adgR1c/waVZw9zGAowLEMK0 FBEnYeDS9Oz2oWehsrYJcM9lALDtcSGpBI5FOwoV7ShRtKNEGcCqgJiNUYQHswo3F4U0XBET EewSEBmuBlv/rGej67sWTN+/pgM0BSS7hMqEYl8RIY1VxIfrAKQwiViYHFDiKxIGSuMTWHmk vzxGxip0YC+FS+yEr8sGfER0sDSavcOyUaz835RHWTkkASeRYCm7Zfi9fZtHWJZ/Rrm457lK 3q3XefUV9KUQTZJWmVPYRG2o7p7dQiUxctPZXn9OnnpZ137SrTKYSfX+MzlcdUkSa2g+vElL 3zgnfBZfNwUl/7LWC1KuOLp6KS/6mW4Bw/DqiYl1YdoNr58VhQfXJot8dEfdExObTZ1x3hJc ESJ1O4LJFdK/RKStTWMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t/xq7pLU+ZGGKzZaWmx/cgzVotJ9yew WLx5u4bJov/xa2aL8+c3sFtsenyN1eLyrjlsFj0btrJazDi/j8li7ZG77BbLNv1hsri/pNBi 15d7bBaH37SzWkz98oHF4vOBScwWx9eGOwh67Li7hNFj06pONo871/aweWxeUu+xpf8uu8em T3dZPfq2rGL0+LxJLoAjys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJ oSwxpxTIMzJAAw7OAe7BSvp2CW4Z3+6cZynYJlgx78Uk9gbGQ3xdjBwcEgImEtdnWHYxcgKZ YhIX7q1n62Lk4hASWMIosX3+fUYI5xmjxI6uVlaQKmGBNIkt/7YygdgiAuESx+41QnVcZpQ4 8WYqC4jDLPCJRWJyay87SBWbgKbE38032UBsXgE7id135oHFWQRUJS6eus8MYosKREjMf7qK CaJGUOLH5HssIDangKvEk/sPWEBOZRbQk7h/UQskzCwgL7F5zVvmCYwCs5B0zEKomoWkagEj 8ypGkdTS4tz03GIjveLE3OLSvHS95PzcTYzAuN527OeWHYxd74IPMQpwMCrx8E6omhMhxJpY VlyZe4hRgoNZSYS3KXluhBBvSmJlVWpRfnxRaU5q8SFGU6AXJjJLiSbnA1NOXkm8oYmhuaWh kbGFhbmRkZI479QPV8KFBNITS1KzU1MLUotg+pg4OKUaGHkT36cZJCxj8fi8zbk8dL3k1do7 UscU17WbPQ5+VfrC46xJZUaTkbcAi/K31PLEOH3tqmlfrfpOq5k6cm8w7Ig4NdPf5rfi/2uh ek0LJcNuVph7CynuXZCv9dE/qPngN35ty2Ni1SuP/nq2OTzh+Yp7oUUtgq+Oz/53M9Y0QeTc +1+Tll7ZrcRSnJFoqMVcVJwIALFtqB4BAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170210065843eucas1p1ff68cf72774d13beceb1f53a44098928 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170209200635epcas1p468de5bbd46e247ff583d3d97cfe1840b X-RootMTR: 20170209200635epcas1p468de5bbd46e247ff583d3d97cfe1840b References: <20170209200420.3046-1-thibault.saunier@osg.samsung.com> <20170209200420.3046-2-thibault.saunier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.02.2017 21:04, Thibault Saunier wrote: > From: Javier Martinez Canillas > > The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace > should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers > don't agree on the display resolution that should be used as a threshold. > > Some drivers set V4L2_COLORSPACE_REC709 for 720p and higher while others > set V4L2_COLORSPACE_REC709 for anything higher than 576p. Newers drivers > use the latter and that also matches what user-space multimedia programs > do (i.e: GStreamer), so change the driver logic to be aligned with this. > > Also, check for the resolution in G_FMT instead unconditionally setting > the V4L2_COLORSPACE_REC709 colorspace. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/media/platform/exynos-gsc/gsc-core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c > index cbb03768f5d7..2beb43401987 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-core.c > +++ b/drivers/media/platform/exynos-gsc/gsc-core.c > @@ -445,7 +445,7 @@ int gsc_try_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) > > pix_mp->num_planes = fmt->num_planes; > > - if (pix_mp->width >= 1280) /* HD */ > + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ > pix_mp->colorspace = V4L2_COLORSPACE_REC709; > else /* SD */ > pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; > @@ -492,7 +492,10 @@ int gsc_g_fmt_mplane(struct gsc_ctx *ctx, struct v4l2_format *f) > pix_mp->height = frame->f_height; > pix_mp->field = V4L2_FIELD_NONE; > pix_mp->pixelformat = frame->fmt->pixelformat; > - pix_mp->colorspace = V4L2_COLORSPACE_REC709; > + if (pix_mp->width > 720 && pix_mp->height > 576) /* HD */ > + pix_mp->colorspace = V4L2_COLORSPACE_REC709; > + else /* SD */ > + pix_mp->colorspace = V4L2_COLORSPACE_SMPTE170M; > pix_mp->num_planes = frame->fmt->num_planes; > > for (i = 0; i < pix_mp->num_planes; ++i) {