mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: John Stultz <jstultz@google.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Connor O'Brien <connoro@google.com>,
	John Dias <joaodias@google.com>, Rick Yiu <rickyiu@google.com>,
	John Kacur <jkacur@redhat.com>, Qais Yousef <qais.yousef@arm.com>,
	Chris Redpath <chris.redpath@arm.com>,
	Abhijeet Dharmapurikar <adharmap@quicinc.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel-team@android.com, "J . Avila" <elavila@google.com>
Subject: Re: [RFC][PATCH 1/2] sched: Avoid placing RT threads on cores handling long softirqs
Date: Wed, 10 Aug 2022 19:11:40 -0700	[thread overview]
Message-ID: <9d2f1a82-8e0f-c0ad-e23f-e0d00905a596@infradead.org> (raw)
In-Reply-To: <20220811015758.3001641-2-jstultz@google.com>



On 8/10/22 18:57, John Stultz wrote:
> diff --git a/init/Kconfig b/init/Kconfig
> index c7900e8975f1..b0dde2771314 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1278,6 +1278,17 @@ config SCHED_AUTOGROUP
>  	  desktop applications.  Task group autogeneration is currently based
>  	  upon task session.
>  
> +config RT_SOFTIRQ_OPTIMIZATION
> +       bool "Improve RT scheduling during long softirq execution"
> +       depends on ARM64
> +       depends on SMP
> +       default n
> +       help
> +         Enable an optimization which tries to avoid placing RT tasks on CPUs

Above line is indented with spaces only. :(

> +	 occupied by nonpreemptible tasks, such as a long softirq or CPUs
> +	 which may soon block preemptions, such as a CPU running a ksoftirq
> +	 thread which handles slow softirqs.

All help text lines should be indented with one tab + 2 spaces,
per Documentation/process/coding-style.rst.
(The 3 lines above have one tab + one space.)

-- 
~Randy

  reply	other threads:[~2022-08-11  2:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  1:57 [RFC][PATCH 0/2] Softirq -rt Optimizations John Stultz
2022-08-11  1:57 ` [RFC][PATCH 1/2] sched: Avoid placing RT threads on cores handling long softirqs John Stultz
2022-08-11  2:11   ` Randy Dunlap [this message]
2022-08-11  2:15     ` John Stultz
2022-08-11  1:57 ` [RFC][PATCH 2/2] softirq: defer softirq processing to ksoftirqd if CPU is busy with RT John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d2f1a82-8e0f-c0ad-e23f-e0d00905a596@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=adharmap@quicinc.com \
    --cc=chris.redpath@arm.com \
    --cc=connoro@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=elavila@google.com \
    --cc=jkacur@redhat.com \
    --cc=joaodias@google.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qais.yousef@arm.com \
    --cc=rickyiu@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®