From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbdJHMdI (ORCPT ); Sun, 8 Oct 2017 08:33:08 -0400 Received: from m12-13.163.com ([220.181.12.13]:56639 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbdJHMdG (ORCPT ); Sun, 8 Oct 2017 08:33:06 -0400 From: Jia-Ju Bai Subject: [BUG] gma500: Possible sleep-in-atomic bugs in gma_resume_pci To: patrik.r.jakobsson@gmail.com, airlied@linux.ie, bhelgaas@google.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Message-ID: <9d3163c8-fd8d-e464-d99d-50064757848f@163.com> Date: Sun, 8 Oct 2017 20:31:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: DcCowABHYVKiGtpZXJCFMQ--.35945S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XryfCw18tF18ArykurW8tFb_yoWxArXE93 sYyrW7W3yjq3y3CF1akrsrZrWkKa4agFyDXayvq3WrGF1Sqa4kKr4DXry7Zr1agw45Xa4r XrnrJw1rCFyIyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYYjg3UUUUU== X-Originating-IP: [166.111.70.12] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiYwNrelaDvJRQIwAAs- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver may sleep under a spinlock, and the function call paths are: gma_power_begin (acquire the spinlock) gma_resume_pci pci_set_power_state __pci_start_power_transition (drivers/pci/pci.c) msleep --> may sleep gma_power_begin (acquire the spinlock) gma_resume_pci pci_enable_device pci_enable_device_flags (drivers/pci/pci.c) do_pci_enable_device pci_set_power_state __pci_start_power_transition msleep --> may sleep A possible fix is to replace msleep with mdelay in __pci_start_power_transition in drivers/pci/pci.c. These bugs are found by my static analysis tool and my code review. Thanks, Jia-Ju Bai