From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF09285CB3 for ; Thu, 4 Jun 2026 21:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780606938; cv=none; b=AofE2tiy4BNpsqd/xsGVtP+K60U3sfHNbitTugJLfJoXeAQosI/jcBPewICdsOYwyNujovIz1RTe0EbVM3Y3RrP9MBHsRs4misBrm1apd9VqCeDVwasx+A1ypjmjj6448tOiVLwPpe86Bw1npovmMAAUb6urCQsYslqy4QrEXfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780606938; c=relaxed/simple; bh=1Mnqpms2o44uk1778jDhw/oChgvu+1zcxrO/eA7pYOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d6mhmdrzEpti40PHDazHosHuXEwkCYpxx1r8qA0pAyMl9RbWkmDevlaIG3FDV3rMIAU1MzfKqq01526AfqjRF48ovzUOpoRoDa2TWt35FVBbEh4nIYtynrKLzywSL5ujSjN0LFjfvtDK5xw2JslG+cXfLG9HhF6QOgfQ9aF0bpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jif3TTHi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V8F3FheN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jif3TTHi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V8F3FheN" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 654HPI2S994913 for ; Thu, 4 Jun 2026 21:02:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +J7VoHerHsoGih65b4TQk9xRPzpJ4VqqpsrxtPUKxA0=; b=Jif3TTHiDkOjim6C 07P+SqvzsVQVBbWcP95eX+1XNv6SqrO9qO6eygasz/h3pI3Oh7mxD80Rb3ezLBOs 2XDNoWPcAe+eVZpjOachA2VNnImA6jMFXDW9gsBNOmnsmH37ezZBttGePAxsu3IH f5EId//qQgc6gaG4LhwIMhkIXVHTVIemPwNOCkjw5Mr7rOovtlMIAVteDZFdIt5Q sXPdDgLsljvjgSE8+C73bjWKB9CB+5AvtVwEKlo/UnkV6x/SxL4MUwdP689oAof4 hQ7DMpn/oEAFLGtvkqM5FJ1XmN0TwqnZql4e0dDozal16uCQs+cPAhyP9o/QxyuJ HNhLCw== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ek374uwx4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 21:02:16 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-304ec73b015so2463908eec.1 for ; Thu, 04 Jun 2026 14:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780606936; x=1781211736; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+J7VoHerHsoGih65b4TQk9xRPzpJ4VqqpsrxtPUKxA0=; b=V8F3FheN9yh8Vmw9YDXFLVofwd+R8vgVRIaHxXs36PWcH7WZsDwVWpnJeIADdjUtMe aVzDAQs1AaMRf29JhpCMbA74J5nGIWJkTVwB/eesakDSzw5FJT2Kd8/rOX3fqQK5SIw6 jJI6JhaaOC6n+NjFpGuDZgY6Q1Y1UwW7ETLLu5F/+HZQlpxzlyRtIJTHCDazrk1iDink Pw2nU2+V5RXwzZ0QgF6NHGz3WFp9fuuXRTN/jPG/VAonp5kI3BJLrTbAekcmkdJZLYqS ORU5HpoG297doWOAXJ/I1msSQ7R+OnLr9p/UPt6ryJaUqenwYG+aWvF9VCMSjSvET8w7 8kbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780606936; x=1781211736; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+J7VoHerHsoGih65b4TQk9xRPzpJ4VqqpsrxtPUKxA0=; b=iQUqBBLiuzG6wM82sWzjLa3zdSZPaQDUlaHDnc1NebsbliYlzn99UcrMnCeh12K+OI k0j1oqXaxPmAboTM0kjl5OGtYsGXb70EdngkwLOyZnqZw/r5uRbbYfboqU6AYpv8uC/S EkEPVGFaAzDFDKBrYcXlQkUlSLE/wg5qSNrj/1KlZfElORRMeyjnKR6A4ETii0FiTd8E CBdA/GrHw+RYVuUe2CvHWKEg0r1ohRkDTpGyKp6dnYU2UW1jpDUK2K+wnwsvyQNCbS0L VMVvEf/MVFSWFR1OaIr+It8lQwzMe8Ls22dL2qDOF+owJNW52sl9Lyw9/CygyarE1WbN mowg== X-Forwarded-Encrypted: i=1; AFNElJ+DOF4jy+ZS7bDmdvvk3IF+jg33SgeBZG8wS9aPXBDNSGmingswN0CbCJgv3KnfKQszUzrxNPexFnq1crQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwiQKyVscLXnll1eN8MbOLZSuAUttxed+OO8mwHKlP58FSBYYfH 8A8coHoghJezXo5SVF8sLt00RJDjdU2rTduxH6uerxPB0eYPajxhDfDj/Uzh9cHPOhZpkG6RLRK eY34eL40Y47ToLKxdExP0lhVGKJkr24Kj1shqlA8353FQXcwAIQsqVjKV7SRYq3bCvAU= X-Gm-Gg: Acq92OH5YssMSvzAEr1lA1fCn4UHoW9uZfLpsLMElw2XepOmguUxmW7PTty6CuVlpzz yvhxuGPKJW+cdPk37ZgpaSIZ1FLtsa/O9Ls63NtJLUhqfz7GcFW3j6PUFSOhr1nH2cASJ6KhmT0 ZfBjNMIJ8V4EquAIsxrq3pNfaLc8YUZta7W3NsbjyEdgHli9aAnZmd568GiHJekdnIUSSKvmSkj ZlzUBywFvtwr1csUrR6u0KuZ0hAevzPGDD1s5ummUPFGVAjhYj+04MR1kqg8MycfICGbCeljVDs 25jhRF7+PbmzxDqSdsIl57C9YknJc3Fb2AKLXqUn/JSiBjWJ07u6ck82VHhaHPCAC4WefGU+379 I40wgbp8Nx6ClDi/MY1wwc55op2O0YEuB6vu5oi99tyPiiwV43Xk4Yff5Zyjf/pYWLbiSypWlbW RCfijkiNZCOXNkUlDQjiMxU/1I X-Received: by 2002:a05:7301:9bc5:b0:2e7:c701:aa85 with SMTP id 5a478bee46e88-3077b47c994mr232157eec.17.1780606935984; Thu, 04 Jun 2026 14:02:15 -0700 (PDT) X-Received: by 2002:a05:7301:9bc5:b0:2e7:c701:aa85 with SMTP id 5a478bee46e88-3077b47c994mr232121eec.17.1780606935447; Thu, 04 Jun 2026 14:02:15 -0700 (PDT) Received: from [192.168.1.59] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074df349d8sm5820083eec.22.2026.06.04.14.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 14:02:14 -0700 (PDT) Message-ID: <9d3728cf-bf4b-4ba0-8c71-831d908072a9@oss.qualcomm.com> Date: Thu, 4 Jun 2026 14:02:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/1] remoteproc: qcom: Add NOTIFY_FATAL event type to SSR subdevice To: Gokul Sriram Palanisamy , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com, quic_viswanat@quicinc.com, quic_mojha@quicinc.com References: <20240820060943.277260-1-quic_gokulsri@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20240820060943.277260-1-quic_gokulsri@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDIwNiBTYWx0ZWRfX9DEjRNVZ55aN CZ/wiWCraLdASLHsDLt9HTgt78SmZaCf5FfjbF7CjRD2E0luHbfvB2jbfBPHz38EizhBaMWpIEP qxwsIQBVQxs3LSDBsV08xb8DaVaHLY3EI+cd0QmcHLmiZMVbFHTedXboG0pb/W+lgPpeEmXYibX uKXnPT//6pTGf8WT6XPzTd0knspqTCCKiHNtHxmfzNCcCxMWvAeb7saLCTUxCOGLrjkAy89a068 6TWd6UKepmResZrRmLUvcmp49NQxPviMLZPAKMqCdKc7EB/Dt0hw7e9G870imGFQYndJFQLxm9a oZb175yS2tSVNKpuY1OuC+8hb5KKyjRqM0xleMU0J5QNS0CE0Er5D4PiTAy4BYFgRU8k4LX2xaw YMlAFltlqZctmDwJnK5SXZ2Hpf6Wc5I6pMkBFCbKWmRz7Cln5ubUnIIIztvEpU20h7azWys0A76 HpbG12Kr0ODx7EDHD+g== X-Proofpoint-GUID: oDWc88D-bMTdj66kpRYjvJVR-mTzdmgR X-Proofpoint-ORIG-GUID: oDWc88D-bMTdj66kpRYjvJVR-mTzdmgR X-Authority-Analysis: v=2.4 cv=eJsjSnp1 c=1 sm=1 tr=0 ts=6a21e7d8 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=COk6AnOGAAAA:8 a=Be1Yk5Ofpn9B-WBGvlcA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_06,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040206 On 8/19/2024 11:09 PM, Gokul Sriram Palanisamy wrote: > From: Vignesh Viswanathan > > Currently the SSR subdevice notifies the client driver on crash of the > rproc from the recovery workqueue using the BEFORE_SHUTDOWN event. > However, the client driver might be interested to know that the device > has crashed immediately to pause any further transactions with the > rproc. This calls for an event to be sent to the driver in the IRQ > context as soon as the rproc crashes. > > Add NOTIFY_FATAL event to SSR subdevice to atomically notify rproc has Almost 2 years later and I'm finally seeing the ath12k patch in internal review that uses this. I was confused when the ath12k code didn't actually have any references to "NOTIFY_FATAL" and then I got a build error due to a missing QCOM_SSR_NOTIFY_CRASH. So all instance of NOTIFY_FATAL in the subject and commit text should be changed to NOTIFY_CRASH. And as was noted by Dmitry, this patch should be packaged with the ath12k patch when it leaves internal review.