From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA91199943 for ; Tue, 1 Apr 2025 19:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743536092; cv=fail; b=SZAwHidoa9EXJRx/gZcEl1HgNjbjIqO+wENzymvcwlvr3vpeGAV7lCFvab3cChl7FkCk9AeFrDM5xS6UU0d/gkPdd08ONZ2arEWoYURc3mi+beApbGFKV6oPjVbDhDQZaRIjxjt8bhZ6Dd9/fEGIv5cK6t0TMCm4uW9B7FuNtK8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743536092; c=relaxed/simple; bh=f5G3a53e9vVNEcIfrionpAhR6aAQT66WvGG9H89C0z8=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=XIlbb5nJrYAzFsAcEOPR95/6y+a0ejOTqmIWDlLJzo5TJHCofOHa3GJbPtuEPxVkAFOKN23mfrbR935HswnkPJh+Ttz529qqVl0YNmtipriXEs3jrM8BFf65T4ujNamY4DadJdY85RqxLAQ7iakqVRF7E7Wb4M12Zi+H1OVJ/Mw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=HG9erxkz; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Ke4RX7qk; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HG9erxkz"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Ke4RX7qk" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 531IJx5j024404; Tue, 1 Apr 2025 19:34:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=OvK+5AyWZtbGetwv+bV6T3G5w8EDjTN+KzwloDDKHOc=; b= HG9erxkz927GZe46KlTftx5bcggpL+ixdqEb1A1ji/iF90ZLF2jcZqvoPe4Q1SlY MvbuM0UaUHlJcTUJHz42HH77Mm8MD2uVttyeC3JX8nAVwKEs2htahFlcQMxyoyV5 E3kOtkxQtvqY3yZQTTLceaUZIQgt2GOcs4/gYdwqfGrdYJjzJXNzwfCrgvRzB5D/ AzRd6gf2bIAOUWRdgbqtxTzYXRK6znJX5qq2FPUgQJJjutGc4WqoolRXiX1ba+vS dcDRfCwj5SEu3u6EEuEEuDpcVaF6dZhfCkjMzAkTfX+1WqYs1qUjbD3B1U93bY0n guJCtGKo/uIwqr2z0AofPw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45p9dtgyv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Apr 2025 19:34:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 531I9dY0017033; Tue, 1 Apr 2025 19:34:05 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2044.outbound.protection.outlook.com [104.47.74.44]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 45p7a9p1cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Apr 2025 19:34:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nEFBXmEn9pkjrbEiikVCpi9gn/QHXrWWqw0vjqQOycAJK6Q2InL41PnMTegmokWaM1pjtv1H6zEYI1lsZM4I1ULQRu/oSRthWITT+1Datq0LLKjI6Boh2TLMrH3KNLSEfj1nd78C4e9qdlKHBWBWFIFVzuAXLuDl7W75kkzHxntZuPDCT9G/4D252krFij364mjQ5ud0pWeMy+zNesDPmfWkYwnmOwrBmFLE89FL4jWQz3XNJ0qm6V3S842n4Ay69jknlpQNnVl8iKJCbk4oA8vQn2fe3cbRYFt4YSq0i0VZObUeEsRuGZ+YOnP1FsmNP3+9NCrNnkM9xXBkzqFQmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvK+5AyWZtbGetwv+bV6T3G5w8EDjTN+KzwloDDKHOc=; b=gyp/gYYtp+F208vJC+IbQtfs1oQw515LHVA8H21JTa471ukTFTiEmwGal98RYPt2eycZvdbeDi0UJeFz3yDXKkpwbtFI1zjH9+r1OYaJooTNiMzjzM39knIN7Bkn8bj7ns+Xp2Yne+FofZT+QZptDlKQm+xhHWTJpBEMNpmQCbCpjjK8sJjaQyQuSH3Xflj9uW95LVzZPBpH8Zixzz1Qh/1TV4X/FdzvWnDxa17agrZF3k/IL8zmyAnLaCnnPRtXIHE0GCnwlmxVj/tfwBz2BlNl9v17hV46x2VyB/xFWTJh2VFXkWwAzVgS4DEb0PONIRYsfbW9mY6cYpPhxvX7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvK+5AyWZtbGetwv+bV6T3G5w8EDjTN+KzwloDDKHOc=; b=Ke4RX7qkRzXOSPkb4gDa8yux3veXaQ7wN4YkxREh+FPdC5NK647rf6OE/BJCNpS4yC4D1Q59u1985nctVUHO+SR4+GwQ6xidDoTcHldMsg69RnNYM2i6AP6Jco3nKHp1EqAwx4/27+QR7upFimjGp8rWhSGFL84aJPlTGQqdTSU= Received: from MW5PR10MB5738.namprd10.prod.outlook.com (2603:10b6:303:19b::14) by PH8PR10MB6672.namprd10.prod.outlook.com (2603:10b6:510:216::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.39; Tue, 1 Apr 2025 19:34:02 +0000 Received: from MW5PR10MB5738.namprd10.prod.outlook.com ([fe80::187b:b241:398b:50eb]) by MW5PR10MB5738.namprd10.prod.outlook.com ([fe80::187b:b241:398b:50eb%6]) with mapi id 15.20.8583.033; Tue, 1 Apr 2025 19:34:02 +0000 Message-ID: <9d386f6a-398c-4f8c-9901-620dd858f8d1@oracle.com> Date: Tue, 1 Apr 2025 14:34:00 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] jfs: fix array-index-out-of-bounds read in add_missing_indices To: Aditya Dutt , Dave Kleikamp Cc: Ghanshyam Agrawal , Roman Smirnov , Edward Adam Davis , linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, jfs-discussion@lists.sourceforge.net, syzbot+b974bd41515f770c608b@syzkaller.appspotmail.com References: <20250401152916.618963-1-duttaditya18@gmail.com> Content-Language: en-US From: Dave Kleikamp In-Reply-To: <20250401152916.618963-1-duttaditya18@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0363.namprd03.prod.outlook.com (2603:10b6:610:119::32) To MW5PR10MB5738.namprd10.prod.outlook.com (2603:10b6:303:19b::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW5PR10MB5738:EE_|PH8PR10MB6672:EE_ X-MS-Office365-Filtering-Correlation-Id: 505e7f98-34b3-4ecf-dabb-08dd71542828 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RERkOUZIVkdHL09jOXU0eFhDYTlFa3FaK3lJT0pXdWQvN21iU0xBc0JYMXYz?= =?utf-8?B?ZitWdWY5VDlGc1I4SmE0NEkwNXdXZkpZekhoc0pmSWo3SHBWQjJ1TXZ1U1lQ?= =?utf-8?B?dzJaZG1oY0lzRm9wTXBvczlibWlhQ0QrV1hBZDR5SEN3cE1rVnduVytPU2RI?= =?utf-8?B?Yk1iVXJrelZ3SHI0SkxmbkRERXRJNWd2akZrUFdwSm9lQzBISys2aWxoenZu?= =?utf-8?B?T05QZ2owK2xJck5vanVXT2hNLzFJT1d0NHRuQkxZb3dxeVZ2SXZqYmRaQ05C?= =?utf-8?B?eXp0STh6TDhjbW1EWjA1WHBJS0lHYUhmMlpaZmJsd3lGTUJPRC82OW9qOUVn?= =?utf-8?B?N0lHL3IrSGRWTUExRndyMFlEQ0F0RUFWVlg5YldlSWdaajRObk10b09Ud0dH?= =?utf-8?B?bnY1Slpzek94Z2V3QW9kYW9Gcmh4Ujg4T3pBQWxMM2VPbmxFU1AwUUNaWHZx?= =?utf-8?B?NmY1YmZoK09kRVBlMUhzcFkvZjhuUnRlZjNXdzFaM0NabEQ1d2RJYzd3UUU1?= =?utf-8?B?bFpDU1FkOHNBanp5bWp4ck5MaGRpZEMzZGdweEZodjF2b0l2dDF3TG1Bd1RH?= =?utf-8?B?ZWUwMnE1SW5yM1lZYVNJQmc5WWJrajdUakQ4WDNaaTlZdzVaL05IY2JMRld0?= =?utf-8?B?OEF4R1greDNES3lKR1ZBNE0zT1NWZXBCTUoxZm82b1A3NW9NYkVZSFNtL0ww?= =?utf-8?B?Ti84Z051SkgzQUZOemp1NXN2WTY3c0N6cjNiL2RHOFVXSXpHR1labHNTTEUw?= =?utf-8?B?QlErUmZ6MnJYMkJQeCtRcEhmM0c4TkEva0JEY0RCM01oMmdGNjh2cXlLdG12?= =?utf-8?B?ODlsTnNIK2FnMEVCa2U4ZDZ3Vnp5cVNnWmNIaU9QZzd4U0dDZm5zRFF5QTB5?= =?utf-8?B?czl0RVlPSEcxLzdSamdNWXU4NXJiei9yaDJycXFXNWZuSjBIM0w2MmxLcjVp?= =?utf-8?B?dTR5c09pUjdrdmdsTXJocXptRDNjVTAxSk1GTlNoQm9MKzVwS0wxRC9SYkht?= =?utf-8?B?VE9xWGZ6T2ZSSG5HU2xtZkg0bWt6V0VhUW1NM3ZoVVRnNTNweURUUTN1S0kx?= =?utf-8?B?VmtsTUswbHpzS3Z1SU9sQ0RsOS96YmtsQU5aM0FGUVlIY015eWUvRlg4a1VB?= =?utf-8?B?alRpV2JIam1HTlRsMEpGd2QvdlBOd3liNXRBbDRYbEY0ZTQzL3lBcUpTNnlG?= =?utf-8?B?N0ZnK2wvUytqbEtWcldHTTB2V3lQZmZGVllkbC80OTdIdDNoMng4THZqZ2FV?= =?utf-8?B?NkNhem5jWUlxK0R4cW1mQVBKWTIyM05pckVwcE5lWXhKdWUrTXpjbGhSblJU?= =?utf-8?B?U0ZVZ2NKa0FOZGY4VFpOOWtkbHNFZDhiSlZrbDZEbHErR0QxZWl0a3d2V2l1?= =?utf-8?B?b2RGdjNDT1dxWjJlbk9NY1JOcWtub0cvc014WGtDcHFrcSt5dy9oSGpOc2tT?= =?utf-8?B?ME1ocmJhUFlwVDN4VEFJWFZCWFJIUGk1a0NVZXgxMUF0dWdEdGx3RnRBNnBl?= =?utf-8?B?MWhCZFBicEo3NFJIYkRLVS9VM1UvZC9KK256ZXhwQnJaQUNOV2xTNXl2eWtn?= =?utf-8?B?S0VqM1pabVFUL1hHYmJkQ0tXZDJsNEo3VVY0ZGZJQ2pKQkJQWnorMzNIQVJP?= =?utf-8?B?NWQvUEdOTlN5TTBrOGNSeXJFdUp5NjhFbllWcUlQTHdIZy8xM0tHVllRMVdk?= =?utf-8?B?ZHFMVTM2aTFuUVZXOUFDeGN5bWtKZEd3azZ0anNLTUlraWR2bGNmS3V4YnY0?= =?utf-8?B?ejRCZlBsMUV0WGxWc1lmbThoTUF4UFVwc0hlQ3ZON2t1aWJ6U1lCMFJ5eUJ6?= =?utf-8?B?c0ZUZDlTWWJqL01SVFB3dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR10MB5738.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjRFVUp5aHArdmJnZzBvQkFnZERoQzJSVEhCK3NrMkVvM0Rrd1M2Y2F1aEN6?= =?utf-8?B?UjVnbUtVU3ZlazFNWmtZTGkrNlhCaTY0NG8vQTNmS0NvQUh3WXJaaG80SU03?= =?utf-8?B?NzNraC9mWmxTOExZQmRrU2FQb1VVRFdGbjlpZUR4dEdRajAyR1FFanV6NVkv?= =?utf-8?B?NjdHczN0V0k0OXE0SmVBd3J2ODR6OWhqR000ZCtISnV1OGJUaW8yNGtxRXc3?= =?utf-8?B?aVNERjRmQWwzMDhDWjVPME1rVjBJOVFVVmFrNnpCL1FwbmxpWWk1RloreG1w?= =?utf-8?B?eG5FTDlpTzZxeEc4QnRqNGdrTHJpQnpwbFVxOVN6MktoVG1lWGZRY3EwZzJl?= =?utf-8?B?OFpoVkRXV1daZUlLOGRFVWZWdUVTNTI5cXVuTnFJTGozZDdENnVEQ3JYaFhy?= =?utf-8?B?eUdMZ2VUYTJNUG8wTHVBQSszL21Yemg2dG5yTVlGWjFINHQyNDhNcm1TUjdx?= =?utf-8?B?YXZLWkJrdEI5S1FMZmxKWTQycVplSEtRY3oxV1BhdFZyUURQejVsZW9xVWt2?= =?utf-8?B?T2VkVkpON3o2RFp5Nmt2aHQrRzlxU0JPcjdVdFZ0Q0d6aTB6WU5laGdsTld1?= =?utf-8?B?aW9VbGFnUVdrWlJXWFlDNTNsQTk3dVpyZk9jNnZsbGFGcEpkN0E5dTdJRHNv?= =?utf-8?B?aFlvbDV6WlVCUkdJWVNSd283d24yK1pQNGNoZGNyeW4zdTNWL1grMTUrbHQ3?= =?utf-8?B?bnNCS2ZwdkhNL1ZGNjkydjNzWHpjVGd2cXpxVVpOTERFby95R2ZzM0kycGJG?= =?utf-8?B?bnlFSFQxcmlHMzVkYVEvNHBHbkRNWEVFTFJLSW9mRE5kUmJoRXpodEwrZ2Rv?= =?utf-8?B?R0IzamV6aXR4RFU2TFZNWGwxZzRrYS9TdDJucWZQaUhoTC9xMVl4UGorYng5?= =?utf-8?B?TFl0MmpEeGpBdlhNWmlzUTJzZjkzeS94UjRKTDZhdTFnSUVrMDZzUmtJam1Y?= =?utf-8?B?SmNqVzRDemtqZzlqNVhiK09lQW8xYmdUNURERkh5OHg4L0tkdVVlcE1YeHRt?= =?utf-8?B?TXN6bkF3ZFFmNU9NclBlQzh0VFlaUFBRb3B0WTlqa0NIeVR2YlNSRHpZN1FH?= =?utf-8?B?OVBzcXAyRE5wS3haVkFYazhzVzN0SGl6b2YveGMzTEU4bGc5Y2VwR0xMRmVM?= =?utf-8?B?V015MWxuRzdjK1F6T2U4eTZnMVVNNXRQVWVicE9WSG5BTUZVelhqaVRxdkE3?= =?utf-8?B?UnF3bUlaNlZhR3FndW5yMjEyV1lsUEEyYTlINDBxeWZXRkpLb2VkWUt4WFRh?= =?utf-8?B?Wk9XTlI1UzdDdjZNOGk5aHpoMU5wNTRwdnpPNFBxSFZJYXl1S2pQaW5GSzVG?= =?utf-8?B?ZWhJQTlHZjRtdzVSdUZQQUdyaWlWYTNvZDNpNUYxek9ITUJPQSsxeHV5a2Zv?= =?utf-8?B?THlMKzFiTSs3Nm1wWTdIWUFUZXMvcnphUG95dzVGc1hpVTI5VXRmU2lOZ0VO?= =?utf-8?B?aEJsNXVHVGdCVDVKUVJCOFNFZy8wSmhYMjRpb3Y2NVArYktZRVlESkxiakVC?= =?utf-8?B?djhGTGJGT2FyZlh3em9vOS9FL3Rub0gzMDFWQzNJRGlpUGRYMEh2bEVqQ2FQ?= =?utf-8?B?UXhzVWhhR0IyUDZFTlpJVHhtby9iUXBLL2dwU1JVNXFCSHZjZ25NdC9wK3J3?= =?utf-8?B?eDhxZHAwd1libEtQRTY1UkFCR0p3MktVZktIcE9oK2JpS2tsS3RTcjFKN2JP?= =?utf-8?B?MGNxYkZDZExtRHdiU3pLcGlrc2gzOG50M3ZyTzVzQlNRY1AwckhzZEZCL0wv?= =?utf-8?B?NGkzdkJULzdxT0V5NTVJQzE5dE0wa3VzMGtLeTdobGdFNDFYOXN4eGRuRS9F?= =?utf-8?B?bjhkUnExMXBNZW9veSs5d2VJTjRSZGRSRkVKazVLdnFVRzA1VnI0WHBRc1NU?= =?utf-8?B?WXBFcjVrTmlMSDFKQnhkVDhIUC9ueTR4SW9Vdk5yQnhSaWVoYW9qc1lHMkJI?= =?utf-8?B?YStVRWZDTkNBUGZ3RjV2Uyt4UVoyMDBCbkZ2MkxYSFcrYTZKdE91MitTK2NP?= =?utf-8?B?cjlueHV0eVBmT1V3bHRpaWxJbEhpNS9pYUJQdkpCd3ZST05hUTlZMURWOURi?= =?utf-8?B?UGErcU9RS0NqWnVTa21WWWJHNkdLb3RKUmFSdE0wZXZ3SEJ6NzgrSXNDdlhy?= =?utf-8?B?QkVENlJwMU50NVZBKzFnUE1vdEdRbUUxVHVNcVZuWklsL1NXYnlvOVZCaDNF?= =?utf-8?B?T0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SUTOcgmlLFQqMEMbL1UMuwmfVrTR0WjzlsqK7/CN9DdQWBUrKTqHj2rdkK5HPj1GAUJ+bj9uAkwm/FWAEmui5aAO1xPUUbIRV2Ws83bjn4Gx3jrCkMO69q8b1BBZzmN/4uIReUbkivZEHmcMsAEsewb6YP1EiCtM3er2fg+bW5XkZDJSY3s4G1UxtTFU6J+z5N7I6NmHFuYOKFGFkDk+ymf5sdme370a2qZyaj+s+50lusAE2/joCeY2FE1NzZPhaYZ/fJYZSfuxzQu9uWTPiZ4QHGOZJxPsTIMRhecpg1GqC+DB1e3k4zF+Z3bBmA/BFSkQ89JcSTNXFTrAqgi6Wl0raDKsJ/GL9VeUqXBCwUBo44boxOpJ2eWuR2vvTO0qEsIFqeKtI8SrIHoPHY2KAYjhRPz+eiFeaYJezRUwT27/Yy1XBGQPRSyQ2WQxzh8gKdhTvOmHE/qwYfBc+JCqpjzq702J0DZNWu9wM2mwTPcu+p6+h8xcOqr+2buRwmG483Hmh8ZKSUVN9js60V94AvVvT26ii3nYSAzaa4RsPBgp4D9ouSPXvGt6vhPq/4gGVq55NcOtZ8gH6IKFdU1TeRrNpzuK9makkgdekw5TLYg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 505e7f98-34b3-4ecf-dabb-08dd71542828 X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2025 19:34:02.2774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g7uBrABPnj5uvV1HpMalqcuMa9uMoXmfQMbjR+DIb7OfA0PzK8w5V+y5xjoMiRHK3FSppAHNthdq6L40WR5oUX5L6VNNdOqZzBoUY2K8Df0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6672 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_08,2025-04-01_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2504010120 X-Proofpoint-ORIG-GUID: GR5w-lGRoRtffJOlX91yhmeu-0XD3wyT X-Proofpoint-GUID: GR5w-lGRoRtffJOlX91yhmeu-0XD3wyT On 4/1/25 10:29AM, Aditya Dutt wrote: > stbl is s8 but it must contain offsets into slot which can go from 0 to > 127. > > Added a bound check for that error and return -EIO if the check fails. > Also make jfs_readdir return with error if add_missing_indices returns > with an error. Looks good. The only change I'm making is removing the jfs_err() call in the caller since the failing function is already spitting out an error message. Thanks, Shaggy > > Reported-by: syzbot+b974bd41515f770c608b@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com./bug?extid=b974bd41515f770c608b > Signed-off-by: Aditya Dutt > --- > fs/jfs/jfs_dtree.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c > index 93db6eec4465..de33026d18d2 100644 > --- a/fs/jfs/jfs_dtree.c > +++ b/fs/jfs/jfs_dtree.c > @@ -2613,7 +2613,7 @@ void dtInitRoot(tid_t tid, struct inode *ip, u32 idotdot) > * fsck.jfs should really fix this, but it currently does not. > * Called from jfs_readdir when bad index is detected. > */ > -static void add_missing_indices(struct inode *inode, s64 bn) > +static int add_missing_indices(struct inode *inode, s64 bn) > { > struct ldtentry *d; > struct dt_lock *dtlck; > @@ -2622,7 +2622,7 @@ static void add_missing_indices(struct inode *inode, s64 bn) > struct lv *lv; > struct metapage *mp; > dtpage_t *p; > - int rc; > + int rc = 0; > s8 *stbl; > tid_t tid; > struct tlock *tlck; > @@ -2647,6 +2647,16 @@ static void add_missing_indices(struct inode *inode, s64 bn) > > stbl = DT_GETSTBL(p); > for (i = 0; i < p->header.nextindex; i++) { > + if (stbl[i] < 0) { > + jfs_err("jfs: add_missing_indices: Invalid stbl[%d] = %d for inode %ld, block = %lld", > + i, stbl[i], (long)inode->i_ino, (long long)bn); > + rc = -EIO; > + > + DT_PUTPAGE(mp); > + txAbort(tid, 0); > + goto end; > + } > + > d = (struct ldtentry *) &p->slot[stbl[i]]; > index = le32_to_cpu(d->index); > if ((index < 2) || (index >= JFS_IP(inode)->next_index)) { > @@ -2664,6 +2674,7 @@ static void add_missing_indices(struct inode *inode, s64 bn) > (void) txCommit(tid, 1, &inode, 0); > end: > txEnd(tid); > + return rc; > } > > /* > @@ -3017,7 +3028,10 @@ int jfs_readdir(struct file *file, struct dir_context *ctx) > } > > if (fix_page) { > - add_missing_indices(ip, bn); > + if ((rc = add_missing_indices(ip, bn))) { > + jfs_err("jfs_readdir: add_missing_indices returned %d", rc); > + goto out; > + } > page_fixed = 1; > } > > > base-commit: a8dfb2168906944ea61acfc87846b816eeab882d