From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA8EE377574 for ; Mon, 10 Aug 2026 04:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786336085; cv=none; b=Aa+E2s0rZ0b4ZkMOW2ZrYvdEkb3y+Jhsba6PQdmkYO8dXZTGuMk4EWEmjQuzJoyEFNc6EkjB6/amifH30sBTDLBVoS/qb0kmW6GvAxe5zX45kArLGMBku/b33qhWSnozW4IS3doyKcOG9lDpxqH1aJk92nObdxHFmhA6B6qvrzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786336085; c=relaxed/simple; bh=dQPkDTMmuze2BB03YWJVGmQDQp7RRBBNNh3k1shsgcY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=caqXvHSJin16FBF+14EqCilnNjI6gks7994vCKD026PVBAmM2ZuIPjEvtDmQ0OmS1cma/Adei7BXPBm7+q61S2CCIfs8VPi14S7vPo2gdkynyiwybAcc4ex156VLEUOQZkIABHk+dsUxCBZyDRcolw7iUZ85f5IyIhAoC6kTuL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cvonk9WJ; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cvonk9WJ" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cee9b74ee1so11772315ad.3 for ; Sun, 09 Aug 2026 21:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786336083; x=1786940883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=G2+mngqpXFB/BdP3WTYNLW4HV2B5Fpn24ngCal9LsJQ=; b=Cvonk9WJ8EMy8mlSpxKEX/dhsCFKv2cm+8W9qq+xzAVOqd+Sz9CT7ea37/cNFRjiOE 8i2aMXkkL2jF3V/+FsdyS7g/gBrpHXdsf/LFTDZbawmEdwjVWdj5MABBXKzn0bbvwmTn m3yuu85AHYx2QuzdnHkQ4qlEj5B4u+KHAfuPtTKyv2zVEgCWTJoKXmMMxrcPYnGYYIE3 Q0W2BEwqdp0WLhQIrB6PvtsMckquX0uFI68Q6MC2nXaqrGKy4ExanLwe9tDIwGnVPmLA Ao0teF74S+sYHaCNjStEdbqZS0f2JK034Qvnkg7xySNECPChWwVd7iHi7+1aTXYOIYOY QQ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786336083; x=1786940883; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G2+mngqpXFB/BdP3WTYNLW4HV2B5Fpn24ngCal9LsJQ=; b=ml24+aVty7odYGl911lzuLJvu3UcUKyQfJ+OL2shhB5Aa/aaR/Q72LP0/xKwPMk1C4 wvE/Wlv+10AuL7VW2dbJv/oZALrIWweJGcA0rb/sCSVTh/WjuM9ajfpGBhoMsCD9YM9W 80//m6yd7Q8o0W0gmJz8vYmM2WMhNyV/5CsffFDPxhgw9QTcpMpFm4auGl7eRXFvJmyQ Xqo59J3QQjbEfFirTnjeaOjStcbaJyJZr84mq+VDzHRzE+DDTGN6i6rMvqGv9QIIozN3 Ts9d8kgSl5/9IyDm7K7ECunzBtGzA9dUcF01RJewDItwJCh6z+jjHuahYtNvpFlHz+QG Ygkg== X-Gm-Message-State: AOJu0Yxu7l8ZX6V466intq12taFma8qSh4gV6VORt6bF2F2H2+AQhakf nkyZ58RAHFyA18EEQOfSb+GWwaPWNTBt9yeSwi+/FsRe68mo2t+IksUA X-Gm-Gg: AR+sD12XLmwrLMoJRN3uFOMbKHTOajEsa2QiuVm4x35enVqut6tas03XaagZvDxWJir ALk6kTL+Tks3pfKsi0X10FgiOl04hjHU22dv0AKefloP46s7+ci0CgmaqF6NWAkGCSXGlcjeOfB ChDeAfHRLuWZhAOys0YhKAUXxsp6jkzJoazGS9mAtEO7x3fqHwo5WNovAWzjb6c5qT8mirTS48v iKAlRh718QmUfPpPV4QMygsdbK+YiKuIYyd084ql132R76tnRMSNSmFYgUmJ/T9fJ4/biYfPAWx d6m3RfGZzc+bX8tFDMNo/FW9f0kDnhS0tQt1jWWbBqifY2KX9g3QU2QPStsxPdPwJ7yBP7Ktu+o nAlNDJIunjTMzLVKV1OqJnrS+xys+g9Ap/Zc2y+YBUWPN/ltmLvWvjX/mOgf6hiVUqvjC3/VYoM BKWa/QYczvL9ifbr6h+vGkq9YOVUgeqzUHcWWeTS4OnlRsiA/hZVo0YFH5AvEIuwOoJ1meGgSdi VDBvQ== X-Received: by 2002:a17:903:3848:b0:2c9:c991:3bf0 with SMTP id d9443c01a7336-2d0ca70da11mr486962195ad.8.1786336083184; Sun, 09 Aug 2026 21:28:03 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86e917sm43312312eec.5.2026.08.09.21.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 21:28:02 -0700 (PDT) From: Cong Nguyen To: Guenter Roeck , Vadim Pasternak , linux-hwmon@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Cong Nguyen , stable@vger.kernel.org Subject: [PATCH v2 1/2] hwmon: (max6621) fix temperature clamp range Date: Mon, 10 Aug 2026 11:27:54 +0700 Message-Id: <9d3a4f1895a47794bb359a2a32fb1ccd6a15812c.1786334038.git.congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit MAX6621_TEMP_INPUT_MIN and MAX6621_TEMP_INPUT_MAX are used to clamp the writable offset and critical thresholds. They are defined as -127000 and 128000. The driver decodes the temperature through an s8 and its own comment in max6621_read() documents an 8-bit two's complement value, whose range is -128 to +127 degrees C. The current limits therefore reject the valid -128 degrees C and accept +128 degrees C, which does not fit the 8-bit range. Correct the limits to -128000 and 127000. Fixes: 92b64580f14b ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- Changes in v2: - Drop the temperature input change; it was not a bug (temp_input already sign-extends correctly via an s8 intermediate). - Drop the incorrect changelog reasoning (no "+128 degC", no PECI/16-bit). - Split into two patches per review: this one fixes the clamp range; 2/2 fixes the negative offset/crit reads. - No 1/64 degC precision change (not documented in the datasheet). drivers/hwmon/max6621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c index a7066f3a0bb4..ee5898fbe110 100644 --- a/drivers/hwmon/max6621.c +++ b/drivers/hwmon/max6621.c @@ -17,8 +17,8 @@ #define MAX6621_DRV_NAME "max6621" #define MAX6621_TEMP_INPUT_REG_NUM 9 -#define MAX6621_TEMP_INPUT_MIN -127000 -#define MAX6621_TEMP_INPUT_MAX 128000 +#define MAX6621_TEMP_INPUT_MIN -128000 +#define MAX6621_TEMP_INPUT_MAX 127000 #define MAX6621_TEMP_ALERT_CHAN_SHIFT 1 #define MAX6621_TEMP_S0D0_REG 0x00 -- 2.25.1