From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D386843C7D7 for ; Thu, 30 Jul 2026 14:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420002; cv=none; b=iINKrKglBXYV97Cm5QxZ+/GsL1cLLNPuRpZVK8w5JVx73mE76857PSVNqFaUDp9Lwu03Ylyi++1q7eexofYA3Bpda3kHH98Pa9GSltcWCZIz5RvQTRZpx5j6kCDUK8kpTHG/DPm95FjxqJqxiYTu7QBfXuDET5VlvPxeoKYy3a8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785420002; c=relaxed/simple; bh=2MKJpYCcEmBvomCNL8/c/RcwMm5yPaziZOFjzrfdOOo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UwL43+F2Jo9Sx9ZYawccTtn8Rsr+XcgvCf36BteijwiITG5VGjraKdx6JtzG3SIEGQUcH65wFUJB5IvCUpz754XgqOkazjAVA1WHZfdwzbZV8AIAuuZJ7CsoFdy4VdyAPCCsNzZZEEt+EhbKKlNhMoVT7G1o75JNevizxZWaDMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UIz+yc2X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LZw0rvD5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UIz+yc2X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LZw0rvD5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UDDOCm1373205 for ; Thu, 30 Jul 2026 14:00:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Bx2xLoU9ox3YzTyuhkOQkmhNLpIKdS9tw9DJDHAPc0U=; b=UIz+yc2X1jEWPTdy WwXtE1QE92TeVS/mdHfvjN1HOxbYI5AssW4CqRojNV+GVWWcAnYIrTEMecbvK6Jb fFgdCdLu2kyJ8aZU6AhZEUrfqR8Vvqmw681XXVd+zR9YEu94Z6wQAK0YHJMYjgv/ N6HPqlAfX4h+YoiRD/J2AyvnohJFzMYurtcWM8zIxCiU3pKWE13PGOgVFc2G9Tsi BqWBp5xJrtCIOXCg7DmAbGDCvp/CKVFAoNscQJ/NMblywndCwTwCu4FS0JYp9seL Za9QOZ0URQML8NPSoTxKKXLyV9uP1UnnUkfHrekEnNGCXGZOPjbnMg5E9i89VKdW TCqwiw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr70bg9fj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 13:59:59 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bfa45b280so3674481cf.3 for ; Thu, 30 Jul 2026 06:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785419994; x=1786024794; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Bx2xLoU9ox3YzTyuhkOQkmhNLpIKdS9tw9DJDHAPc0U=; b=LZw0rvD5ruYI4cW4nY3eRHudV1wOpJMCps2yOT4BDs75Ok6aPz3Q7YJBgHdsjbRB44 4kQQTF5qwpUm8Y2YgZQFVtW2pLaMqAgKdFJKb91s4MrSA1T5y1ROxeTV4U17mDcXXyl0 vt6Hiq2wxOqFvwNjpIzXJjdLe2iULsXldmuYao9VdLxMwtgs2lIfQ7c2+APJ9P8Yr1N0 FiQemYU57lOyK7dohq6TbzvUAv3Oy4p8GC7gpE+fCqrrGogBE0B3j9r5fsNZelwV0WGi Aplj+WMWN8pZJF90HrmGwHVnCAb5/OochwkE5E4iJzaZDfS5LRkqLK58G+W/On0E1EPQ x4GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785419994; x=1786024794; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Bx2xLoU9ox3YzTyuhkOQkmhNLpIKdS9tw9DJDHAPc0U=; b=TLBUdkiRI/JE234O2zC7UZWAWWeFV1nc6PRMy0Spkvcp8yBjUrZ1tt8p7QPNsuF0hQ DElxuLlDpdqycMzBuGaur3Hx9evOlyAgO9qCu16vET97R4HTdxNfZqYCqrX5HfNGMTaY TseaYOLU8+vTKIXzzeKUaEcjTSlMK0giWqoVNlJI34O0uZjtOdqCuQfq6LYIfe9Fe5Ht 0CtebE2mdpGDFpdEGhIKPSDiFuc74gXXVZ6FOQt/GkqbFcFTceRmtEBRlXZ3THjjvzJW CmHxbuuUv0ADG9vVyklMNY79JdMq5wEJMggONtrGGgYkNN7WRoNEXAINuTxCgskn8knO S4DA== X-Forwarded-Encrypted: i=1; AHgh+Rp7Tj5hA2TjKb21r0N91PREK8vd2LozPF9cNNR1YyeEICWF0Pb41xhO8rIhyleB9VeCbpps4kYPABtNPUE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyvh83cmwJw5xVBtjdNgMmVWl0xiPpmul1aZMchBOxb3dprvwjK MkzzvgAx7q7K2ykz3zWsLOtVHf9FO/KndlQJhMH4cOZ53a0iFHMVPcPFf4VpeTk4CI5can2LQ25 z4U8llDQIykfGEJTF63HybhoAUvUsIqLYwpWLmgTX7DXhGJYrj7hqLOq7iLJ551E9Lek= X-Gm-Gg: AR+sD10Rs8T66DWyYUwJxz869sVGqm4nEQHWJhn++MyRVHMIlVv5NjgP5mEqqd4YLVB R33smDO31f2ZhTUtq8fkLWeFkU9qnIaNf2rwnAJRi9f1bB5mRLQI2AM2qg72C5kk7iABHeljW5R ht5fnmS4hwdTNETQitn1bEgrmeUWH2WnLOVT5PzNrXvfl7IZyzXIVLsMFmiAIbAXpBe5+0TVUAd 8TiyRXd6a3LAtj2vhZSNp5rJpqADGN6mRC8K4TItQExfYbaVNDUeLXImDYa/XbH53DRfpUrOcEu POBixlnqbf+7QT92c91dvz4M5rEYTuavNEW0SULEVXQ5/SPx8q6YeHn+zxA2mIBQ9h9w2XdZAYu GX9IF1uNA5fkv8llh3Ch3Q09T X-Received: by 2002:a05:622a:a990:10b0:50f:b9a6:82ae with SMTP id d75a77b69052e-52b42b4deb6mr3958131cf.2.1785419994017; Thu, 30 Jul 2026 06:59:54 -0700 (PDT) X-Received: by 2002:a05:622a:a990:10b0:50f:b9a6:82ae with SMTP id d75a77b69052e-52b42b4deb6mr3957631cf.2.1785419993517; Thu, 30 Jul 2026 06:59:53 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fa8576a3dsm71944066b.14.2026.07.30.06.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 06:59:52 -0700 (PDT) Message-ID: <9d43109a-6c4a-4339-bf8f-de3aae6e25a6@oss.qualcomm.com> Date: Thu, 30 Jul 2026 15:59:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] drm/msm: detach the ARM DMA mapping before attaching our own domain To: Dmitry Baryshkov Cc: Rob Clark , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Sricharan Ramabadhran , Joerg Roedel , Russell King , Lu Baolu , Jerry Snitselaar , Jason Gunthorpe , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Heiko Stuebner , linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org References: <20260730-fix-qcom-smmu-v1-0-b12fa067804e@oss.qualcomm.com> <20260730-fix-qcom-smmu-v1-3-b12fa067804e@oss.qualcomm.com> <8e55ef12-6c4a-42b4-923b-238b3739ea51@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDEwNiBTYWx0ZWRfX/IR74OZ83ddE wsxXMdhkQJdkx1mRotiZEucVRdEr+62l6R6WLOotC+t8FlnH5zYxCPvow2YUkD0LOOzzEwKjIUN 7crl9lS5lib+PY5oeSv6Ntxp0MOOGgwPFYPny2aXxcNmDK6TjCzOLv1W8WmA8YKav7eldCq/9Bk P7cKyMRqqgEmlt5LNZ2N9jP1fSgq1nWgFzSF5H5UHRuKKCgmY2uUg/vie63NnJXshdbz/JW6aYu ldaIgqpRb2XW9BRy2NtnuVYix8GShDd2lWXO8Bj5+/vCv2dWiyTnrIM/CaNF65MQ9fmviil89To 6S+0bUlGHMtsEqaRLrxSp0+VbOmsgt4HwHo2Ev1SXd3ey/2C0+53jaF5XOV85aftpGLyhwzi5UI SW4MsEFnWqPami7b0MUZ8Gi7COsAOWVzqOnOMxNlWUnVBH9zDoHLhT10FILVeri5QTFamIzd4+M xml9UEmxOxG/af38RJg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDEwNiBTYWx0ZWRfX2QsT6xSQJk7V K5eURNMkyHACB9xl1Cl7lTJwCZMLlDgPJNjvV8sCskWixl+CwQ63SO3WEUSuox5T0eaT2lZ2Mb8 Cuh0wlPssiIhOar1ftAo8wnOr0U+43U= X-Proofpoint-GUID: OfNyVMt8gaGg_WVMwibpeLy5xkIxcpLp X-Proofpoint-ORIG-GUID: OfNyVMt8gaGg_WVMwibpeLy5xkIxcpLp X-Authority-Analysis: v=2.4 cv=P58KQCAu c=1 sm=1 tr=0 ts=6a6b58df cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=FAOltU6waKXSbT9yybQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_04,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300106 On 7/30/26 3:58 PM, Dmitry Baryshkov wrote: > On Thu, Jul 30, 2026 at 03:42:58PM +0200, Konrad Dybcio wrote: >> On 7/30/26 3:29 PM, Dmitry Baryshkov wrote: >>> On ARM32 with CONFIG_ARM_DMA_USE_IOMMU, arch_setup_dma_ops() creates a >>> dma_iommu_mapping for every IOMMU-backed device and attaches its domain >>> to the device's IOMMU group. That domain is neither the group's default >>> nor its blocking domain, so when msm_iommu_new() later attaches the >>> domain the driver manages itself, __iommu_attach_group() refuses it: >> >> [...] >> >>> +#if defined(CONFIG_ARM_DMA_USE_IOMMU) >>> +#include >>> +#else >>> +#define arm_iommu_detach_device(...) ({ }) >>> +#define arm_iommu_release_mapping(...) ({ }) >>> +#define to_dma_iommu_mapping(dev) NULL >>> +#endif >> >> I see this is prior art, but should we support this config being off? > > Yes. For example, on arm64. Right Reviewed-by: Konrad Dybcio Konrad