From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: David Heidelberg <david@ixit.cz>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Casey Connolly <casey.connolly@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Gergo Koteles <soyer@irl.hu>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider
Date: Mon, 6 Oct 2025 16:51:54 +0200 [thread overview]
Message-ID: <9d503228-2a54-40f3-ad6d-500144e14b2a@oss.qualcomm.com> (raw)
In-Reply-To: <8a21a653-4dcf-4418-9bb7-76e940ddcab2@ixit.cz>
On 10/6/25 4:32 PM, David Heidelberg wrote:
> On 06/10/2025 16:15, Konrad Dybcio wrote:
>> On 9/27/25 1:20 PM, David Heidelberg via B4 Relay wrote:
>>> From: Gergo Koteles <soyer@irl.hu>
>>>
>>> The previous GPIO numbers were wrong. Update them to the correct
>>> ones and fix the label.
>>>
>>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
>>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>
>> This is currently unused, can you bundle (or squash?) this with the
>> "add slider" series instead?
>
> The seriess didn't received any attention or reviews, so I hoped in least fixing the upstream device-tree before someone will have time to look at the whole.
>
> Would you recommend sending the "Add support for sound profile switching and leverage for OnePlus 6 slider" again, just with this small split improvement now?
It's been a good 2 months, so it wouldn't hurt.. perhaps wait
one more week for -rc1 to come out, in case anyone you depend on
is *that* pedantic..
Konrad
next prev parent reply other threads:[~2025-10-06 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 11:20 David Heidelberg via B4 Relay
2025-10-06 14:15 ` Konrad Dybcio
2025-10-06 14:32 ` David Heidelberg
2025-10-06 14:51 ` Konrad Dybcio [this message]
2025-10-27 22:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d503228-2a54-40f3-ad6d-500144e14b2a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soyer@irl.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®