Re: [PATCH v2 1/2] drm/omap/dss: Use of_property_present() to test existence of DT property

[Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>]

Hi,

On 14/01/2025 16:58, Krzysztof Kozlowski wrote:
> of_property_read_bool() should be used only on boolean properties.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. New patch - split from the next one.
> ---
>   drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index 7b2df3185de4..319f0a1d23a7 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -1236,7 +1236,7 @@ static int dss_video_pll_probe(struct dss_device *dss)
>   	if (!np)
>   		return 0;
>   
> -	if (of_property_read_bool(np, "syscon-pll-ctrl")) {
> +	if (of_property_present(np, "syscon-pll-ctrl")) {
>   		dss->syscon_pll_ctrl = syscon_regmap_lookup_by_phandle(np,
>   			"syscon-pll-ctrl");
>   		if (IS_ERR(dss->syscon_pll_ctrl)) {

Thanks, applying these to drm-misc-next.

  Tomi