mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Davidlohr Bueso <dave@stgolabs.net>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Uladzislau Rezki <urezki@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang1211@gmail.com>, Shuah Khan <shuah@kernel.org>
Cc: rcu@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 2/2] rcutorture: Fix issue with re-using old images on ARM64
Date: Tue, 15 Apr 2025 09:46:24 -0400	[thread overview]
Message-ID: <9d549c29-1036-457f-a909-65c9dcc08a62@nvidia.com> (raw)
In-Reply-To: <20250415133622.1563137-3-joelagnelf@nvidia.com>



On 4/15/2025 9:36 AM, Joel Fernandes wrote:
> On ARM64, when running with --configs '36*SRCU-P', I noticed that only 1 instance
> instead of 36 for starting.
> 
> Fix it by checking for Image files, instead of bzImage which ARM does
> not seem to have. With this I see all 36 instances running at the same
> time in the batch.
> 
> Tested-by: Paul E. McKenney <paulmck@kernel.org>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
> ---
>  kernel/rcu/rcutorture.c                                  | 3 ++-
>  tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 74de92c3a9ab..df6504a855aa 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -2412,7 +2412,8 @@ rcu_torture_stats_print(void)
>  			pipesummary[i] += READ_ONCE(per_cpu(rcu_torture_count, cpu)[i]);
>  			batchsummary[i] += READ_ONCE(per_cpu(rcu_torture_batch, cpu)[i]);
>  		}
> -		n_gpwraps += cur_ops->get_gpwrap_count(cpu);
> +		if (cur_ops->get_gpwrap_count)
> +			n_gpwraps += cur_ops->get_gpwrap_count(cpu);
>  	}
Oops, this hunk was supposed to go into the previous patch. I fixed it in my
tree and will post with the full set of torture patches later:

https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/log/?h=rcu/torture-for-6.16

Thanks.



  reply	other threads:[~2025-04-15 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 13:36 [PATCH v4 0/2] My new rcutorture patches for 6.15 Joel Fernandes
2025-04-15 13:36 ` [PATCH v4 1/2] rcutorture: Perform more frequent testing of ->gpwrap Joel Fernandes
2025-04-15 13:36 ` [PATCH v4 2/2] rcutorture: Fix issue with re-using old images on ARM64 Joel Fernandes
2025-04-15 13:46   ` Joel Fernandes [this message]
2025-04-15 13:40 ` [PATCH v4 0/2] My new rcutorture patches for 6.15 Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d549c29-1036-457f-a909-65c9dcc08a62@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=boqun.feng@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang1211@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®