Re: [PATCH v3 00/14] drm/tidss: dispc: Convert to FIELD_* API

[Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>]

Hi Maxime,

On 27/08/2025 18:12, Maxime Ripard wrote:
> Hi,
> 
> The tidss driver rolls its own API equivalent to the FIELD_* API already
> provided the kernel.
> 
> Since it's an ad-hoc implementation, it also is less convenient and
> doesn't provide some useful features like being able to share the field
> definitions that will come handy in the future.
> 
> Thus, this series converts the driver to that API and drops its own
> version.

This looks good. I'll push to drm-misc-next.

 Tomi

> 
> Let me know what you think,
> Maxime
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
> Changes in v3:
> - Rebase on top of latest linux-next, fix merge conflicts
> - Link to v2: https://lore.kernel.org/r/20250820-drm-tidss-field-api-v2-0-43cab671c648@kernel.org
> 
> Changes in v2:
> - Switch to macros to prevent a gcc error
> - Link to v1: https://lore.kernel.org/r/20250730-drm-tidss-field-api-v1-0-a71ae8dd2782@kernel.org
> 
> ---
> Maxime Ripard (14):
>       drm/tidss: dispc: Remove unused OVR_REG_GET
>       drm/tidss: dispc: Convert accessors to macros
>       drm/tidss: dispc: Switch to GENMASK instead of FLD_MASK
>       drm/tidss: dispc: Get rid of FLD_VAL
>       drm/tidss: dispc: Get rid of FLD_GET
>       drm/tidss: dispc: Get rid of FLD_MOD
>       drm/tidss: dispc: Switch REG_GET to using a mask
>       drm/tidss: dispc: Switch REG_FLD_MOD to using a mask
>       drm/tidss: dispc: Switch VID_REG_GET to using a mask
>       drm/tidss: dispc: Switch VID_REG_FLD_MOD to using a mask
>       drm/tidss: dispc: Switch VP_REG_GET to using a mask
>       drm/tidss: dispc: Switch VP_REG_FLD_MOD to using a mask
>       drm/tidss: dispc: Switch OVR_REG_FLD_MOD to using a mask
>       drm/tidss: dispc: Define field masks being used
> 
>  drivers/gpu/drm/tidss/tidss_dispc.c      | 297 ++++++++++++++++---------------
>  drivers/gpu/drm/tidss/tidss_dispc_regs.h |  76 ++++++++
>  2 files changed, 225 insertions(+), 148 deletions(-)
> ---
> base-commit: a6d3da9a268e3d0a20b76fb40fd3484fe219ff17
> change-id: 20250729-drm-tidss-field-api-382947a92d44
> 
> Best regards,