From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
linux-sound@vger.kernel.org, Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bard Liao <bard.liao@intel.com>,
Vinod Koul <vinod.koul@linaro.org>
Subject: Re: [PATCH RESEND] soundwire: fix usages of device_get_named_child_node()
Date: Tue, 28 May 2024 10:41:00 -0500 [thread overview]
Message-ID: <9d5f2625-f3e7-4212-8c9a-c22f137f39d9@linux.intel.com> (raw)
In-Reply-To: <0080bd18-58e1-4e82-96e0-e64d2fa978c9@web.de>
On 5/28/24 10:19, Markus Elfring wrote:
>> Add fwnode_handle_put() to avoid leaked references.
>
> Are you going to respond also to my previous patch review
> in more constructive ways?
> https://lore.kernel.org/lkml/eb15ab0a-e416-4ae9-98bb-610fdc04492c@web.de/
> https://lkml.org/lkml/2024/4/29/493
Sorry about that, both Bard and I missed your comments.
On the Fixes tag: I made a deliberate choice to add all the fixes in one
patch, to show that the usage was copy-pasted and done 'wrong' in
multiple places. That makes it really hard to add a Fixes tag since the
different uses were added in a time interval of about 5 years.
We could split and have multiple patches if that was desired, but I
would still not include a Fixes tag since the leaked references are not
that bad, we read the Manager properties on probe, and the peripheral
properties are generally not used by codec drivers, so it's unlikely
that any user will ever see a problem that requires a backport in
linux-stable. This problem was found by reading the documentation while
adding new things, not by any user report or test failure.
The error flow was revisited and hardened in a follow-up patchset which
also adds new properties for MIPI DisCo 2.1 spec [1], we'll share the
patches in this kernel cycle.
[1] https://github.com/thesofproject/linux/pull/4857
next prev parent reply other threads:[~2024-05-28 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 6:35 Bard Liao
2024-05-28 15:19 ` Markus Elfring
2024-05-28 15:41 ` Pierre-Louis Bossart [this message]
2024-05-28 16:22 ` Markus Elfring
2024-05-28 16:46 ` Vinod Koul
2024-05-28 16:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5f2625-f3e7-4212-8c9a-c22f137f39d9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Markus.Elfring@web.de \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®