From: Steve Longerbeam <slongerbeam@gmail.com>
To: Peter Seiderer <ps.report@gmx.net>, linux-media@vger.kernel.org
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry
Date: Fri, 16 Mar 2018 10:02:47 -0700 [thread overview]
Message-ID: <9d5ff49f-6d07-0371-9cc1-5ee929328241@gmail.com> (raw)
In-Reply-To: <20180315191323.6028-1-ps.report@gmx.net>
Reviewed-by: Steve Longerbeam <steve_longerbeam@mentor.com>
On 03/15/2018 12:13 PM, Peter Seiderer wrote:
> - fixes gstreamer v4l2src warning:
>
> 0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf:<v4l2src0:pool:src> Driver should never set v4l2_buffer.field to ANY
>
> - fixes v4l2-compliance test failure:
>
> Streaming ioctls:
> test read/write: OK (Not Supported)
> Video Capture:
> Buffer: 0 Sequence: 0 Field: Any Timestamp: 58.383658s
> fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes in v4:
> - new patch (put first because patch is needed to advance with
> the v4l2-compliance test), thanks to Philipp Zabel
> <p.zabel@pengutronix.de> for suggested solution for the right
> field value source
> ---
> drivers/staging/media/imx/imx-ic-prpencvf.c | 1 +
> drivers/staging/media/imx/imx-media-csi.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c
> index ae453fd422f0..ffeb017c73b2 100644
> --- a/drivers/staging/media/imx/imx-ic-prpencvf.c
> +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
> @@ -210,6 +210,7 @@ static void prp_vb2_buf_done(struct prp_priv *priv, struct ipuv3_channel *ch)
>
> done = priv->active_vb2_buf[priv->ipu_buf_num];
> if (done) {
> + done->vbuf.field = vdev->fmt.fmt.pix.field;
> vb = &done->vbuf.vb2_buf;
> vb->timestamp = ktime_get_ns();
> vb2_buffer_done(vb, priv->nfb4eof ?
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 5a195f80a24d..5f69117b5811 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -236,6 +236,7 @@ static void csi_vb2_buf_done(struct csi_priv *priv)
>
> done = priv->active_vb2_buf[priv->ipu_buf_num];
> if (done) {
> + done->vbuf.field = vdev->fmt.fmt.pix.field;
> vb = &done->vbuf.vb2_buf;
> vb->timestamp = ktime_get_ns();
> vb2_buffer_done(vb, priv->nfb4eof ?
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-16 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 19:13 Peter Seiderer
2018-03-15 19:13 ` [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry Peter Seiderer
2018-03-16 8:12 ` Dan Carpenter
2018-03-16 17:05 ` Steve Longerbeam
2018-06-11 20:48 ` Peter Seiderer
2018-06-12 8:41 ` Philipp Zabel
2018-06-12 8:59 ` Hans Verkuil
2018-03-16 17:02 ` Steve Longerbeam [this message]
2018-06-11 20:47 ` [PATCH v4 1/2] media: staging/imx: fill vb2_v4l2_buffer field entry Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5ff49f-6d07-0371-9cc1-5ee929328241@gmail.com \
--to=slongerbeam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®