From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67E2D19D087 for ; Thu, 26 Jun 2025 08:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750927381; cv=none; b=fp0tNyrXi/w0zsM3oUxb3JlD2hRxxixn2+hySfj05BOjc3TvCRDoMeSXmbogAwJRgLIgQ+cQactwdUbJi6m9OCmku6HarCbL9jk/Thu3O+Z7kaEg1rMZsGh8lj4CdSaOgH+HcUn1CdOXboiiEGrNMFe9Wfd1uiB4gG3EQSRdaeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750927381; c=relaxed/simple; bh=ligktBwIKrjL1k2FxuZqWrhVOWA3ZtJh6/sODsypgKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hUMOMuX7ioT0W5tdmSbzlHeiL3djHwng0cbDxCQh8/WA2cY59BOiPaLAvoSSp0E7DPqMrXmSuBA5IoCHM5SuYSIzNZIWg12HpVLLOwRQDlu7xa9Y2cqaq6LyYkAlxO8OBqLb14wuENZtki+JL37+ajPUE5baM/N0C7eAkvCotlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=McKZ+jvg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="McKZ+jvg" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55Q0DiWB018856 for ; Thu, 26 Jun 2025 08:42:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ujJ3hdrZdrWTs1QinajLpV8B1IFekcuKFA40yvSASwk=; b=McKZ+jvggb8UAIJr uwzGm7b1LdrMuN8TDjEhy1Q8l0xKd7fbHC7l2lezkK0x8T7udPS83QIWYSl8RYsc 9teaZgCJCxZnlDmlRTFAJYNgbU5+dRNuyP0lxpoQ0bREm7oJx0s7Qo5c1Dh0xTfh khtLSWCg084Z78b8uYMkhuNs045Kl4kbDhaAJto06yMfLglQAGAjDoWkWf4O0J17 MryR+pdms4HlXk2aRo49R7NAtVolpnfmun7p4KY0vkffJMI4FjDCMg6b9+MGogWQ X2cW5rRiR3iF2JAco354gUDKpIhkXK6TW0vHGmP37fiwi+zjGda4oItgaQRCNJtW SVeO9A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47g7tdcjtu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jun 2025 08:42:59 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d09b74dc4bso17112585a.2 for ; Thu, 26 Jun 2025 01:42:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750927378; x=1751532178; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ujJ3hdrZdrWTs1QinajLpV8B1IFekcuKFA40yvSASwk=; b=FVJmJKNsgTAZ6ELfnvs4/NJaDXM90w6FLlxWixt3AqlwlXVnsH2F/pcYLJlI2Hh3g/ ZS3qJ6NJ7qEAFbel64ofPvKcV27eNQemp703xPV6lfUmCg8sGQoUMKdKB4vO+E1NYHqD LAFuPeNXQZ3Ik3VrwcvYYSzWLKIX5Gevr4qUuBs0iB3ad9wZzApQlsjJoHZLrwjM3hN8 orFTaCRagvWLTtWa4XY1aTCnNKG77A9t5mDQZSvl+JBJSpSZQ76YMQypaNyTKJUTP/CM UHWcweBJ1zUms3+tZOCmxMVRXHAdyv5BrWtRhkqXN9hS/p+yFCRI+Z0KOoeOuSiO1Kpy FzgA== X-Forwarded-Encrypted: i=1; AJvYcCVIzdwBsJnlL5U/Ti1wZnYyhCFzTg+0MH+QP+dvCMK6/GX2G9WFtazCxqn127n9JQx5QJLHhgmvxNrtzGE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/x70HapDpFOYHL8u7Gl39Ofz/6s7cQIWqwc7zWaCXqJOFkWuO 63QlVrGb2etdPBoU8n/DKM/HBm+0M1/ABpiWX75423cU6ej9NWaB8yf3pfGslhvM7+/8pKXBOcB VMhhpSVnYdbAVuUrQ8Sy8nPU/K2gVzXEpaz93DGLAPLeZGX0LEhU5VHpOvGH1UDLQEx4= X-Gm-Gg: ASbGncsejsX0pqLNjfQw/TzS+NWtNwbZDvO92Ez3+aeVbmtXIJ2kqR2Mowdm2SRTrb+ LOv/H4FrT1Df7yUcjlN5I3QC0yE6EiHlGMNX0flTnpglT0Vdpfw2vyEjdnJDd7/FmoHWUtsae9Z on1BYIgequPn/oMy44pDIl/Gu1/3IwAnLrA43Nt+8PVGpnXkhVkoeeEvD1FlrE6BAeTT2hzA/2H NEgbPOPote4locUGvCSN/mXDWmPfCri3o5CRJGneItuvG54S23I/MOKyIIO0DjH/SZi+0Qjjh8v rxy/NRRKmrNAh0ExH/ACKY5lSDoMUMR2f+MrM9a4Rtlk0E+j+ssq96r3dWeGBdmeHpvTdwyucKj uGGE= X-Received: by 2002:a05:620a:28c6:b0:7d0:9ded:31e0 with SMTP id af79cd13be357-7d4295ce2ecmr287083085a.0.1750927377996; Thu, 26 Jun 2025 01:42:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaVjmoZaaH2FxAtCQ7+d0FZNW6yvYljbo9W4gCwn6F86xona1VfGrD8NQY4qhsOHOFM2vMlQ== X-Received: by 2002:a05:620a:28c6:b0:7d0:9ded:31e0 with SMTP id af79cd13be357-7d4295ce2ecmr287081985a.0.1750927377562; Thu, 26 Jun 2025 01:42:57 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae0a7b0565bsm456823666b.165.2025.06.26.01.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 01:42:57 -0700 (PDT) Message-ID: <9d619e6f-9ee1-4161-a60c-4d17d685a2cb@oss.qualcomm.com> Date: Thu, 26 Jun 2025 10:42:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] power: sequencing: qcom-wcn: Fix bluetooth-wifi copypasta for WCN6855 To: Bartosz Golaszewski , Konrad Dybcio Cc: Dmitry Baryshkov , Marijn Suijten , Bartosz Golaszewski , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250625-topic-wcn6855_pwrseq-v1-1-cfb96d599ff8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=CPYqXQrD c=1 sm=1 tr=0 ts=685d0813 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=imviz4xovgbBuZMsnOIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI2MDA3MSBTYWx0ZWRfX3BIvlHbnPass kA9QfhuQZLDpNvSCvZ57CbD4eP0oWnRYdH+LYToe+UpnosdxEE1K8SbZLGbe82qubxDBW0zmxkc APVa/Vd4MyVCdWmVe4xkZE5Yt4jeR6QIAz8ThWmKSwx1jjqT0bXSoqauKMOyWdQjqp8da9v3Dee zODQyeIISW6xjXrUMDYo+Upe+0AErTtSna1jcQ91fZbWsm04XMoNPIJzw1BTzENYBp02s8sp6OP lawY386I4313O2U87sLE83zV2Q1yWXv7J5+hV1VneJODCfBpJqCE00SkeX1VmDsg8aFrWd/DQvQ Qx2oZdTx5FTl3aVO3p0R+UHM+p86taXW6gDCOT705VKCSr3G2POSo3QelcBKx7R8ugV386XdHeu HP+S3OO7QPZypj4cxtP/d2b2r+xuPl+95zFiN/cICAJOCO69UM/5b3LMJgye/r9t+B9Lo+/J X-Proofpoint-GUID: nJiCQ55h8imt7SblqFxbquaGl6TeaFy_ X-Proofpoint-ORIG-GUID: nJiCQ55h8imt7SblqFxbquaGl6TeaFy_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-26_04,2025-06-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506260071 On 6/25/25 9:14 PM, Bartosz Golaszewski wrote: > On Wed, Jun 25, 2025 at 5:55 PM Konrad Dybcio wrote: >> >> From: Konrad Dybcio >> >> Prevent a name conflict (which is surprisingly not caught by the >> framework). >> >> Fixes: bd4c8bafcf50 ("power: sequencing: qcom-wcn: improve support for wcn6855") >> Signed-off-by: Konrad Dybcio >> --- >> drivers/power/sequencing/pwrseq-qcom-wcn.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c >> index e8f5030f2639a69254ad5efe0a313d2f3d10fa1d..7d8d6b3407495c28a780d5bb0668b2b35837b48a 100644 >> --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c >> +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c >> @@ -155,7 +155,7 @@ static const struct pwrseq_unit_data pwrseq_qcom_wcn_bt_unit_data = { >> }; >> >> static const struct pwrseq_unit_data pwrseq_qcom_wcn6855_bt_unit_data = { >> - .name = "wlan-enable", >> + .name = "bluetooth-enable", >> .deps = pwrseq_qcom_wcn6855_unit_deps, >> .enable = pwrseq_qcom_wcn_bt_enable, >> .disable = pwrseq_qcom_wcn_bt_disable, >> >> --- > > Thanks for the catch. Unlike target names, the unit names are mostly > for human convenience. That's why it didn't really break anything. If > you have no objections, I will queue it for v6.17 as I have already a > bunch of changes queued up and there's no point bothering Torvalds > with a one-liner that's not urgent. No worries Konrad