From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2423A9623 for ; Mon, 30 Mar 2026 07:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857234; cv=none; b=IolrlNNlgzHU2eAxl27WKNTrOVIwCElvScKdOJ22lHe4EYcMIgvJTo/nf0GhB/e8eA8Lhkv+QK1abPLIWuKRdpTt5Mm0ttI5KUv0k7e9ETwFJlJ3Uvcp3sqa4DpIOaPK0c2aemyw4PXHgz3jYojZEOYlHzmmBI768QccyTjb0XU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857234; c=relaxed/simple; bh=KsJU2GOUL2rxhhF6b9KgYacAej+D0aKUQzgrFpI4v0A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MzRd8iEQa5ddBsydiYLwIiI7fqxss4HN4YfzD3nUyqJZPzkPSQzuW+1yyCnxaAAgZYEOySmdlsTIR4g+zYHa5eCrEKxpWgng7cBqXdU2ZtTv03wsRpJdYCQz1wXhr77C5gFXwpJTv51PzdH9The5wd7gYlclteoQC5RsMCvj8Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XpMTcLAK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GlPZ7HTh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XpMTcLAK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GlPZ7HTh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U7kd9l3171980 for ; Mon, 30 Mar 2026 07:53:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rpOSRoW2BeG5b+IvWAJcqnNsVMW6l5tpe0p8bVysWio=; b=XpMTcLAKjaXwY9Y+ JnVklt40a6+Wl0+MVgX8XaR56OYUwtEshab0E9+Og37KB5i59zOZaxxStnLEzNX0 BFHZdX1GcpG7F0xsXmxPvHsNItP9sbcR7euGJ2yRX2hYnH3qyq6aiG2yNuyScBfT mGk2UYucFnfBT3aOuOCmQsCdvaOn5zYA4JwGLC+lTuZv1PO1KTfDdBomEzauQkQ+ 4u9VYsWR6JPS4eiBnZYr4Zydk2///D6tPyoOFmb/O+zMv8JKQ4GUMF6fuwywJdmd PG1Zvp/q623QOCgVCgLZ04LTxXnn6otGbEDXvPZouBhMb8CuD3vP7cbzEibOM+2M KsjI1w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d6ufmk55b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 07:53:52 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35c1874336aso12544814a91.3 for ; Mon, 30 Mar 2026 00:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774857232; x=1775462032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rpOSRoW2BeG5b+IvWAJcqnNsVMW6l5tpe0p8bVysWio=; b=GlPZ7HThptihERoYlOwxXQkdYYEb1MLM/1D+OwARQ+BlcElZdhaYA8cshR7gwzq/yo 6Ac2hAUSwNu489BC9SIF0Mz7s7uvaGIax6f2EAvspUIRZCGecnR71OETD05goZmZmGL6 H7jvtsCNQvDONEgbGpM8qSOAaV8YfYKc9cJxNOe8YmfF/ZwAiN36DryB4uHUw53A2MVC 7YspZw90v8zUFvNCAPK8Nap0iei/xq57ArawYVm9jCP8n1IwU9U3z8dJL6PLhs/XpouL FFYDF2+KYHNMdqIDNQmbTkJMm58RXDTSqkzrbq+JnFfmOZXNEuDzYtnZM4O4AZgJTpAo 9MXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774857232; x=1775462032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rpOSRoW2BeG5b+IvWAJcqnNsVMW6l5tpe0p8bVysWio=; b=ro9vVuU4zoC7nw3Vktq0wxzGQd/KvkfE7fX/U+lOXPUBHWL7qi8Pl0pcWDIEPr8Wvm pQAQcwtkJjQmVk0qSxCQY5NVIvv4kMIMOSce/50NGkOQk0dIXJ0Ka4Jpb5geP7WHK8g1 LC0CNalCP3LlYzCCFcu4D+Oyka+0Q66xyBngbv9iW59UVvbddUI51HwxNO9T5IGT2NLX irWk7P2NAj/XCmq8YKEw5+KpEk5B0eKgrXEWjPTfJs+xC7JEZuRB+XPnWwC0W8eCt7X0 wzSYJ3Sr9Ze81TCFMCNEpEQ7hRINQtS4yYQ3pWhNnM8o4U4ucRGcLoXYSmbBGG+6n6m3 OdYA== X-Forwarded-Encrypted: i=1; AJvYcCWFyFdI5K8jOv5ioOG0RtKgrP0WYzPJX4kqYRK+d0IgCEHN9WV9RlpkdxVgT/Yw6dP5TWvN6fji1jVEo2U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi2vEk4oAWeUXQKf2vkCaX676GOIn/dTrqE44EKjUK6HxPp1me lUg8r2z5XOsFgomsv3UY2a5L8VW7gkSaBZH9GKMNPsii9mFU7J3CVyHl2+AHpRLIrarvKIs7Pwz nYt4K9eemySiKzMgj0/UjE4ZW+MfZgKMQ2au7AGGEyzAZX86ubRdMRA1ohs+H8NKks58= X-Gm-Gg: ATEYQzw7rhV8VJr1/ZZnAI6PCPF6cLtezbq5qh2uBT61FT/NMXFLtuwr0Eg/iT0F4GB A5y1PIDVXzax09w+i8tm5Im7QJZsBXhiZWu4uJFCwUuVrBnHaBt3fQGQ5J7+6GJvpRTnLiETxTE htnZs8hY+i7Gqn7a1Ne9slsWAtNqjr7gQn4QxtN3u7IhWaiprs4nL+KkOTHe0J3Rm2AaVOlr8hU NFywwjdMJPFdyKyjVe9y4uapKuNaw4tG/EtzxKqXKNEF6xFxnnrdMocxcnExAEoJ9rSMf1FrZPv dL+t1lanJiA4CNEHZD5QjEWwGh55Hb67HPryUIFjKswOJaWWR0InNP+IW6S7nMZlQtUO+XTx2s6 NWVMBfHyGuNSePE1gFZhFMzTHcMopET+p6dDPJVfK9eJbZ+BY X-Received: by 2002:a17:90b:380d:b0:359:f3b1:6811 with SMTP id 98e67ed59e1d1-35c2ff08081mr10329001a91.1.1774857231610; Mon, 30 Mar 2026 00:53:51 -0700 (PDT) X-Received: by 2002:a17:90b:380d:b0:359:f3b1:6811 with SMTP id 98e67ed59e1d1-35c2ff08081mr10328989a91.1.1774857231193; Mon, 30 Mar 2026 00:53:51 -0700 (PDT) Received: from [10.64.69.173] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22a54fd5sm15147371a91.2.2026.03.30.00.53.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 00:53:50 -0700 (PDT) Message-ID: <9d65427c-f192-451e-9e67-c1a068aec2d9@oss.qualcomm.com> Date: Mon, 30 Mar 2026 15:53:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/38] drm/msm/dp: break up dp_display_enable into two parts To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-3-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA2MCBTYWx0ZWRfX7vd6wZkLEEku W/mLZMqXQ32VTLrDf4NnmidaVzkQ8AjEnirQBHqP0BxjzCEz0lDbk5vmMfmgLO3TBupZoNYOiqi /93VlpPlyC4IfHm4U7Rjly2OgGn6o+UxDutmrb+paaeCeb1SEO3vM7D/S2Z9TfxEDpbRrXKbFtP oVYN7poBQMBjVQ5K0mfvzpNboD7luTA4aJAFFWehfMK53Yovbo5FBJNqJW3LsbREU+suM4gl3Bn ZJ5i0qqZ9dg+pILSOE2KudNdy1qtTny48xkKI16jEMljTgYT/cEXbESsM1GkHME5RDFIZ792an+ u7VHgCF8FUbFFkvBYC4/6QZcJASwlDG9TgbDJE6q8KXO2xupqXEUnBIEgTPKHPcgNCa0TF38vUv jR4uUXFjemHNqNEKcilg823KQZyGn1+uJHWOXPdTPlSLe7RzO5fW9tbeejWTMWbN6wEQzAzmIxF PqFiOhIKrhk90/XGfVA== X-Authority-Analysis: v=2.4 cv=aOT9aL9m c=1 sm=1 tr=0 ts=69ca2c10 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=1ibuz8dZZ3-44BQBXskA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: FNtQcJC4Xz6Fa2hI7h7odMHDMJGAmF7x X-Proofpoint-GUID: FNtQcJC4Xz6Fa2hI7h7odMHDMJGAmF7x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300060 On 8/26/2025 1:13 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:15:49PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> dp_display_enable() currently re-trains the link if needed and then >> enables the pixel clock, programs the controller to start sending the >> pixel stream. Split these two parts into prepare/enable APIs, to support >> MST bridges_enable insert the MST payloads funcs between enable >> stream_clks and program register. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 51 ++++++++++------ >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +- >> drivers/gpu/drm/msm/dp/dp_display.c | 113 ++++++++++++++++++++++++------------ >> drivers/gpu/drm/msm/dp/dp_display.h | 1 + >> 4 files changed, 113 insertions(+), 55 deletions(-) >> >> void msm_dp_bridge_mode_set(struct drm_bridge *drm_bridge, >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h >> index 60094061c1029bc7a06ffaa80d9403b40aa07eb1..2fbf16f27842bb7639efaa2baecac7bdf8908432 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.h >> +++ b/drivers/gpu/drm/msm/dp/dp_display.h >> @@ -20,6 +20,7 @@ struct msm_dp { >> bool link_ready; >> bool audio_enabled; >> bool power_on; >> + bool prepared; > > Why do you need this? The msm_dp_display_prepare() function can only be > called from within the atomic_enable() callback, which is not supposed > to fail and which is always called in pairs with the atomic_disable() > callback. > Sure . Will move to the appropriate patch. >> unsigned int connector_type; >> bool is_edp; >> bool internal_hpd; >> >> -- >> 2.34.1 >> >