From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1AE274FD1 for ; Sat, 27 Jun 2026 08:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782549956; cv=none; b=ENlHZrPEqT2nADKZyxwGgPs0uLCaRWxKyLbNH8Y7lfKaM8ykARsSLCvd/v4KQfiKSUnTRImeQQFjHlVWHDrlmddHhCPwpuvoDVR9cxRQs3dW4pvaTFYP0yYAvsJgZYpacDYcsmVzCpviPtoo4Jvj5HsPGFBj5CaoKeBsxRJkalU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782549956; c=relaxed/simple; bh=jt0EBY+LImM/A8tZgmXPsqoQLL5bfBy2QOw0BIWnCeI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u08MomqMdu8ku3egcJlDwiT1AHqJvU/P3w0uIGSJodKA24/AIXYdIRcMPnA1XgISoUjTno40LsdjakR0YkxTgw8HEAhy04o8gG48U1Xk+ecNpyRuMLsYlAaL4n1v4YCQwDhy8H3zdWyU4ivv3iTRpmiOtzmXw+GkQ+uilUr/kY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I0Km5rlj; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I0Km5rlj" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490b7866869so14729605e9.2 for ; Sat, 27 Jun 2026 01:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782549953; x=1783154753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aApX5Xg5U2zMCX27/6SQYv+4H7RcS2fyony6licKWuk=; b=I0Km5rljpizTSznKp/varLO65/YWNRk8QBiuYepwdj1h84IxQx3N8lbnXLWAecVKbt 3do3UtvK6wtHYIt1QLG0kVN80UYmpIb6I2kIz8TdHncr6HWaVT056ZniQHcUirc/T9W6 NTwztbYH4W5pIydfYe8GhmCgTGCDikmZihZee4H/94/LYooVABjmcg5lH6d5nHfncsN9 zndeMDbCOis30mdsqOZdrZgTmdpyN0DSeFkuHYeZVx4HE2da4PNo6qZmJ23CsUUgqgY9 wlsLi7Jkn4bGGl/z5EfZLOgDtVVOPCovMl/Ng44AYAp+Nah7/AxNDoQSqo/PZTShO8Ng PQjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782549953; x=1783154753; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aApX5Xg5U2zMCX27/6SQYv+4H7RcS2fyony6licKWuk=; b=qHYxjjmHd9f+6YTR1w7eVdIQg4eo/2QgmutMqC3qoPPxh2h36TXANis5RJ0dA2w+yf R3nTjrdV8JW22KAbD/xk021E+rqYEIz6LnI53pnoRMNb9DLnu8vZzseks+jc4idW7XOp lH+PMkvti7FlSEBXC/ECJC2TB7mXzUuWaCPHEEd8WId0LwlYVxjX03r9N4KTIonbc27Z QdbZDp4Ocl2g06+/9HNq0FxAJqsQjvNKs9qLl+XgGIL31Nmk65N4TaKBqK6XG1FpUVGM e0yU1XtuXQMWbi78tdImqCJBFYz3ESY0XKKT3AP1sk/weiCkWdSy8fkjHE48vTYmiy/2 HpbQ== X-Forwarded-Encrypted: i=1; AFNElJ9H10htmLRFs1UnNzyf4daj4fgelPSG9B/EL5uKPaDsRF3IHA/kC8/M2DFXSJiZfFn6bmoeEUd/6Q321BY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4ufqmI9LIgKrvjv5vRXkr0kViSECty0ibhuIS9JFtOSdMfo12 wl4dNjsdcLfDiqSfH0nT5+46xSkUusYFBvQVlL0kk8hBFEXvat459CqW X-Gm-Gg: AfdE7cmcXkonFFiOEO1ygVaGIrT82ynxyCblQB0WTm866dKGGKH+uH3t1fHrghL9fgu S8nYhU8RBQhCFhRYag36usgr8udUcGkqGjUn9yGrUlnPJ+rlKHc9D5XMNVvNe2hDNvLGiR9JLSC 2CzbCGYrFCPKnFsWyRo/C3KaCgZIU0fGbIMU2YYR36ZlOSHXtPfpiiMk/10F3okWmQDl+oRPJfG jw6WNeHfWbLOhrtCAr8RnivZiXV1IqAoNzIkbD2ZmVnhOU9r8e5zGQLegfp4Vrk+BImVzZcslSd GPpis5Kt9EKfAvOH0luWv5xToo8fMWZgbGrZS2O0261UFfK3FhoREwTXfB2uVCfI7zFA7rEUJfs A4pKzmHWObBhd7OWhvtOydI/E9H5cPJ4/J9IWhDx5vGN/1f67BUeNSICRVF4poHIGfwHuF086Gj 5y/OYsN5CnwnLz6LAonPkxMYmbFLJfurva4JjliNZVdurK8sqEe94sHRtCgn0Y9Tgs2R7KzZjR0 Q9Mf9bqv3c0BIY= X-Received: by 2002:a05:600c:3593:b0:492:6cd0:41b2 with SMTP id 5b1f17b1804b1-4926cd04404mr71506295e9.32.1782549952575; Sat, 27 Jun 2026 01:45:52 -0700 (PDT) Received: from ?IPV6:2001:9e8:f106:e901:6d7b:bd22:a37c:4eb1? ([2001:9e8:f106:e901:6d7b:bd22:a37c:4eb1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492690988e0sm157844555e9.14.2026.06.27.01.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jun 2026 01:45:52 -0700 (PDT) Message-ID: <9d65d91f-f48e-4580-b32a-5b8c1126c003@gmail.com> Date: Sat, 27 Jun 2026 10:45:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/3] net: pse-pd: decouple controller lookup from MDIO probe Content-Language: en-US To: Carlo Szelinsky Cc: Corey Leavitt , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S . Miller" , Russell King , Oleksij Rempel , Andrew Lunn , Heiner Kallweit , Kory Maincent References: <20260626165929.2908782-1-github@szelinsky.de> From: Jonas Jelonek In-Reply-To: <20260626165929.2908782-1-github@szelinsky.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Carlo, On 26.06.26 18:59, Carlo Szelinsky wrote: > This is v3 of Corey's series [1]. It takes the PSE controller lookup out > of the MDIO probe path, so a modular PSE driver no longer makes the > PHY/DSA probe spin on -EPROBE_DEFER until the PSE module loads. > > v2 was four patches. The first one (a regulator handle fix) is a > self-contained bug fix, so on Jakub's suggestion it is going to net on > its own [2] and is not part of this series. The three patches here are > the notifier rework and target net-next. net-next was closed for the > merge window when v2 was posted; it is open again now, so here they are. > > How it works: pse_core gets a notifier chain (REGISTERED / UNREGISTERED). > The phy layer subscribes, owns phydev->psec, and attaches the PSE handle > when the controller shows up instead of during probe. fwnode_mdio loses > its PSE awareness, so no -EPROBE_DEFER leaves it and the probe-retry loop > is gone. > > Tested on a Realtek rtl93xx PoE switch with two HS104 PSE controllers on > i2c: > > - clean boot, no probe-retry loop, no watchdog reset > - 10G SFP+ port: module hotplug works, no deadlock > - ethtool --set-pse enable/disable cuts and restores power to a PD > - i2c unbind -> rmmod -> modprobe: PSE detaches on unbind and re-attaches > on reload with power restored, no reboot. No lockdep splats. > > Tested-by: Carlo Szelinsky > > Changes in v3: > - Drop patch 1 (regulator handle fix); it goes to net separately [2]. > - Rebase on current net-next. No code changes to the three patches. > > v1 was an RFC by Corey [3]. > > [1] https://lore.kernel.org/netdev/20260620112440.1734404-1-github@szelinsky.de/ > [2] https://lore.kernel.org/netdev/20260624204017.2752934-1-github@szelinsky.de/ > [3] https://lore.kernel.org/netdev/20260423-pse-notifier-decouple-v1-0-86ed750a9d62@leavitt.info/ > > Corey Leavitt (3): > net: pse-pd: add notifier chain for controller lifecycle events > net: pse-pd: fire lifecycle events on controller register/unregister > net: phy: own phydev->psec via PSE notifier and remove fwnode_mdio > hook > > drivers/net/mdio/fwnode_mdio.c | 34 ------- > drivers/net/phy/phy_device.c | 168 +++++++++++++++++++++++++++++++-- > drivers/net/phy/sfp.c | 2 +- > drivers/net/pse-pd/pse_core.c | 54 +++++++++++ > include/linux/phy.h | 2 + > include/linux/pse-pd/pse.h | 41 ++++++++ > 6 files changed, 258 insertions(+), 43 deletions(-) > > > base-commit: 805185b7c7a1069e407b6f7b3bc98e44d415f484 Thanks a lot for continuing the work! since you need to do a v4 anyway because net-next is still closed, feel free to include: Tested-by: Jonas Jelonek The issue I reported before, specifically with RTL8241FC, is fixed now. No deadlock anymore. Best, Jonas