From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B1632FD7BE for ; Mon, 27 Oct 2025 11:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761566119; cv=none; b=HwqlU+vGE375gFiAoa1wSFMkNd1ffLWH+n/dhWzcTR/NXKFTPcPsvSz+VcZwyRB0m3m3wqoyxws4G3dTLyQBDrSiOLOucV9EaHNDuAa/cWTe35EC83b1mdLl4KWLLmjZL6E4vIEc3UUwi9btOT2fUOvmr5NlGJheuIdyleDjQu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761566119; c=relaxed/simple; bh=s0aokbeBV/ht3ahPvmPE5Hx1GouHUyuPwC52VaMCS54=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y+iOBNX0Z3H/Rt55EcAiFgMmfifiRaySDdVWepDSsCsWVTiBvriosj+K2ngcAyKHbnbkz519o3doB8cvgiQwEQR0IV8JYM12/lUYw1FqFAm1NEDHpkkx68I96gwNhvYgWw4R7LEMrmTnCSfevT5qpyENBmI/fIFXqhey+aoMoVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cNRPH67Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cNRPH67Z" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59R8xfpu1245461 for ; Mon, 27 Oct 2025 11:55:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZWAM/1l3ob/3LqSmNYM1Kzzm3JAMnpjQt4pTVWbHtSU=; b=cNRPH67Z1NyjlP86 M3mT59D+2BjMtjmwTDK4eOBY5D48EYOjfmoKt45lQ91fdljCtvuHEmWbjcvu0jKN qvGFPVMEJobVnMbfmWfgwW/0VxH+7AuzzTvZb4skfqOMI9qISCFUwlnEbz43bGA0 //bJ4mw9Z0bu2PkyBcRWpQQmMa/U+MjAxRu/a5C0mhUp5qezSrfGK7//NzvQHkTj Zwdaqj9sY23LIXHqbOk/gx7gjt+PSV8cGkioWYe/BsryN8ruQdJY3dkBCzvrLyQM CTfdvPZ/yDfz8eOrfR8Eni4x/ELomNWnlFqbmEV2fZH+9ng5aIdxy4ZsYiGJzqaD 8Pp1Uw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a1uc59tj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Oct 2025 11:55:16 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7a153ba0009so8667868b3a.1 for ; Mon, 27 Oct 2025 04:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761566115; x=1762170915; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZWAM/1l3ob/3LqSmNYM1Kzzm3JAMnpjQt4pTVWbHtSU=; b=jws3o0Adl69ARiUVKQvN0Y88nwqIpLfh54Y/l8mlhZTYqDjBpj5/PUfE/qI+oRs8hc T/TDhQpEBLFz4EGH0f1c0Tontntt7R1IgrcSqk7RQX4g+/c7qVNP238HgbJL8m89Myu8 PfF5WG9HkiYGHeiENFL6UtF4FYVxLy1HWWQDM6WbV9BSS4DHyWa/JQO6YpsUyEdlyGg4 LVo6kQKC6dvVFaOua/TjK0tu140djpcsSL/qZwUniEOr6PaocxUy5R1tptGOnRXDl+5Z sq/r5J7gZuFV74AjxOM/doRC297yrzSS34UjQ1gkMdCyzFbTsEm3jWKaYeQsYdc0SZiY /3OA== X-Forwarded-Encrypted: i=1; AJvYcCX2LX1oPJ2Zc2LeifyRHig6tzmHvD80phS167iXLtOm+3odRteaqwXc+uejgCR5XN1SMcH0bucND0rY0LA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9iIysbTXsRS7cczMPOnT67aI+Pcq0ehMkleSxK0GQb0UcvC2j Cy6t1XZgM+Y6WTrV0mwoFCG9OWU2ukbJPEyrBKXa1PA45F/H7eEFfr87SEQV9945sfw4v2ZvRul KCtAjx6i4it5pY3m4y9lLeyZ8J/2QmsqRPIWg0Bh1XD6D56GdeJrJWLosu3R0PsM1VV8= X-Gm-Gg: ASbGncv0FRNeMe0wSXKN4uASD+HMyCgOISY2l/cROUyBXgCaNlkkCvgAJDjCxQOvLYn FcmAvK9Wu+izNSqXyFGqt+q1i6acSa4TmAQ3BHADoysYXMZypv6hnT/hTLcfXUO10eJTz0NSNoL BpDJUZBV9+s5ITYhIJD/w9ugn7di7y17DVAEPh8EHSAbv9SgY4X4svORxrfQblCLj5WvHE3uPwp HRbDicFvhm9jXNU5lJBUcocc+TBZotOg7g1R32mjxN1O6Z4QM27hd+kfdUQPjo0Cr4+W7pkN38M WMcbrAjzgIZYMEvSf2rfJdfJmNtMbtCykM7+NOlAFRkElVly/f/sciXlGHhWaRoj5J/zP6KIXjx n8V/9fXSeOkN0HLyhm7MCPXmGKuvGkb7DJGONjztDT+RAPdVmQXv8j1WwPFg= X-Received: by 2002:a05:6a00:1803:b0:792:5db2:73ac with SMTP id d2e1a72fcca58-7a28674d25emr12047805b3a.7.1761566115153; Mon, 27 Oct 2025 04:55:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGGkAcnkXHKQF/eHcUEuUAMP8k34i7aRfOMaE7hRoA4fzc286ygZftSP3+bEdiIYw6mSvSXQ== X-Received: by 2002:a05:6a00:1803:b0:792:5db2:73ac with SMTP id d2e1a72fcca58-7a28674d25emr12047778b3a.7.1761566114705; Mon, 27 Oct 2025 04:55:14 -0700 (PDT) Received: from [10.133.33.217] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a4387cbf00sm1985642b3a.2.2025.10.27.04.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 04:55:14 -0700 (PDT) Message-ID: <9d6d7641-d2c0-4629-944c-1bb88eddc486@oss.qualcomm.com> Date: Mon, 27 Oct 2025 19:55:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] remoteproc: mtk_scp: change the snprintf() checking To: Dan Carpenter , Bjorn Andersson Cc: Mathieu Poirier , Matthias Brugger , AngeloGioacchino Del Regno , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: VbCSdeP97XBjfkBxvAfKYBSdZJsaB_n3 X-Proofpoint-ORIG-GUID: VbCSdeP97XBjfkBxvAfKYBSdZJsaB_n3 X-Authority-Analysis: v=2.4 cv=Z4Dh3XRA c=1 sm=1 tr=0 ts=68ff5da4 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=9rX-9eNafPfUpquPNkAA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI3MDExMSBTYWx0ZWRfXwqZf868f15uT upqZXTqxt69wBc/yuEfu+4PbnkOMZ3zlVWCQvaahfhKKF58KZX6eL6ymxnmTT8HRzhrd5h4wNm8 cq+KrgW0xVZ0gCB9d7e5z5y5Stt+Htq+PTKU1bkVO5dpSbIytyMNKWSvT+dVKP7/sKwuzQ60uEi jCLaJpWxjiIig+D3/oSbjXXI0OzMyh0WEY77Ebz70DO9IlmBBn/5aMKrtsMoMMVi7KR6tEuC6Yj 07o3V+160PaB5ehnasvZSPZF47AkcbMwkiEDqAEV24WXEjee0PA+dcLZEp6/zbciAoF/6ZZVFxi Wfut6wVPQZ7RDmBaB6xleEIocAODoOV6cvItYCEQoL9ogGSsaP6e2ikO+0CskQsO392vm8Ewoqd iiQslrAyy6rMr9Q+OxP4WPZfrdr41A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-27_05,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510270111 On 10/27/2025 3:08 PM, Dan Carpenter wrote: > The snprintf() calls here work but they have several minor style issues: > > 1) It uses ARRAY_SIZE() which is the number of elements in an array. > Since were talking about char that works, but it's more common to > use sizeof() which is the number of bytes. > 2) The printf format is "%1d". The "1" ensures we always print at > least 1 character but since numbers all have at least 1 digit this > can be removed. > 3) The kernel implementation of snprintf() cannot return negative error > codes. Also these particular calls to snprintf() can't return zero > and the code to handle that zero return is sort of questionable. > 4) In the current kernel the only "core_id" we print is "0" but if it > was more than 9 then the output would be truncated so GCC complains. > Add an "a >= sizeof(scp_fw_file)" check for output which is too long. > > Signed-off-by: Dan Carpenter Reviewed-by: Zhongqiu Han > --- > v2: The v1 introduced a W=1 warning because of the truncation issue. > It's a false positive because GCC assumes that "core_id" can be > every possible value of int but actually it can only be zero. And > also generally, in the kernel, truncating is fine and it is fine > here too. > > But let's use that as an opportunity to do more cleanups. > > drivers/remoteproc/mtk_scp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 10e3f9eb8cd2..db8fd045468d 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1127,11 +1127,11 @@ static const char *scp_get_default_fw_path(struct device *dev, int core_id) > return ERR_PTR(-EINVAL); > > if (core_id >= 0) > - ret = snprintf(scp_fw_file, ARRAY_SIZE(scp_fw_file), "scp_c%1d", core_id); > + ret = snprintf(scp_fw_file, sizeof(scp_fw_file), "scp_c%d", core_id); > else > - ret = snprintf(scp_fw_file, ARRAY_SIZE(scp_fw_file), "scp"); > - if (ret <= 0) > - return ERR_PTR(ret); > + ret = snprintf(scp_fw_file, sizeof(scp_fw_file), "scp"); > + if (ret >= sizeof(scp_fw_file)) > + return ERR_PTR(-ENAMETOOLONG); > > /* Not using strchr here, as strlen of a const gets optimized by compiler */ > soc = &compatible[strlen("mediatek,")]; -- Thx and BRs, Zhongqiu Han