mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: neil.armstrong@linaro.org
To: srinivas.kandagatla@linaro.org, broonie@kernel.org
Cc: perex@perex.cz, lgirdwood@gmail.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	krzk+dt@kernel.org, krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v2 0/2] ASoC: codecs: lpass: add support for v2.5 rx macro
Date: Thu, 13 Jun 2024 12:18:40 +0200	[thread overview]
Message-ID: <9d7285d2-0dec-4d6f-a3f2-1490261c7206@linaro.org> (raw)
In-Reply-To: <20240606122559.116698-1-srinivas.kandagatla@linaro.org>

On 06/06/2024 14:25, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patchset adds support to reading codec version and also adds
> support for v2.5 codec version in rx macro.
> 
> LPASS 2.5 and up versions have changes in some of the rx blocks which
> are required to get headset functional correctly.
> 
> Tested this on SM8450, X13s and x1e80100 crd.
> 
> This changes also fixes issue with sm8450, sm8550, sm8660 and x1e80100.
> 
> @Neil Armstrong  can you pl test it on sm8650
> 
> @Krzysztof Kozlowski can you pl test it on sm8550
> 
> Thanks,
> Srini
> 
> Changes since v1:
>   - renamed all 2_6 variables with 2.5
>   - expanded checks for versions from 2.5 till 2.8
> 
> Srinivas Kandagatla (2):
>    ASoC: codecs: lpass-macro: add helpers to get codec version
>    ASoC: codec: lpass-rx-macro: add suppor for 2.5 codec version
> 
>   sound/soc/codecs/lpass-macro-common.c |  14 +
>   sound/soc/codecs/lpass-macro-common.h |  35 ++
>   sound/soc/codecs/lpass-rx-macro.c     | 565 +++++++++++++++++++-------
>   sound/soc/codecs/lpass-va-macro.c     |  29 ++
>   4 files changed, 488 insertions(+), 155 deletions(-)
> 

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK

Successfully fixes dual channel output on headset, previously I would only hear
sound on a single channel.

Thanks,
Neil

      parent reply	other threads:[~2024-06-13 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 12:25 srinivas.kandagatla
2024-06-06 12:25 ` [PATCH v2 1/2] ASoC: codecs: lpass-macro: add helpers to get codec version srinivas.kandagatla
2024-06-07 10:58   ` Dmitry Baryshkov
2024-06-06 12:25 ` [PATCH v2 2/2] ASoC: codec: lpass-rx-macro: add suppor for 2.5 " srinivas.kandagatla
2024-06-07 11:03   ` Dmitry Baryshkov
2024-06-12 14:37     ` Srinivas Kandagatla
2024-06-12 16:52       ` Dmitry Baryshkov
2024-06-12 17:09         ` Srinivas Kandagatla
2024-06-12 18:13           ` Dmitry Baryshkov
2024-06-13 10:18 ` neil.armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d7285d2-0dec-4d6f-a3f2-1490261c7206@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®