From: Snild Dolkow <snild@sony.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Enderborg <peter.enderborg@sony.com>,
Yoshitaka Seto <yoshitaka.seto@sony.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH RESEND] kthread, tracing: Don't expose half-written comm when creating kthreads
Date: Mon, 23 Jul 2018 16:23:09 +0200 [thread overview]
Message-ID: <9d762b4e-20a7-578f-90c8-10a044921d67@sony.com> (raw)
In-Reply-To: <20180723095550.08203a24@gandalf.local.home>
On 07/23/2018 03:55 PM, Steven Rostedt wrote:
> Can you add a comment here stating something to the affect of:
> /* task is now visible to other tasks */
>
> -- Steve
Sure, but isn't that a bit misleading? It will have been visible since
some unknown point in time between waking up kthreadd and the return of
wait_for_completion(); we're not the ones making it visible.
//Snild
next prev parent reply other threads:[~2018-07-23 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:42 Snild Dolkow
2018-07-23 13:55 ` Steven Rostedt
2018-07-23 14:23 ` Snild Dolkow [this message]
2018-07-23 15:37 ` Steven Rostedt
2018-07-23 15:49 ` Snild Dolkow
2018-07-23 16:41 ` Steven Rostedt
2018-07-24 8:17 ` Snild Dolkow
2018-07-24 14:48 ` Steven Rostedt
2018-07-24 15:02 ` Snild Dolkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d762b4e-20a7-578f-90c8-10a044921d67@sony.com \
--to=snild@sony.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleksiy.avramchenko@sony.com \
--cc=peter.enderborg@sony.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yoshitaka.seto@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®