From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF751C433E9 for ; Fri, 12 Feb 2021 13:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA06B64E57 for ; Fri, 12 Feb 2021 13:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbhBLNNF (ORCPT ); Fri, 12 Feb 2021 08:13:05 -0500 Received: from foss.arm.com ([217.140.110.172]:36788 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbhBLNCB (ORCPT ); Fri, 12 Feb 2021 08:02:01 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5001D1063; Fri, 12 Feb 2021 05:01:11 -0800 (PST) Received: from [10.37.8.13] (unknown [10.37.8.13]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57E053F719; Fri, 12 Feb 2021 05:01:09 -0800 (PST) Subject: Re: [PATCH v13 6/7] arm64: mte: Report async tag faults before suspend To: Lorenzo Pieralisi Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , Andrey Ryabinin , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org References: <20210211153353.29094-1-vincenzo.frascino@arm.com> <20210211153353.29094-7-vincenzo.frascino@arm.com> <20210212120015.GA18281@e121166-lin.cambridge.arm.com> <20210212123029.GA19585@e121166-lin.cambridge.arm.com> From: Vincenzo Frascino Message-ID: <9d7b4475-dd59-d84f-5835-9222c2758eac@arm.com> Date: Fri, 12 Feb 2021 13:05:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210212123029.GA19585@e121166-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/21 12:30 PM, Lorenzo Pieralisi wrote: >> However, I have a question. We are relying on context switch to set >> sctlr_el1_tfc0 right ? If that's the case, till the thread resuming from >> low power switches context we are running with SCTLR_EL1_TCF0 not >> reflecting the actual value. > Forget this, we obviously restore sctlr_el1 on resume (cpu_do_resume()). > > With the line above removed: > > Reviewed-by: Lorenzo Pieralisi > Thanks Lorenzo, I will remove the register write in the next version and add your tag. -- Regards, Vincenzo