From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794467465; b=VuAUiE00rb8rrnTHMwFnoIuVJ+UvqyBprzd3xUju7lsCZ9AfxanJCfOl4VajMpRIqYAB dy9SNj1eoW0Vv5eI22HA0B43tMyzv5rYvkEnx0u4oY6/inLk/kEtmzNZpRmX/lUttvzsw wRP26nqiVfv3k5edbrC8c3kiMc7M8/VtxGUzk+RHm2U6Xj3AgZ+tTjJadQs+L/4da6lmW UivpXwwvCfl80i2ZD6NCq2O7qJ9GEGQ7tZmrXWQy/e2PfbIfByqmhqj5OfBhL/HlMLHzm 5A/wTQSfz4XANZW3tejOvCcmUsxZyMoO6VwB7CGeYSRuyVpU2+iw35jzVEqPIR947HA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794467465; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:From:To:Cc:References: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Proofpoint-Spam-Info:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=5TGycPLZoXXrJEQMzNiz1GIKN0kmsKgEl+tTw+PDhm4=; b=O4nVmedblUox+2hoih9U87VxiAkipY7I52Tfl7NEZ4fwKQBT2RyvzArTTGLt7EfADVC8 +r8Js050YfzNNKpMTi63tqmZmT98MYf6ESkFh8nTLZCLNR6qxBvjb2w6cgB1p8DvZCiRH 4RSw3P6dBiCs9ffdHyizHGG+ZztXFjH9+9HCkmECEsmvbsTpb25JryXb4sRmUDMEN/62H YXT6lOkwwMOmGM5zPG8yZVxDZyIuMIOIjnAazqtXBbCdfwalWORExOqvkDMK535FlxI8b cHo8uUm56S2x2dKTruFhkM3/dcCgsn38cYMwEoBsED3lrwwKv3lHvLCNve5h7JLdDmQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=IYZ2As59; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=J0LzT43e; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C270B606A339 for ; Thu, 12 Nov 2026 07:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C270B606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=IYZ2As59; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=J0LzT43e Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AC2a0h6597692 for ; Thu, 12 Nov 2026 07:11:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5TGycPLZoXXrJEQMzNiz1GIKN0kmsKgEl+tTw+PDhm4=; b=IYZ2As597Nrm9s+E njEYQIvr1cEN0/3mwFtZffA7VIhx+mxJM67qACl2xV1cTcQkGdSbH1ygkKnLCgl5 GFFx3B9GBx2L7d/+EPEvIEhruXcvIwjOSYJXoWRWspPOqjHBlvnNpAdfCSM4Xerm i0k7yO9WhuuVh4rHzOKI0Qe0frMte1Vnd9771ozbSyOtrS8z4JLi6EuuDUlGwKse 61kYFjf2gr6z3FI8lZlO6nUOo0swkoutyE88jwyZv3N4wLuRjrI75k2cJbz+Mioo YGLL/dubq88PvDt48I7rZ1vwLOdU2L+URGYHDwL/kwU6y1wZOJ0GlizqIMZ88vEL Tl5wOA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hvt153jct-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Nov 2026 07:11:03 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3ad704d4760so4584968a91.3 for ; Wed, 11 Nov 2026 23:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794467463; x=1795072263; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5TGycPLZoXXrJEQMzNiz1GIKN0kmsKgEl+tTw+PDhm4=; b=J0LzT43evjkjCTDmDjme4gT8il4OlkZ+jkqqB/4JEF7PTwHLiGHxFIEWQPKuOpzsGa Wpq8hA96Z4l1BHivwdsNjs+QAOssqU0FnCm8ShSW1JphN0yjNnwgQAwGIifOxtjs6oa6 LXcbE92wdQrgtz8sOS10fPFGEv/Ed8VLwgLc0gqMi82n3AoUuSFpjmZZ4hPlL8agxY4D GEQgpFwDWGce/DfwCUVIhafmc2pDtEq2RgBOhYG8h5S3JunMjiukXWhF4jxhEGMOQRno IKo3k6FsIY6rz4gv1mFObJeys24AfoUtMJvnvrkkPc/JrGyXgOfmaOC41o+SJ+0ALxMu 3KuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794467463; x=1795072263; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5TGycPLZoXXrJEQMzNiz1GIKN0kmsKgEl+tTw+PDhm4=; b=sT5F5n8bDupfgFWRBPYvtIJ49BYjVnFwuL5UHY2X/2kdIh/D8dYoXz59fhSNfydaQ/ uBuNYyl4r70anESJPBN+mux0tTtwk7bmRmjMwI5EquCDOFP0XGbyPZZRzIHHNpdGwr0d K/SVChYanW+jPuSzFR+9oyGXrmpQ1ic2RtS4SJt0ADlYRA6EQI+tp4+cLARpQbDSaVJQ ub0dnADgabItcsNfTG0Et688iLRLm4dzTJ/T4kI70o28DVlZBK2iHMausR4Do1LHudOb dcj4a4e/SpvOLGBRhMphWUmtlj+O46Mcn6MuEbBv8O4/wijWwNdBwiZwV1rSNCesipS9 s9cg== X-Forwarded-Encrypted: i=1; AL+hErHre5sf0oq/jp4EiDND6s0TahZOL3b0CafNW3meNUpon4PhrFKp1mo+ZDUk1qrubrxz0+hz42CeFi15png=@vger.kernel.org X-Gm-Message-State: APuU4Z8aBbQCqVyzi3X6esuHjBxNJ5iCgn3DDHUhe9g50kykqKlm283s ObelFufVb1DPJ5MROtAvuHvupmfFPl/myEUm3KsNw0c1XFD0WxIwlRamkbxBrRMGT8p2hFMhiEC zQA+Oqh7a0L+0jHsmJNvTxhuOfECp9r1Wj39MMm4jtn3Geo8N6zirb9F2zvuR/2sX0jM= X-Gm-Gg: AYBFou3Ns+d+2HW5HSdaeO9Hej6FKniNbR6TPv/qgvqcn2zhbD+9vv5APRQaY3GXI94 1p0aGCtDR6FpqM3IQHhO8wmcEi4+GkoDsUekJkUMDLL/858R/Di34aaLefDmlTs82VrwV4DOcFU WOBiedDJe3s2I6owYmZ4W6vILN6Trt490E/kmRUqCQuF03vCqhLOV4bLooVFiRMBN9gPBtS1WVe OZu+DUJKlLSX4byQm24nTYuHmOoyHjYMRrIASfrlb83GGZMrI2V/7iLmNW5YpfIWSgULxCLYVlG l09vQAbJVgCx9uWNZv7KOrimO62ECGJTlV2W/U2rtXwNFHqSoewJkOXmJC5nrnGCFevz5X/6zjB RxVRwkJqnnfrD6ibkSfBkFAk43wSJYIsNpVRJwT0bGX6qz1QfrQKCsiXqZSOmqKpIxNyHSNjdKc g= X-Received: by 2002:a17:90b:180b:b0:3ac:8897:7bab with SMTP id 98e67ed59e1d1-3b182dea9d4mr4105857a91.6.1794467462524; Wed, 11 Nov 2026 23:11:02 -0800 (PST) X-Received: by 2002:a17:90b:180b:b0:3ac:8897:7bab with SMTP id 98e67ed59e1d1-3b182dea9d4mr4105839a91.6.1794467462005; Wed, 11 Nov 2026 23:11:02 -0800 (PST) Received: from [10.239.31.126] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b197c6dd2dsm3063939a91.2.2026.11.11.23.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2026 23:11:01 -0800 (PST) Message-ID: <9d80c088-1a0e-48fc-9a24-09fa8c281cd7@oss.qualcomm.com> Date: Thu, 12 Nov 2026 15:10:55 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance From: Fenglin Wu To: Jeff Roach Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Alexandre Belloni , David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , Tingguo Cheng , linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261110-gio-framework-rtc-driver-2026-10-12-v1-2-e4164178183a@oss.qualcomm.com> <20261111131424.51869-1-jeff.roach0@gmail.com> <0fa09b92-3855-40b0-af6d-2c763235b15e@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <0fa09b92-3855-40b0-af6d-2c763235b15e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEyMDAyOCBTYWx0ZWRfX7ZP04vDH3Rae rcBbbuA9tvi0Nadfy44ZbNogFdBCngHREhC0wKzTGUV9GA0F3jGgn1Ui9jghIqCufrKIeiCaTq7 D4AdoAztopBtAYZbwyv8+R368bHnKl0= X-Authority-Analysis: v=2.4 cv=Yrya1IYX c=1 sm=1 tr=0 ts=6af56687 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=n58xdIrCezaV6CGXdrwA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: d3dEuDzbAPCINYvivkprgKX_jhgWlQ98 X-Proofpoint-ORIG-GUID: d3dEuDzbAPCINYvivkprgKX_jhgWlQ98 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEyMDAyOCBTYWx0ZWRfX62YEGWgw/Cuw t/+bbBxWD1bimQSOR1lVJyZaP2OHgQwP8fz9cR7pS6faL3I9pSqC2GPhZ66eFOEvkoWbbhcaMVy iK3p31+GINvm4GzXTpUMc1pb72YfaCk7JSXGBp8uzXJvR+o4dzX1MZzZSxM4Y01nhu5baplmrOi O6GEwYSkItGt3dS+hG5paI+FHrSq6wU4LUr4G1uBbVEDSbtpI5+hp1SYE+SqUpiVQeRaUHNSAD3 h2sVX4AHaCMJksfC/0O1kn0LASeA/7WgsBhYPEZDjDX8h1Kof3uVwRnlquezqQt2xCil/yBvgmX HgYhTK5e9b7AIOcAPN7CPUDtSvxe3x49GGsvo0jqtyrEQ2ibGDL+yxGfgJ3FTRMg2Oe7KycWxVa BVROMgcTWy9yLKWTCxeL+3gYWc7NaWoniHzxipP0VOEpEACJankP5rv5X03gbGHXmaRH3IaDjwk weqDAKD3z0aNAqMrw4g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-12_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611120028 On 11/12/2026 9:11 AM, Fenglin Wu wrote: > > > On 11/11/2026 9:14 PM, Jeff Roach wrote: >> Hi Fenglin, >> >> I tried this series on an HP OmniBook X 16 (X2 Elite "Mahua", DT boot, >> qcom,glymur-pmic-glink, 7.3-based kernel, firmware F.04). The RTC part >> works: rtc-qcom-gio reads the correct UTC time. >> >> But UCSI breaks when pmic_glink_gio is bound, although the commit >> message says ucsi stays on the legacy interface: >> >> - pmic_glink_gio loaded at boot: ucsi_glink fails with >> "error -ETIMEDOUT: PPM init failed", no typec ports. >> - pmic_glink_gio blacklisted (patched pmic_glink still loaded): typec >> ports and partners come up, plug/unplug is seen. >> - Same boot, then modprobe pmic_glink_gio: the RTC works and the ports >> stay, but UCSI no longer sees any plug or unplug (old partners stay). >> USB data and charging still work. >> >> Happy to test a fix. >> >> Jeff > > Hi Jeff, > > Thanks for testing the changes and reporting the issues. > > I tested with all clients switched to use GIO interface. I confirmed > that battmgr, UCSI, altmode worked as expected. I should also test the > hybrid mode of only having RTC used on GIO and others left in PMIC > Glink. I thought I didn't push those client changes so those drivers > were not impacted and they should work as before. > > I will test it this way and get back. > > Thanks > Fenglin Hi Jeff, My initial impression was that the SoCCP battery management firmware might not handle this hybrid mode (GIO + legacy OPCODE) well. Enabling the GIO alert might cause the charger firmware to select the GIO interface over the legacy OPCODE by default. I made a simple change to prevent the global alert from being enabled, and the issue you mentioned was resolved at my side. This will not impact RTC driver anyway, as RTC doesn't need to handle alert messages. Could you try this on your side? If it works there as well, I can discuss it with the firmware team and come up with a formal fix when pushing next patch. diff --git a/drivers/soc/qcom/pmic_glink_gio.c b/drivers/soc/qcom/pmic_glink_gio.c index 83656a5758b8..fc5dcc62b200 100644 --- a/drivers/soc/qcom/pmic_glink_gio.c +++ b/drivers/soc/qcom/pmic_glink_gio.c @@ -310,14 +310,14 @@ static void pmic_glink_gio_pdr_notify(void *priv, int state) static void pmic_glink_gio_enable_alerts(struct pmic_glink_gio *pgio) { - __le32 data; - int ret; - - data = cpu_to_le32(GIO_CORE_GLOBAL_ALERT_MODE_IBI | GIO_CORE_GLOBAL_ALERT_EN_BIT); - - ret = regmap_raw_write(pgio->gio->regmap, GIO_CORE_GLOBAL_ALERT_CTRL_ADDR, &data, 4); - if (ret) - dev_err(pgio->dev, "GIO turn on global alert failed: %d\n", ret); +// __le32 data; +// int ret; +// +// data = cpu_to_le32(GIO_CORE_GLOBAL_ALERT_MODE_IBI | GIO_CORE_GLOBAL_ALERT_EN_BIT); +// +// ret = regmap_raw_write(pgio->gio->regmap, GIO_CORE_GLOBAL_ALERT_CTRL_ADDR, &data, 4); +// if (ret) +// dev_err(pgio->dev, "GIO turn on global alert failed: %d\n", ret); } Thanks Fenglin Wu >