From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Yangtao Li <frank.li@vivo.com>, Richard Weinberger <richard@nod.at>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2, RESEND 05/10] ubifs: convert to kobject_del_and_put()
Date: Mon, 20 Mar 2023 10:55:51 +0800 [thread overview]
Message-ID: <9d8258af-4f27-7897-26f9-32dd8ca9b20c@huawei.com> (raw)
In-Reply-To: <20230319092641.41917-5-frank.li@vivo.com>
Hi Yangtao,
> Use kobject_del_and_put() to simplify code.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/ubifs/sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
> index 1c958148bb87..9571718e61a9 100644
> --- a/fs/ubifs/sysfs.c
> +++ b/fs/ubifs/sysfs.c
> @@ -130,8 +130,7 @@ int ubifs_sysfs_register(struct ubifs_info *c)
>
> void ubifs_sysfs_unregister(struct ubifs_info *c)
> {
> - kobject_del(&c->kobj);
> - kobject_put(&c->kobj);
> + kobject_del_and_put(&c->kobj);
> wait_for_completion(&c->kobj_unregister);
>
> kfree(c->stats);
>
Maybe you can send the entire patchset to linux-mtd next time, I can
only see patch 5 from the maillist. After confirming from other
website(https://www.spinics.net/lists/kernel/msg4727274.html) I see you
instroduced the implementation of kobject_del_and_put().
I have no objections if other modules can accept the kobject_del_and_put().
next prev parent reply other threads:[~2023-03-20 2:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 9:26 [PATCH v2, RESEND 01/10] kobject: introduce kobject_del_and_put() Yangtao Li
2023-03-19 9:26 ` [PATCH v2, RESEND 02/10] f2fs: convert to kobject_del_and_put() Yangtao Li
2023-03-19 9:26 ` [PATCH v2, RESEND 03/10] erofs: " Yangtao Li
2023-03-19 9:26 ` [PATCH v2, RESEND 04/10] zonefs: " Yangtao Li
2023-03-19 21:42 ` Damien Le Moal
2023-03-19 9:26 ` [PATCH v2, RESEND 05/10] ubifs: " Yangtao Li
2023-03-20 2:55 ` Zhihao Cheng [this message]
2023-03-19 9:26 ` [PATCH v2, RESEND 06/10] btrfs: " Yangtao Li
2023-03-20 15:54 ` David Sterba
2023-03-19 9:26 ` [PATCH v2, RESEND 07/10] xfs: " Yangtao Li
2023-03-20 14:58 ` Darrick J. Wong
2023-03-19 9:26 ` [PATCH v2, RESEND 08/10] ocfs2: " Yangtao Li
2023-03-20 3:35 ` Joseph Qi
2023-03-19 9:26 ` [PATCH v2, RESEND 09/10] nfs: " Yangtao Li
2023-03-19 9:26 ` [PATCH v2, RESEND 10/10] nilfs2: " Yangtao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8258af-4f27-7897-26f9-32dd8ca9b20c@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=frank.li@vivo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®