From: Kunwu Chan <chentao@kylinos.cn>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"npiggin@gmail.com" <npiggin@gmail.com>
Cc: "kunwu.chan@hotmail.com" <kunwu.chan@hotmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/mm: Fix null-pointer dereference in pgtable_cache_add
Date: Mon, 27 Nov 2023 14:04:24 +0800 [thread overview]
Message-ID: <9d871364-7baa-4daf-8b0c-3fbfbede6fdb@kylinos.cn> (raw)
In-Reply-To: <32077b74-7335-4f4d-8858-c53c820150d0@csgroup.eu>
Hi Christophe,
Thanks for your reply.
It's my bad. According your reply, i read the code in
sysfs_do_create_link_sd.There is a null pointer check indeed.
My intention was to check null pointer after memory allocation.
Whether we can add a comment here for someone like me, the null pointer
check is no need here?
Thanks,
Kunwu
On 2023/11/24 23:17, Christophe Leroy wrote:
>
>
> Le 22/11/2023 à 10:00, Kunwu Chan a écrit :
>> [Vous ne recevez pas souvent de courriers de chentao@kylinos.cn. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> kasprintf() returns a pointer to dynamically allocated memory
>> which can be NULL upon failure. Ensure the allocation was successful
>> by checking the pointer validity.
>
> Are you sure this is needed ? Did you check what happens what name is NULL ?
>
> If I followed stuff correctly, I end up in function
> sysfs_do_create_link_sd() which already handles the NULL name case which
> a big hammer warning.
>
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>> arch/powerpc/mm/init-common.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c
>> index 119ef491f797..0884fc601c46 100644
>> --- a/arch/powerpc/mm/init-common.c
>> +++ b/arch/powerpc/mm/init-common.c
>> @@ -139,6 +139,8 @@ void pgtable_cache_add(unsigned int shift)
>>
>> align = max_t(unsigned long, align, minalign);
>> name = kasprintf(GFP_KERNEL, "pgtable-2^%d", shift);
>> + if (!name)
>> + return;
>> new = kmem_cache_create(name, table_size, align, 0, ctor(shift));
>> if (!new)
>> panic("Could not allocate pgtable cache for order %d", shift);
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2023-11-27 6:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:00 Kunwu Chan
2023-11-24 15:17 ` Christophe Leroy
2023-11-27 6:04 ` Kunwu Chan [this message]
2023-11-28 11:32 ` Michael Ellerman
[not found] ` <1701224210300483.328.seg@mailgw>
2023-11-30 8:45 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d871364-7baa-4daf-8b0c-3fbfbede6fdb@kylinos.cn \
--to=chentao@kylinos.cn \
--cc=christophe.leroy@csgroup.eu \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®