mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Doug V Johnson <dougvj@dougvj.net>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Doug Johnson <dougvj@gmail.com>, Song Liu <song@kernel.org>,
	"open list:SOFTWARE RAID (Multiple Disks) SUPPORT"
	<linux-raid@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2 1/2] md/raid5: freeze reshape when encountering a bad read
Date: Tue, 18 Feb 2025 07:20:01 +0000	[thread overview]
Message-ID: <9d878dea7b1afa2472f8f583fd116e31@dougvj.net> (raw)
In-Reply-To: <21f250f9-04b5-76f6-84c9-1fd245b748c6@huaweicloud.com>

> Perhaps, check badblocks before starting reshape in the first place can
> solve most problems in this case? We can keep this patch just in case
> new badblocks are set while performing reshape.
> 
> Thanks,
> Kuai
> 
This is a really good idea and should mitigate the risk of getting into 
these weird states. I started work on a patch that seems to work, I will 
submit it after I have done some testing.

Thanks for your feedback,
Doug

  reply	other threads:[~2025-02-18  7:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-25  1:26 [PATCH 1/2] md/raid5: skip stripes with bad reads during reshape to avoid stall Doug V Johnson
2025-01-25  1:26 ` [PATCH 2/2] md/raid5: warn when failing a read due to bad blocks metadata Doug V Johnson
2025-01-26  6:27 ` [PATCH 1/2] md/raid5: skip stripes with bad reads during reshape to avoid stall Yu Kuai
2025-01-27  8:51   ` Doug V Johnson
2025-01-27  9:00   ` [PATCH v2 1/2] md/raid5: freeze reshape when encountering a bad read Doug V Johnson
2025-01-27  9:00     ` [PATCH v2 2/2] md/raid5: warn when failing a read due to bad blocks metadata Doug V Johnson
2025-02-08  2:49     ` [PATCH v2 1/2] md/raid5: freeze reshape when encountering a bad read Yu Kuai
2025-02-18  7:20       ` Doug V Johnson [this message]
2025-02-24  9:02         ` [PATCH v3 1/3] " Doug V Johnson
2025-02-24  9:02           ` [PATCH v3 2/3] md/raid5: warn when failing a read due to bad blocks metadata Doug V Johnson
2025-02-24  9:02           ` [PATCH v3 3/3] md/raid5: check for overlapping bad blocks before starting reshape Doug V Johnson
2025-03-05  6:36             ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d878dea7b1afa2472f8f583fd116e31@dougvj.net \
    --to=dougvj@dougvj.net \
    --cc=dougvj@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®