From: Kishon Vijay Abraham I <kishon@ti.com>
To: Douglas Anderson <dianders@chromium.org>, <heiko@sntech.de>,
<zyw@rock-chips.com>
Cc: <groeck@chromium.org>, <shawnn@chromium.org>,
<dnschneid@chromium.org>, <linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing
Date: Thu, 21 Sep 2017 16:06:49 +0530 [thread overview]
Message-ID: <9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com> (raw)
In-Reply-To: <20170919195630.18747-1-dianders@chromium.org>
Hi Douglas,
On Wednesday 20 September 2017 01:26 AM, Douglas Anderson wrote:
> When connecting to certain DP monitors it was observed that only one
> of the two orientations of the type C to DP cable would work.
> Debugging showed that the problem was that we needed to set the type C
> "flip" state earlier. Once we did this, problems went away.
>
> While trying to dig into this problem and some others, I found that
> the proper documentation for the Type C PHY was available to me. This
> allowed me to cleanup the magic numbers in the funtion that I was
> touching and also fix a few minor issues that (luckily) haven't caused
> any problems yet.
>
> I also found that aux channel communications were flaky on some
> adapters until I adjusted the voltage swing.
>From the commit log, looks like only the 1st and 4th patch are fixes. Only
those can go in -rc cycle. But I can't apply the 4th patch without the 2nd and
3rd patch.
Can you resend the series such that 2nd and 3rd patch apply on top of 1st and
4th patch?
Thanks
Kishon
next prev parent reply other threads:[~2017-09-21 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 19:56 Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 1/4] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 2/4] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 3/4] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson
2017-09-19 19:56 ` [PATCH v2 4/4] phy: rockchip-typec: Don't set the aux voltage swing to 400 mV Douglas Anderson
2017-09-21 10:36 ` Kishon Vijay Abraham I [this message]
2017-09-22 16:45 ` [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com \
--to=kishon@ti.com \
--cc=dianders@chromium.org \
--cc=dnschneid@chromium.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawnn@chromium.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®