From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, kbuild test robot <lkp@intel.com>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: Re: sound/soc/intel/boards/hda_dsp_common.c:76: undefined reference to `snd_hda_codec_build_controls'
Date: Thu, 6 Feb 2020 12:01:24 -0600 [thread overview]
Message-ID: <9d8d130f-47d5-03a5-484e-b0865c6de6f8@linux.intel.com> (raw)
In-Reply-To: <e82ceb12-2d0e-ccec-8d8d-eef556918c53@linux.intel.com>
>>> ld: sound/soc/intel/boards/hda_dsp_common.o: in function
>>> `hda_dsp_hdmi_build_controls':
>>>>> sound/soc/intel/boards/hda_dsp_common.c:76: undefined reference to
>>>>> `snd_hda_codec_build_controls'
>>
>> Looks like the revert select enforcing the built-in of SOF while the
>> legacy HDA is a module. It doesn't look so trivial to fix...
>
> SOF in this case is build as a module, but the machine driver isn't.
>
> It seems like the SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH option is
> different from others machine drivers. All others can only be either M
> or not selected, but here we have a case where the selection can be M or y.
Suggested fix is here, running it through our CI tests for now:
https://github.com/thesofproject/linux/pull/1768
This should be caught by kbuild tests as well.
prev parent reply other threads:[~2020-02-06 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 5:29 kbuild test robot
2020-02-06 7:54 ` Takashi Iwai
2020-02-06 16:55 ` Pierre-Louis Bossart
2020-02-06 18:01 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8d130f-47d5-03a5-484e-b0865c6de6f8@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®