From: Johannes Berg <johannes@sipsolutions.net>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 wireless] mac80211: stop tpt LED trigger timer before freeing trigger
Date: Sat, 05 Sep 2026 08:15:06 +0200 [thread overview]
Message-ID: <9d91e1719383f8ba6dfc45650a92b1f2c2bc2f6b.camel@sipsolutions.net> (raw)
In-Reply-To: <CAKxU2N9ZPRSotiPhayrQFyzbf=sPcU7X3o6ozRECOibhCj_kbA@mail.gmail.com> (sfid-20260904_211629_075221_49F57F20)
On Fri, 2026-09-04 at 12:16 -0700, Rosen Penev wrote:
> On Fri, Sep 4, 2026 at 12:41 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> >
> > On Sat, 2026-08-15 at 12:07 -0700, Rosen Penev wrote:
> > > On a hot unplug, the device is torn down
> > > through ieee80211_unregister_hw() without ever going through
> > > ieee80211_do_stop(), so the timer is never stopped.
> >
> > I don't buy this.
> >
> > Also, missed wifi: prefix.
> >
> > Please don't just feed me LLM garbage. Do you have a crash reported on
> > this?
> Not formally no. However I am able to reliably panic the kernel. After
> this patch I can't.
Then you can probably enable debug objects etc. to figure out why?
I don't think this patch really fixes the cause, just the symptom.
Maybe it's related to this:
https://lore.kernel.org/linux-wireless/20260904165722.044aa432f873.I601a67a2cd558b8ef8416a07554ae7efe896e9d8@changeid/
johannes
next prev parent reply other threads:[~2026-09-05 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 19:07 Rosen Penev
2026-09-04 7:41 ` Johannes Berg
2026-09-04 19:16 ` Rosen Penev
2026-09-05 6:15 ` Johannes Berg [this message]
2026-09-05 19:41 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d91e1719383f8ba6dfc45650a92b1f2c2bc2f6b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®